From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
"Luca Ceresoli" <luca.ceresoli@bootlin.com>,
"Matti Vaittinen" <Matti.Vaittinen@fi.rohmeurope.com>,
"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
"Sakari Ailus" <sakari.ailus@linux.intel.com>,
"Wolfram Sang" <wsa@kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Peter Rosin" <peda@axentia.se>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
"Michael Tretter" <m.tretter@pengutronix.de>,
"Hans Verkuil" <hverkuil@xs4all.nl>,
"Mike Pagano" <mpagano@gentoo.org>,
"Krzysztof Hałasa" <khalasa@piap.pl>,
"Marek Vasut" <marex@denx.de>,
"Satish Nagireddy" <satish.nagireddy@getcruise.com>
Subject: Re: [PATCH v14 11/18] media: i2c: ds90ub9xx: Select GPIOLIB rather than OF_GPIO
Date: Fri, 16 Jun 2023 17:17:28 +0300 [thread overview]
Message-ID: <ZIxu+IvTSaFW3erU@smile.fi.intel.com> (raw)
In-Reply-To: <20230616135922.442979-12-tomi.valkeinen@ideasonboard.com>
On Fri, Jun 16, 2023 at 04:59:15PM +0300, Tomi Valkeinen wrote:
> Select GPIOLIB rather than OF_GPIO, as the drivers use gpiolib
> functionality, but no of_gpio (directly).
This is useful change, but has to be folded in the original code.
We do not want even a trace of newly added OF_GPIO.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
> ---
> drivers/media/i2c/Kconfig | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
> index 8a5f09a3de6c..29fc00e30d8b 100644
> --- a/drivers/media/i2c/Kconfig
> +++ b/drivers/media/i2c/Kconfig
> @@ -1622,7 +1622,7 @@ config VIDEO_DS90UB913
> depends on OF && I2C && VIDEO_DEV && COMMON_CLK
> select I2C_ATR
> select MEDIA_CONTROLLER
> - select OF_GPIO
> + select GPIOLIB
> select REGMAP_I2C
> select V4L2_FWNODE
> select VIDEO_V4L2_SUBDEV_API
> @@ -1635,7 +1635,7 @@ config VIDEO_DS90UB953
> depends on OF && I2C && VIDEO_DEV && COMMON_CLK
> select I2C_ATR
> select MEDIA_CONTROLLER
> - select OF_GPIO
> + select GPIOLIB
> select REGMAP_I2C
> select V4L2_FWNODE
> select VIDEO_V4L2_SUBDEV_API
> @@ -1648,7 +1648,7 @@ config VIDEO_DS90UB960
> depends on OF && I2C && VIDEO_DEV && COMMON_CLK
> select I2C_ATR
> select MEDIA_CONTROLLER
> - select OF_GPIO
> + select GPIOLIB
> select REGMAP_I2C
> select V4L2_FWNODE
> select VIDEO_V4L2_SUBDEV_API
> --
> 2.34.1
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-06-16 14:17 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-16 13:59 [PATCH v14 00/18] i2c-atr and FPDLink Tomi Valkeinen
2023-06-16 13:59 ` [PATCH v14 01/18] dt-bindings: i2c: Add I2C Address Translator (ATR) Tomi Valkeinen
2023-06-16 13:59 ` [PATCH v14 02/18] i2c: add I2C Address Translator (ATR) support Tomi Valkeinen
2023-06-16 13:59 ` [PATCH v14 03/18] dt-bindings: media: add TI DS90UB913 FPD-Link III Serializer Tomi Valkeinen
2023-06-16 13:59 ` [PATCH v14 04/18] dt-bindings: media: add TI DS90UB953 " Tomi Valkeinen
2023-06-16 13:59 ` [PATCH v14 05/18] dt-bindings: media: add TI DS90UB960 FPD-Link III Deserializer Tomi Valkeinen
2023-06-16 13:59 ` [PATCH v14 06/18] media: i2c: add DS90UB960 driver Tomi Valkeinen
2023-06-16 13:59 ` [PATCH v14 07/18] media: i2c: add DS90UB913 driver Tomi Valkeinen
2023-06-16 13:59 ` [PATCH v14 08/18] media: i2c: add DS90UB953 driver Tomi Valkeinen
2023-06-16 13:59 ` [PATCH v14 09/18] media: i2c: ds90ub960: Fix use of UB960_SR_FWD_CTL1 Tomi Valkeinen
2023-06-16 13:59 ` [PATCH v14 10/18] media: i2c: ds90ub9xx: Add COMMON_CLK kconfig dependency Tomi Valkeinen
2023-06-16 13:59 ` [PATCH v14 11/18] media: i2c: ds90ub9xx: Select GPIOLIB rather than OF_GPIO Tomi Valkeinen
2023-06-16 14:17 ` Andy Shevchenko [this message]
2023-06-19 8:40 ` Tomi Valkeinen
2023-06-16 13:59 ` [PATCH v14 12/18] media: i2c: ds90ub960: Configure CSI-2 continuous clock Tomi Valkeinen
2023-06-16 13:59 ` [PATCH v14 13/18] media: i2c: ds90ub953: Use v4l2_fwnode_endpoint_parse() Tomi Valkeinen
2023-06-16 14:24 ` Andy Shevchenko
2023-06-19 8:52 ` Tomi Valkeinen
2023-06-16 13:59 ` [PATCH v14 14/18] media: i2c: ds90ub913: " Tomi Valkeinen
2023-06-16 13:59 ` [PATCH v14 15/18] media: i2c: ds90ub953: Handle V4L2_MBUS_CSI2_NONCONTINUOUS_CLOCK Tomi Valkeinen
2023-06-16 14:33 ` Andy Shevchenko
2023-06-19 10:37 ` Tomi Valkeinen
2023-06-16 13:59 ` [PATCH v14 16/18] media: i2c: ds90ub960: Allow FPD-Link async mode Tomi Valkeinen
2023-06-16 14:34 ` Andy Shevchenko
2023-06-19 9:04 ` Tomi Valkeinen
2023-06-16 13:59 ` [PATCH v14 17/18] media: i2c: ds90ub953: Restructure clkout management Tomi Valkeinen
2023-06-16 14:37 ` Andy Shevchenko
2023-06-16 14:43 ` [PATCH v1 1/1] math.h: Introduce struct u8_fract and struct s8_fract Andy Shevchenko
2023-06-19 10:14 ` [PATCH v14 17/18] media: i2c: ds90ub953: Restructure clkout management Tomi Valkeinen
2023-06-19 10:44 ` Andy Shevchenko
2023-06-19 11:11 ` Tomi Valkeinen
2023-06-19 11:27 ` Andy Shevchenko
2023-06-16 13:59 ` [PATCH v14 18/18] media: i2c: ds90ub953: Support non-sync mode Tomi Valkeinen
2023-06-16 14:47 ` Andy Shevchenko
2023-06-19 9:00 ` Tomi Valkeinen
2023-06-19 10:48 ` Andy Shevchenko
2023-06-19 10:57 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZIxu+IvTSaFW3erU@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Matti.Vaittinen@fi.rohmeurope.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil@xs4all.nl \
--cc=khalasa@piap.pl \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=lgirdwood@gmail.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=luca.ceresoli@bootlin.com \
--cc=m.tretter@pengutronix.de \
--cc=marex@denx.de \
--cc=mchehab@kernel.org \
--cc=mpagano@gentoo.org \
--cc=peda@axentia.se \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=satish.nagireddy@getcruise.com \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.