From: Cyril Hrubis <chrubis@suse.cz>
To: Petr Vorel <pvorel@suse.cz>
Cc: NeilBrown <neilb@suse.de>, ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2 2/3] fsstress/global.h: Use _GNU_SOURCE
Date: Thu, 29 Jun 2023 15:17:04 +0200 [thread overview]
Message-ID: <ZJ2EUIqpqwUn0GzC@yuki> (raw)
In-Reply-To: <20230629115137.GA207849@pevik>
Hi!
> > Just a very minor nit, such cleanups should be in a separate patch.
> I'm sorry, I sometimes try to blance between separating changes and too many commits.
> I can put this to separate commit.
I tend to be picky in separating formatting changes from actuall fixes...
> > Otherwise the rest of the changes looks good:
> Is that that this is just this patch. Please let me know if you're meant whole
> patchset (it'd make sense, it's pretty simple).
That was for the whole patchset, sorry for not being clear.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2023-06-29 13:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-28 13:07 [LTP] [PATCH v2 0/3] Remove O_DIRECT definition Petr Vorel
2023-06-28 13:07 ` [LTP] [PATCH v2 1/3] lapi/fcntl.h: " Petr Vorel
2023-06-28 13:07 ` [LTP] [PATCH v2 2/3] fsstress/global.h: Use _GNU_SOURCE Petr Vorel
2023-06-28 13:35 ` Cyril Hrubis
2023-06-29 11:51 ` Petr Vorel
2023-06-29 13:17 ` Cyril Hrubis [this message]
2023-06-29 13:32 ` Petr Vorel
2023-06-28 13:07 ` [LTP] [PATCH v2 3/3] ltpscsi/scsimain.c: Remove O_DIRECT fallback definition Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJ2EUIqpqwUn0GzC@yuki \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
--cc=neilb@suse.de \
--cc=pvorel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.