All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sean Christopherson <seanjc@google.com>
To: Like Xu <like.xu.linux@gmail.com>
Cc: David Woodhouse <dwmw@amazon.co.uk>,
	Paolo Bonzini <pbonzini@redhat.com>,
	kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KVM: selftests: Fix the meta info of test cases in the header comments
Date: Thu, 29 Jun 2023 08:55:18 -0700	[thread overview]
Message-ID: <ZJ2pZh4GeBytq7R2@google.com> (raw)
In-Reply-To: <20230629142633.86034-1-likexu@tencent.com>

On Thu, Jun 29, 2023, Like Xu wrote:
> From: Like Xu <likexu@tencent.com>
> 
> Fix test case names (including descriptions) in comments for
> tsc_scaling_sync and xen_shinfo_test. No functional changes intended.
> 
> Fixes: e467b0de82b2 ("KVM: x86: Test case for TSC scaling and offset sync")
> Fixes: 8d4e7e80838f ("KVM: x86: declare Xen HVM shared info capability and add test case")
> Signed-off-by: Like Xu <likexu@tencent.com>
> ---
>  tools/testing/selftests/kvm/x86_64/tsc_scaling_sync.c | 4 ++--
>  tools/testing/selftests/kvm/x86_64/xen_shinfo_test.c  | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/testing/selftests/kvm/x86_64/tsc_scaling_sync.c b/tools/testing/selftests/kvm/x86_64/tsc_scaling_sync.c
> index 5b669818e39a..cdb214660e0a 100644
> --- a/tools/testing/selftests/kvm/x86_64/tsc_scaling_sync.c
> +++ b/tools/testing/selftests/kvm/x86_64/tsc_scaling_sync.c
> @@ -1,10 +1,10 @@
>  // SPDX-License-Identifier: GPL-2.0-only
>  /*
> - * svm_vmcall_test
> + * tsc_scaling_sync
>   *
>   * Copyright � 2021 Amazon.com, Inc. or its affiliates.
>   *
> - * Xen shared_info / pvclock testing
> + * Test case for TSC scaling and offset sync

I vote to delete the metadata (but leave the Copyright).  IMO it adds zero value,
and has a non-zero chance of becoming stale in the future.

>   */
>  
>  #include "test_util.h"
> diff --git a/tools/testing/selftests/kvm/x86_64/xen_shinfo_test.c b/tools/testing/selftests/kvm/x86_64/xen_shinfo_test.c
> index 05898ad9f4d9..60daee9f3514 100644
> --- a/tools/testing/selftests/kvm/x86_64/xen_shinfo_test.c
> +++ b/tools/testing/selftests/kvm/x86_64/xen_shinfo_test.c
> @@ -1,6 +1,6 @@
>  // SPDX-License-Identifier: GPL-2.0-only
>  /*
> - * svm_vmcall_test
> + * xen_shinfo_test
>   *
>   * Copyright � 2021 Amazon.com, Inc. or its affiliates.
>   *
> 
> base-commit: 88bb466c9dec4f70d682cf38c685324e7b1b3d60
> -- 
> 2.32.0
> 

      reply	other threads:[~2023-06-29 15:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-29 14:26 [PATCH] KVM: selftests: Fix the meta info of test cases in the header comments Like Xu
2023-06-29 15:55 ` Sean Christopherson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZJ2pZh4GeBytq7R2@google.com \
    --to=seanjc@google.com \
    --cc=dwmw@amazon.co.uk \
    --cc=kvm@vger.kernel.org \
    --cc=like.xu.linux@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.