From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Yiyuan Guo <yguoaz@gmail.com>
Cc: jic23@kernel.org, lars@metafoo.de, bleung@chromium.org,
groeck@chromium.org, dianders@chromium.org,
mazziesaccount@gmail.com, gwendal@chromium.org,
linux-iio@vger.kernel.org, chrome-platform@lists.linux.dev
Subject: Re: [PATCH] iio: Fix the allocation size for cros_ec_command
Date: Fri, 30 Jun 2023 13:13:46 +0800 [thread overview]
Message-ID: <ZJ5kiiuhITCpqwrn@google.com> (raw)
In-Reply-To: <20230629132405.1237292-1-yguoaz@gmail.com>
On Thu, Jun 29, 2023 at 09:24:05PM +0800, Yiyuan Guo wrote:
> The struct cros_ec_command contains several integer fields and a
> trailing array. An allocation size neglecting the integer fields can
> lead to buffer overrun.
>
> Signed-off-by: Yiyuan Guo <yguoaz@gmail.com>
Better prefix the commit title with "iio: cros_ec:".
With that:
Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org>
next prev parent reply other threads:[~2023-06-30 5:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-29 13:24 [PATCH] iio: Fix the allocation size for cros_ec_command Yiyuan Guo
2023-06-30 5:13 ` Tzung-Bi Shih [this message]
2023-06-30 6:31 ` [PATCH v2] iio: cros_ec: " Yiyuan Guo
2023-06-30 7:36 ` Tzung-Bi Shih
2023-06-30 8:31 ` [PATCH v3] " Yiyuan Guo
2023-06-30 14:06 ` Guenter Roeck
2023-06-30 14:42 ` yguoaz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJ5kiiuhITCpqwrn@google.com \
--to=tzungbi@kernel.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=dianders@chromium.org \
--cc=groeck@chromium.org \
--cc=gwendal@chromium.org \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=mazziesaccount@gmail.com \
--cc=yguoaz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.