From: Kent Gibson <warthog618@gmail.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Viresh Kumar <viresh.kumar@linaro.org>,
linux-gpio@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [libgpiod][PATCH] build: remove redundant SOURCES assignments
Date: Fri, 30 Jun 2023 20:31:53 +0800 [thread overview]
Message-ID: <ZJ7LOWuPIwR/fVyk@sol> (raw)
In-Reply-To: <20230630122825.117902-1-brgl@bgdev.pl>
On Fri, Jun 30, 2023 at 02:28:25PM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> For any given target (let's say foobar), automake defaults to looking for
> foobar.c if foobar_SOURCES are not specified. Remove redundant assignments
> as we've seen multiple hidden typos in makefiles already.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Makes sense to me.
Reviewed-by: Kent Gibson <warthog618@gmail.com>
prev parent reply other threads:[~2023-06-30 12:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-30 12:28 [libgpiod][PATCH] build: remove redundant SOURCES assignments Bartosz Golaszewski
2023-06-30 12:31 ` Kent Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJ7LOWuPIwR/fVyk@sol \
--to=warthog618@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.