From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Dennis Zhou <dennis@kernel.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Linux MMC List <linux-mmc@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Biju Das <biju.das.jz@bp.renesas.com>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH v2] mmc: inline the first mmc_scan() on mmc_start_host()
Date: Fri, 30 Jun 2023 15:34:36 +0200 [thread overview]
Message-ID: <ZJ7Z7HL684hrSkdx@sai> (raw)
In-Reply-To: <CAPDyKFqtgCK5Wb_fZ9+VVK1F-LWYL+htMvQ9JPpp0zPjzBZ9gw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 825 bytes --]
> Note that, even if the offending commit below triggers this problem
> 100% of the cases (as the probe path has now becomes synchronous),
> there was a potential risk even before. Previously, mmc_add_host()
> ended up punting a work - and if that work ended up sending a request
> to the host driver, *before* the irq-handler would be ready, we would
> hit the similar problem. I bet adding an msleep(1000) immediately
> after mmc_add_host() in tmio_mmc_host_probe(), would then trigger this
> problem too. :-)
>
> That said, I am going to revert the offending commit to fix these
> problems, for now. Then I will try to help out and fixup the relevant
> host drivers - and when that is done, we can give this whole thing a
> new try.
I'll work on the TMIO/SDHI driver next week. Thanks for the input!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-06-30 13:36 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-29 20:21 [PATCH] mmc: inline the first mmc_scan() on mmc_start_host() Dennis Zhou
2023-03-29 22:56 ` kernel test robot
2023-03-29 23:36 ` kernel test robot
2023-03-29 23:48 ` [PATCH v2] " Dennis Zhou
2023-03-31 12:43 ` Ulf Hansson
2023-03-31 18:23 ` Dennis Zhou
2023-04-03 9:50 ` Ulf Hansson
2023-04-07 8:24 ` Dennis Zhou
2023-04-11 20:29 ` Dennis Zhou
2023-04-12 11:05 ` Ulf Hansson
2023-05-12 11:42 ` Ulf Hansson
2023-06-08 20:49 ` Dennis Zhou
2023-06-09 6:19 ` Greg KH
2023-06-09 7:16 ` Dennis Zhou
2023-06-09 8:53 ` Greg KH
2023-06-09 8:58 ` Linus Walleij
2023-06-12 14:55 ` Ulf Hansson
2023-06-27 17:20 ` Geert Uytterhoeven
2023-06-27 18:09 ` Biju Das
2023-06-30 11:26 ` Ulf Hansson
2023-06-30 13:34 ` Wolfram Sang [this message]
2023-06-30 22:09 ` Dennis Zhou
2023-06-13 14:25 ` [PATCH] " Ulf Hansson
2023-06-15 16:06 ` Dennis Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJ7Z7HL684hrSkdx@sai \
--to=wsa+renesas@sang-engineering.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=dennis@kernel.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.