All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kent Gibson <warthog618@gmail.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Viresh Kumar <viresh.kumar@linaro.org>,
	Joe Slater <joe.slater@windriver.com>,
	linux-gpio@vger.kernel.org,
	Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [PATCH v2 2/2] tools: tests: port tests to shunit2
Date: Wed, 21 Jun 2023 17:36:06 +0800	[thread overview]
Message-ID: <ZJLEhrhn8KCH4IxW@sol> (raw)
In-Reply-To: <20230621084835.114473-3-brgl@bgdev.pl>

On Wed, Jun 21, 2023 at 10:48:35AM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> 
> +
>  # Save the PID of coprocess - otherwise we won't be able to wait for it
>  # once it exits as the COPROC_PID will be cleared.
>  DUT_PID=""
>  
> -# mappings from local name to system chip name, path, dev name

Minor nit - I would keep the line above - only removing the -g comment.

> -# -g required for the associative arrays, cos BATS...
> -declare -g -A GPIOSIM_CHIP_NAME
> -declare -g -A GPIOSIM_CHIP_PATH

Either way, for the series, 

Reviewed-by: Kent Gibson <warthog618@gmail.com>

Cheers,
Kent.

  reply	other threads:[~2023-06-21  9:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-21  8:48 [PATCH v2 0/2] tools: port tests to shunit2 Bartosz Golaszewski
2023-06-21  8:48 ` [PATCH v2 1/2] tools: tests: add short sleeps between generating edge events Bartosz Golaszewski
2023-06-21  8:48 ` [PATCH v2 2/2] tools: tests: port tests to shunit2 Bartosz Golaszewski
2023-06-21  9:36   ` Kent Gibson [this message]
2023-06-22  7:17     ` Bartosz Golaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZJLEhrhn8KCH4IxW@sol \
    --to=warthog618@gmail.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=bartosz.golaszewski@linaro.org \
    --cc=brgl@bgdev.pl \
    --cc=joe.slater@windriver.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.