From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 14C5BEB64D7 for ; Wed, 21 Jun 2023 14:09:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YGylldoUA4E6SlYGrshf+AQG7W+8dGLCbtO1O7mS0v0=; b=eo+RZyJ74Hi0IK ERKWV9erZCrqxZmzlgbk5O6Pck9hH5/KcFp3cXpHiGJWYvvnAEYWeQUqcBK/Ii592qDxAxRK8RfSt nUgfAU4bcuhcey+pAtOtxwN3jeeUZweRf9NW+UZT1PGPUJ/9Qyyhvz9P6iaft6RqcIAPAOZ5QWEHo 9hzhtlUl5J3YJNXGMmUvcIjcoI8jHRT/nUVuXfPu3hJh+UpUiNWf0dfu8cVkGqjZryAebvCNYfPLX hKV9b0ZVUZO0twYYCvU5jQq7DpdghO5pwdV7L6boKeeJ6gYkRJnml/QP/mdIb41gStjYrY+VNhfR6 XG51IHIIkwyL/J+Q6DUA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qByW8-00Elw0-37; Wed, 21 Jun 2023 14:09:04 +0000 Received: from mga14.intel.com ([192.55.52.115]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qByW6-00Elsj-1k; Wed, 21 Jun 2023 14:09:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687356542; x=1718892542; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=rPx+5YqJGhmcle9gXLDQG0ptIvu0NgL4FLwZd8hjZ50=; b=M0CdMnj/ilspK1gHattcfiyxJmg6F4IiW3Xhjglw25iR8YNhtFs2kZ+0 l666TTWWVX2/bDd30S3xgtLXw3jCTzvNwccEf51jzjZ/TNB8vSXTazQxl 1UP31TqjC4d/Z/4addcz9WNftJdzNAK1r86P5146AGWhjQY2sGVW9jai/ XeI/qqHCPkngh2J44ZfyATnI8bXZyh7Ac5VMuuwfILZpb3dUaV3UomcSW KgCjSEbTlukvKIuLfw2h2pVlgvY+lN/3GnpGqWOxrV5j52BMCLvW1V9o1 RhM9nYI9a8fiHYeVsU0paHsh5T6UFwNb6y9JhqnCNzi8iFd/LdX4pau54 w==; X-IronPort-AV: E=McAfee;i="6600,9927,10748"; a="360196831" X-IronPort-AV: E=Sophos;i="6.00,260,1681196400"; d="scan'208";a="360196831" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jun 2023 07:08:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10748"; a="961207162" X-IronPort-AV: E=Sophos;i="6.00,260,1681196400"; d="scan'208";a="961207162" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga006.fm.intel.com with ESMTP; 21 Jun 2023 07:08:47 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qByVp-005VwL-2X; Wed, 21 Jun 2023 17:08:45 +0300 Date: Wed, 21 Jun 2023 17:08:45 +0300 From: Andy Shevchenko To: George Stark Cc: jic23@kernel.org, lars@metafoo.de, neil.armstrong@linaro.org, khilman@baylibre.com, jbrunet@baylibre.com, martin.blumenstingl@googlemail.com, nuno.sa@analog.com, linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, kernel@sberdevices.ru Subject: Re: [PATCH v1 1/3] meson saradc: code refactoring Message-ID: References: <20230621062715.455652-1-gnstark@sberdevices.ru> <20230621062715.455652-2-gnstark@sberdevices.ru> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230621062715.455652-2-gnstark@sberdevices.ru> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230621_070902_596697_EDA87B01 X-CRM114-Status: UNSURE ( 7.97 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Wed, Jun 21, 2023 at 09:26:08AM +0300, George Stark wrote: > - remove channel array double definition > - add channel index enum > - move enums declaration before variables declaration > - move meson_sar_adc_set_chan7_mux routine upper 4 patches then? ... > + // last item is temp channel Is C++ comment style is used in the entire file? -- With Best Regards, Andy Shevchenko _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70724EB64D8 for ; Wed, 21 Jun 2023 14:09:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232474AbjFUOJM (ORCPT ); Wed, 21 Jun 2023 10:09:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55990 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231348AbjFUOJA (ORCPT ); Wed, 21 Jun 2023 10:09:00 -0400 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B50E21989; Wed, 21 Jun 2023 07:08:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687356539; x=1718892539; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=rPx+5YqJGhmcle9gXLDQG0ptIvu0NgL4FLwZd8hjZ50=; b=VH2Bi6mnG775MSV7eblQ/NauPQTwgriK4z2evZ199plaliH8tbjhx4Ba d5jsZqNvbyH1QGh51uhg0b7T/OwO0vLWNaYjDzQ/RL1b1fU+6yFLqJqHT 8L6+PQALg75sDNz6T71ZjEYj2zi+VGQFU9Ig6CHN4D+ib9G21R0WaCFpJ ogBacIf9vqnscgNZTqXu1ssTdmtGk1ZlhZ/zOO0C7tCd0EVs68lyZ749C v86i19qLEALQIe09peThZDqnvI14hxCYzjAJqYP2KKNyUPoD8EWUQbA+d ZnOsGV0krv103PMGKihzADqOjt4LvsXA/w97P6OB4Ta/vvUPe35zsfJzA g==; X-IronPort-AV: E=McAfee;i="6600,9927,10748"; a="360196828" X-IronPort-AV: E=Sophos;i="6.00,260,1681196400"; d="scan'208";a="360196828" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jun 2023 07:08:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10748"; a="961207162" X-IronPort-AV: E=Sophos;i="6.00,260,1681196400"; d="scan'208";a="961207162" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga006.fm.intel.com with ESMTP; 21 Jun 2023 07:08:47 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qByVp-005VwL-2X; Wed, 21 Jun 2023 17:08:45 +0300 Date: Wed, 21 Jun 2023 17:08:45 +0300 From: Andy Shevchenko To: George Stark Cc: jic23@kernel.org, lars@metafoo.de, neil.armstrong@linaro.org, khilman@baylibre.com, jbrunet@baylibre.com, martin.blumenstingl@googlemail.com, nuno.sa@analog.com, linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, kernel@sberdevices.ru Subject: Re: [PATCH v1 1/3] meson saradc: code refactoring Message-ID: References: <20230621062715.455652-1-gnstark@sberdevices.ru> <20230621062715.455652-2-gnstark@sberdevices.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230621062715.455652-2-gnstark@sberdevices.ru> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Wed, Jun 21, 2023 at 09:26:08AM +0300, George Stark wrote: > - remove channel array double definition > - add channel index enum > - move enums declaration before variables declaration > - move meson_sar_adc_set_chan7_mux routine upper 4 patches then? ... > + // last item is temp channel Is C++ comment style is used in the entire file? -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E7842EB64DC for ; Wed, 21 Jun 2023 14:09:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mGXPql36zJVWPMHzZDhiNA3fIM3eDm9wXFiBzH1Woj4=; b=UrhK/evvsymBvK 4yfz4/I4EvM4HsZOxzZ9VW0WTqpee+Q+F+ph/NN8ohOkJ+KfkvFHazHupB24Z29Un/okYnTACICua 1Oa4C+ZhgaQRlCYTHVNt6gdUgM2vgOmLkYCelGCtN/6/pRYyrWrz0js2NYvIUVp1RNxJpVDUo/QGu DzAnoH+0eUvVdBlau23iuA2ZAzvPetpo/Df/V3Z6aRlxCadMtuO+KP5x1229WbqCT32G06x7ebSer 6xUSUobu/8A/zvk+PfzNzLnZYtMYSLSSrNyxEyQm6kaGfdjEWMpQtAySxP/IqKS9DdRqUGUeFMVUM h+vBy4f+3NvHcSuxKGRA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qByW8-00ElvZ-1C; Wed, 21 Jun 2023 14:09:04 +0000 Received: from mga14.intel.com ([192.55.52.115]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qByW6-00Elsj-1k; Wed, 21 Jun 2023 14:09:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687356542; x=1718892542; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=rPx+5YqJGhmcle9gXLDQG0ptIvu0NgL4FLwZd8hjZ50=; b=M0CdMnj/ilspK1gHattcfiyxJmg6F4IiW3Xhjglw25iR8YNhtFs2kZ+0 l666TTWWVX2/bDd30S3xgtLXw3jCTzvNwccEf51jzjZ/TNB8vSXTazQxl 1UP31TqjC4d/Z/4addcz9WNftJdzNAK1r86P5146AGWhjQY2sGVW9jai/ XeI/qqHCPkngh2J44ZfyATnI8bXZyh7Ac5VMuuwfILZpb3dUaV3UomcSW KgCjSEbTlukvKIuLfw2h2pVlgvY+lN/3GnpGqWOxrV5j52BMCLvW1V9o1 RhM9nYI9a8fiHYeVsU0paHsh5T6UFwNb6y9JhqnCNzi8iFd/LdX4pau54 w==; X-IronPort-AV: E=McAfee;i="6600,9927,10748"; a="360196831" X-IronPort-AV: E=Sophos;i="6.00,260,1681196400"; d="scan'208";a="360196831" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jun 2023 07:08:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10748"; a="961207162" X-IronPort-AV: E=Sophos;i="6.00,260,1681196400"; d="scan'208";a="961207162" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga006.fm.intel.com with ESMTP; 21 Jun 2023 07:08:47 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qByVp-005VwL-2X; Wed, 21 Jun 2023 17:08:45 +0300 Date: Wed, 21 Jun 2023 17:08:45 +0300 From: Andy Shevchenko To: George Stark Cc: jic23@kernel.org, lars@metafoo.de, neil.armstrong@linaro.org, khilman@baylibre.com, jbrunet@baylibre.com, martin.blumenstingl@googlemail.com, nuno.sa@analog.com, linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, kernel@sberdevices.ru Subject: Re: [PATCH v1 1/3] meson saradc: code refactoring Message-ID: References: <20230621062715.455652-1-gnstark@sberdevices.ru> <20230621062715.455652-2-gnstark@sberdevices.ru> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230621062715.455652-2-gnstark@sberdevices.ru> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230621_070902_596697_EDA87B01 X-CRM114-Status: UNSURE ( 7.97 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jun 21, 2023 at 09:26:08AM +0300, George Stark wrote: > - remove channel array double definition > - add channel index enum > - move enums declaration before variables declaration > - move meson_sar_adc_set_chan7_mux routine upper 4 patches then? ... > + // last item is temp channel Is C++ comment style is used in the entire file? -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel