Re: [PATCH] USB: serial: option: add u-blox LARA-R6 01B modem

[Johan Hovold <johan@kernel.org>]

On Wed, Jun 21, 2023 at 02:53:14PM +0200, Davide Tronchin wrote:
> > > The first 4 interfaces of all the 3 configurations (default, RMNET, ECM)
> > > are the same.
> > > Here below you can find debug/usb/devices file of the LARA-R6 01B module
> > > in all the USB configurations.
> 
> > Thanks, can you include this in the commit message for v2 as well?
> 
> Sure.
> 
> > Right, I had USB_DEVICE_INTERFACE_CLASS() in mind for the ECM
> > configuration. That should avoid the need for RSVD().
> 
> If possible, i would use USB_DEVICE_INTERFACE_CLASS() for all the
> R6 01B USB configurations. Something like:
> 
> { USB_DEVICE_INTERFACE_CLASS(UBLOX_VENDOR_ID, 0x1311, 0xff) },
> { USB_DEVICE_INTERFACE_CLASS(UBLOX_VENDOR_ID, 0x1312, 0xff),
>   .driver_info = RSVD(4) },
> { USB_DEVICE_INTERFACE_CLASS(UBLOX_VENDOR_ID, 0x1313, 0xff) },
> 
> Reservation is required for RMNET on port 4, as the RMNET port also 
> has USB interface class 255:
> 
> If#= 1 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=ff Driver=option
> If#= 4 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=ff Driver=qmi_wwan
> 
> What do you think?

That should work, but I don't think you should use more specific
matching than required either. So I'd suggest sticking with USB_DEVICE()
for the other two configurations.

Johan