From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Armin Wolf <W_Armin@gmx.de>
Cc: Hans de Goede <hdegoede@redhat.com>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, Mark Gross <markgross@kernel.org>
Subject: Re: [PATCH v1 1/2] platform/x86: wmi: Break possible infinite loop when parsing GUID
Date: Thu, 22 Jun 2023 11:44:13 +0300 [thread overview]
Message-ID: <ZJQJ3cCaHiwu8rVX@smile.fi.intel.com> (raw)
In-Reply-To: <25715979-8148-8d1d-fd67-a973661f9781@gmx.de>
On Wed, Jun 21, 2023 at 11:20:04PM +0200, Armin Wolf wrote:
> Am 21.06.23 um 17:11 schrieb Andy Shevchenko:
...
> > - if (WARN_ON(guid_parse(id->guid_string, &driver_guid)))
>
> just an idea: how about printing an error/debug message in case of an
> malformed GUID? This could be useful when searching for typos in GUIDs used
> by WMI drivers.
Commented on that separately.
...
> Works on my Dell Inspiron 3505, so for this patch:
> Tested-by: Armin Wolf <W_Armin@gmx.de>
Thank you for testing!
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-06-22 8:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 15:11 [PATCH v1 1/2] platform/x86: wmi: Break possible infinite loop when parsing GUID Andy Shevchenko
2023-06-21 15:11 ` [PATCH v1 2/2] platform/x86: wmi: Replace open coded guid_parse_and_compare() Andy Shevchenko
2023-06-21 21:21 ` Armin Wolf
2023-06-21 21:20 ` [PATCH v1 1/2] platform/x86: wmi: Break possible infinite loop when parsing GUID Armin Wolf
2023-06-21 21:29 ` Barnabás Pőcze
2023-06-21 21:50 ` Armin Wolf
2023-06-22 8:43 ` Andy Shevchenko
2023-06-22 15:00 ` Andy Shevchenko
2023-07-04 11:02 ` Hans de Goede
2023-07-06 10:49 ` Andy Shevchenko
2023-06-22 8:44 ` Andy Shevchenko [this message]
2023-07-11 9:36 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJQJ3cCaHiwu8rVX@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=W_Armin@gmx.de \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.