From: Taylor Blau <me@ttaylorr.com>
To: John Cai via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, John Cai <johncai86@gmail.com>
Subject: Re: [PATCH] docs: add git-hash-object -t option's possible valuesync-mailbox>
Date: Thu, 22 Jun 2023 08:38:28 -0400 [thread overview]
Message-ID: <ZJRAsU6LfSwFIdbw@nand.local> (raw)
In-Reply-To: <pull.1533.git.git.1687394795009.gitgitgadget@gmail.com>
On Thu, Jun 22, 2023 at 12:46:34AM +0000, John Cai via GitGitGadget wrote:
> From: John Cai <johncai86@gmail.com>
>
> For newer users of Git, the possible values of -t in git-hash-object may
> not be apparent. In fact the current verbiage under NAME could
> lead one to conclude that git-hash-object(1) can only be used to create
> blobs.
In the above, these days we would say "git hash-object" instead of
"git-hash-object" (but "git-hash-object(1)" is correct to refer to the
manual page).
Not worth a reroll on its own, of course, but something to keep in mind
for the future.
Otherwise, this patch looks good to me.
Thanks,
Taylor
next prev parent reply other threads:[~2023-06-22 12:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-22 0:46 [PATCH] docs: add git-hash-object -t option's possible values John Cai via GitGitGadget
2023-06-22 0:59 ` brian m. carlson
2023-06-22 23:04 ` Junio C Hamano
2023-06-22 12:38 ` Taylor Blau [this message]
2023-06-22 23:13 ` Junio C Hamano
2023-06-23 18:08 ` John Cai
2023-06-23 21:25 ` [PATCH v2] docs: add git hash-object " John Cai via GitGitGadget
2023-06-23 21:43 ` Junio C Hamano
2023-06-29 2:07 ` [PATCH v3] " John Cai via GitGitGadget
2023-06-29 18:15 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJRAsU6LfSwFIdbw@nand.local \
--to=me@ttaylorr.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=johncai86@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.