Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/4] drm/i915: Add missing forward declarations/includes to display power headers (rev2)

[Imre Deak <imre.deak@intel.com>]

On Thu, Jun 22, 2023 at 05:35:06PM +0000, Patchwork wrote:
> == Series Details ==
> 
> Series: series starting with [1/4] drm/i915: Add missing forward declarations/includes to display power headers (rev2)
> URL   : https://patchwork.freedesktop.org/series/119480/
> State : failure
> 
> == Summary ==
> 
> CI Bug Log - changes from CI_DRM_13309 -> Patchwork_119480v2
> ====================================================
> 
> Summary
> -------
> 
>   **FAILURE**
> 
>   Serious unknown changes coming with Patchwork_119480v2 absolutely need to be
>   verified manually.
>   
>   If you think the reported changes have nothing to do with the changes
>   introduced in Patchwork_119480v2, please notify your bug team to allow them
>   to document this new failure mode, which will reduce false positives in CI.
> 
>   External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v2/index.html
> 
> Participating hosts (43 -> 41)
> ------------------------------
> 
>   Missing    (2): fi-kbl-soraka fi-snb-2520m 
> 
> Possible new issues
> -------------------
> 
>   Here are the unknown changes that may have been introduced in Patchwork_119480v2:
> 
> ### IGT changes ###
> 
> #### Possible regressions ####
> 
>   * igt@i915_pm_rpm@basic-pci-d3-state:
>     - bat-mtlp-8:         [PASS][1] -> [ABORT][2]
>    [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13309/bat-mtlp-8/igt@i915_pm_rpm@basic-pci-d3-state.html
>    [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v2/bat-mtlp-8/igt@i915_pm_rpm@basic-pci-d3-state.html

The test passes, however there is a lockdep problem:
<4>[  396.831915] kworker/20:1H/251 is trying to acquire lock:
<4>[  396.837189] ffffffff82761100 (fs_reclaim){+.+.}-{0:0}, at: __kmem_cache_alloc_node+0x30/0x1b0
<4>[  396.845661]
                  but task is already holding lock:
<4>[  396.851448] ffff8881043c5840 (&gt->reset.backoff_srcu){++++}-{0:0}, at: _intel_gt_reset_lock+0x172/0x330 [i915]

Can't see it related (as the only relevant thing is runtime suspend,
getting delayed by 17ms after this change, which shouldn't make a
difference).

Looks like some GuC vs. memory shrinker lockdep problem, filed already
on other platforms at:
https://gitlab.freedesktop.org/drm/intel/-/issues/8668

> Known issues
> ------------
> 
>   Here are the changes found in Patchwork_119480v2 that come from known issues:
> 
> ### IGT changes ###
> 
> #### Issues hit ####
> 
>   * igt@i915_selftest@live@guc:
>     - bat-rpls-1:         [PASS][3] -> [DMESG-WARN][4] ([i915#7852])
>    [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13309/bat-rpls-1/igt@i915_selftest@live@guc.html
>    [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v2/bat-rpls-1/igt@i915_selftest@live@guc.html
> 
>   * igt@i915_selftest@live@hangcheck:
>     - bat-adlp-9:         [PASS][5] -> [ABORT][6] ([i915#7677] / [i915#7913])
>    [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13309/bat-adlp-9/igt@i915_selftest@live@hangcheck.html
>    [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v2/bat-adlp-9/igt@i915_selftest@live@hangcheck.html
> 
>   * igt@i915_selftest@live@requests:
>     - bat-mtlp-6:         [PASS][7] -> [DMESG-FAIL][8] ([i915#7269])
>    [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13309/bat-mtlp-6/igt@i915_selftest@live@requests.html
>    [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v2/bat-mtlp-6/igt@i915_selftest@live@requests.html
> 
>   * igt@i915_selftest@live@slpc:
>     - bat-rpls-2:         NOTRUN -> [DMESG-WARN][9] ([i915#6367])
>    [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v2/bat-rpls-2/igt@i915_selftest@live@slpc.html
>     - bat-rpls-1:         [PASS][10] -> [DMESG-WARN][11] ([i915#6367])
>    [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13309/bat-rpls-1/igt@i915_selftest@live@slpc.html
>    [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v2/bat-rpls-1/igt@i915_selftest@live@slpc.html
> 
>   * igt@i915_suspend@basic-s2idle-without-i915:
>     - bat-rpls-2:         NOTRUN -> [ABORT][12] ([i915#6687] / [i915#8668])
>    [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v2/bat-rpls-2/igt@i915_suspend@basic-s2idle-without-i915.html
> 
>   * igt@kms_chamelium_hpd@common-hpd-after-suspend:
>     - bat-dg2-11:         NOTRUN -> [SKIP][13] ([i915#7828])
>    [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v2/bat-dg2-11/igt@kms_chamelium_hpd@common-hpd-after-suspend.html
> 
>   
> #### Possible fixes ####
> 
>   * igt@i915_selftest@live@requests:
>     - bat-dg2-11:         [ABORT][14] ([i915#7913]) -> [PASS][15]
>    [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13309/bat-dg2-11/igt@i915_selftest@live@requests.html
>    [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v2/bat-dg2-11/igt@i915_selftest@live@requests.html
> 
>   * igt@i915_selftest@live@reset:
>     - bat-rpls-2:         [ABORT][16] ([i915#4983] / [i915#7461] / [i915#7913] / [i915#8347]) -> [PASS][17]
>    [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13309/bat-rpls-2/igt@i915_selftest@live@reset.html
>    [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v2/bat-rpls-2/igt@i915_selftest@live@reset.html
> 
>   
> #### Warnings ####
> 
>   * igt@kms_psr@primary_mmap_gtt:
>     - bat-rplp-1:         [SKIP][18] ([i915#1072]) -> [ABORT][19] ([i915#8442])
>    [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13309/bat-rplp-1/igt@kms_psr@primary_mmap_gtt.html
>    [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v2/bat-rplp-1/igt@kms_psr@primary_mmap_gtt.html
> 
>   
>   [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
>   [i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
>   [i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
>   [i915#6687]: https://gitlab.freedesktop.org/drm/intel/issues/6687
>   [i915#7269]: https://gitlab.freedesktop.org/drm/intel/issues/7269
>   [i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461
>   [i915#7677]: https://gitlab.freedesktop.org/drm/intel/issues/7677
>   [i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
>   [i915#7852]: https://gitlab.freedesktop.org/drm/intel/issues/7852
>   [i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
>   [i915#8347]: https://gitlab.freedesktop.org/drm/intel/issues/8347
>   [i915#8442]: https://gitlab.freedesktop.org/drm/intel/issues/8442
>   [i915#8668]: https://gitlab.freedesktop.org/drm/intel/issues/8668
> 
> 
> Build changes
> -------------
> 
>   * Linux: CI_DRM_13309 -> Patchwork_119480v2
> 
>   CI-20190529: 20190529
>   CI_DRM_13309: af67b02abf56a5018cd885c94d7611241052e98f @ git://anongit.freedesktop.org/gfx-ci/linux
>   IGT_7346: 29302a0d57bcf10cb553f5d7ff5bb99166a19bba @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
>   Patchwork_119480v2: af67b02abf56a5018cd885c94d7611241052e98f @ git://anongit.freedesktop.org/gfx-ci/linux
> 
> 
> ### Linux commits
> 
> 00c643450930 drm/i915: Prevent needless toggling of DC states during modesets
> 18d2155db09b drm/i915: Add way to specify the power-off delay of a display power domain
> d7dab5293389 drm/i915: Remove redundant forward declarations from display power headers
> 1088d3e9cdc5 drm/i915: Add missing forward declarations/includes to display power headers
> 
> == Logs ==
> 
> For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v2/index.html