From: Simon Horman <simon.horman@corigine.com>
To: Ben Dooks <ben.dooks@codethink.co.uk>
Cc: netdev@vger.kernel.org, pabeni@redhat.com, kuba@kernel.org,
edumazet@google.com, davem@davemloft.net,
linux-kernel@vger.kernel.org, claudiu.beznea@microchip.com,
nicolas.ferre@microchip.com
Subject: Re: [PATCH 3/3] net: macb: fix __be32 warnings in debug code
Date: Fri, 23 Jun 2023 13:01:22 +0200 [thread overview]
Message-ID: <ZJV7go8/2CMkSDl6@corigine.com> (raw)
In-Reply-To: <fbdc3741b28a0174e3058a998e253439@codethink.co.uk>
On Fri, Jun 23, 2023 at 10:43:12AM +0100, Ben Dooks wrote:
>
>
> On 2023-06-22 16:44, Simon Horman wrote:
> > On Thu, Jun 22, 2023 at 02:05:07PM +0100, Ben Dooks wrote:
...
> > Hi Ben,
> >
> > this code-change looks good to me, but I have a few minor nits for your
> > consideration.
> >
> > 1. Please specify the target tree, in this case net-next, for patch sets
> > for Networking code.
> >
> > Subject: [PATCH net-next ...] ...
>
> Ah, was using net, but I assume net-next is probably ok
I think net-next is best for this kind of change.
FWIIW, this series did apply there.
> > 2. It might be nicer to write '.../macb_main.c' or similar,
> > rather tha nthe full path, in the patch description.
> >
> > 3. checkpatch --codespell says: 'Chaning' -> 'Chaining'
>
> Ok, thank you. I didn't know about that.
It is quite handy :)
> Since there's another patch that needs work I'll re-send this early next
> week
> with the fixes in.
I think a repost of the series is a good plan.
Please note that when v6.4 is released, which may well be over the weekend,
then net-next will be closed until after rc1 is released - approximately
two weeks. If it is closed then you'll need to wait until it reopens
before posting v2.
next prev parent reply other threads:[~2023-06-23 11:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-22 13:05 net: macb: sparse warning fixes Ben Dooks
2023-06-22 13:05 ` [PATCH 1/3] net: macb: check constant to define and fix __be32 warnings Ben Dooks
2023-06-22 15:49 ` Simon Horman
2023-06-23 9:40 ` Ben Dooks
2023-06-23 11:02 ` Simon Horman
2023-06-22 13:05 ` [PATCH 2/3] net: macb: add port constant to fix __be16 warnings Ben Dooks
2023-06-22 13:05 ` [PATCH 3/3] net: macb: fix __be32 warnings in debug code Ben Dooks
2023-06-22 15:44 ` Simon Horman
2023-06-23 9:43 ` Ben Dooks
2023-06-23 11:01 ` Simon Horman [this message]
2023-06-23 13:16 ` net: macb: sparse warning fixes Nicolas Ferre
2023-06-23 15:38 ` Andrew Lunn
2023-06-23 15:42 ` Nicolas Ferre
2023-07-03 8:10 ` Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJV7go8/2CMkSDl6@corigine.com \
--to=simon.horman@corigine.com \
--cc=ben.dooks@codethink.co.uk \
--cc=claudiu.beznea@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.