From: Simon Horman <simon.horman@corigine.com>
To: Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
edumazet@google.com, netdev@vger.kernel.org,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Michal Swiatkowski <michal.swiatkowski@linux.intel.com>,
Rafal Romanowski <rafal.romanowski@intel.com>,
Piotr Gardocki <piotrx.gardocki@intel.com>,
Maciej Fijalkowski <maciej.fijalkowski@intel.com>
Subject: Re: [PATCH net-next 1/3] iavf: fix err handling for MAC replace
Date: Fri, 23 Jun 2023 09:41:16 +0200 [thread overview]
Message-ID: <ZJVMnAVwKx2b/13s@corigine.com> (raw)
In-Reply-To: <20230622165914.2203081-2-anthony.l.nguyen@intel.com>
On Thu, Jun 22, 2023 at 09:59:12AM -0700, Tony Nguyen wrote:
> From: Przemek Kitszel <przemyslaw.kitszel@intel.com>
>
> Defer removal of current primary MAC until a replacement is successfully
> added. Previous implementation would left filter list with no primary MAC.
> This was found while reading the code.
>
> The patch takes advantage of the fact that there can only be a single primary
> MAC filter at any time ([1] by Piotr)
>
> Piotr has also applied some review suggestions during our internal patch
> submittal process.
>
> [1] https://lore.kernel.org/netdev/20230614145302.902301-2-piotrx.gardocki@intel.com/
>
> Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
> Tested-by: Rafal Romanowski <rafal.romanowski@intel.com>
> Signed-off-by: Piotr Gardocki <piotrx.gardocki@intel.com>
> Signed-off-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
> Reviewed-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
> Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
next prev parent reply other threads:[~2023-06-23 7:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-22 16:59 [PATCH net-next 0/3][pull request] Intel Wired LAN Driver Updates 2023-06-22 (iavf) Tony Nguyen
2023-06-22 16:59 ` [PATCH net-next 1/3] iavf: fix err handling for MAC replace Tony Nguyen
2023-06-23 7:41 ` Simon Horman [this message]
2023-06-22 16:59 ` [PATCH net-next 2/3] iavf: remove some unused functions and pointless wrappers Tony Nguyen
2023-06-23 7:41 ` Simon Horman
2023-06-22 16:59 ` [PATCH net-next 3/3] iavf: make functions static where possible Tony Nguyen
2023-06-23 7:42 ` Simon Horman
2023-06-24 22:20 ` [PATCH net-next 0/3][pull request] Intel Wired LAN Driver Updates 2023-06-22 (iavf) patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJVMnAVwKx2b/13s@corigine.com \
--to=simon.horman@corigine.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=michal.swiatkowski@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=piotrx.gardocki@intel.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=rafal.romanowski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.