From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7FD78EB64DD for ; Fri, 23 Jun 2023 07:48:09 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 139D240004; Fri, 23 Jun 2023 07:48:09 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 139D240004 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1687506489; bh=+bT1+cD5N1yBUvLweFcaJTeEfCzGnfFq25NnX3zgZ6w=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=04LZsibIibRnxy1v4x2LOTHW5DDEbi1sVptKkh3TzZAf4s9am1ozuc5TqynnD/59k s5H3HonBSD9m6za6n8lqLUP/xZ0bubp4wSzfjne+zTg3jM3syfR9uem/TYfRwm7MRV ledUJzJbF42xgB7C+KtNzMb7Wnmwli4t21on0/7kMNtZpC2GItDsAm0VrmJJzBbh1Y wHWU7SB3badVJS2fhidEDaE6ZKJJlVdT5IAnPoQ7m3D9VPR+BN892/DmwcFeCvj3/p 4e6y/OOEj+sOkkANWG6f3zWvjQuSt9E3l+vjkUMHE7TYFCZJIBd7MiJVV22rwFSiJe HerFTKVKcmDRQ== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PAS7dkcdVwHR; Fri, 23 Jun 2023 07:48:08 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp2.osuosl.org (Postfix) with ESMTP id 1BD6C4011D; Fri, 23 Jun 2023 07:48:08 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 1BD6C4011D Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 5B1481BF4DD for ; Fri, 23 Jun 2023 07:48:07 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 2AA4F40362 for ; Fri, 23 Jun 2023 07:48:07 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 2AA4F40362 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ERaXCye4tgAv for ; Fri, 23 Jun 2023 07:48:05 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 67718400AE Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [IPv6:2a00:1450:4864:20::22c]) by smtp4.osuosl.org (Postfix) with ESMTPS id 67718400AE for ; Fri, 23 Jun 2023 07:48:04 +0000 (UTC) Received: by mail-lj1-x22c.google.com with SMTP id 38308e7fff4ca-2b477e9d396so5459821fa.3 for ; Fri, 23 Jun 2023 00:48:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687506482; x=1690098482; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=afzpoupdHBz4t80yeY68UW7BcSr6J0mUzcvK1xv8c1M=; b=D7pt+I5sr1kim6jdtpgk+FVF21xqU0BWgD1MwGmrhpvY8avzi9VGlACKk/+aJhQgj8 3kMcRapzRMWsJtzWWSwD3pE8q3BRJ5xGIoaO8r8AihyXk5vq1VELt0ovITpt8BHH8DWk b68y/wf5qIjSI21Fbq2lPfC9TYSdCBz+iygnTtOoNSdrRvVL334qLNzF8JgFILgNQLCQ RDbr+Oxf8dwN6+uaAEihkzc5uhTs57s3F54pBN6Bc+TN6wa0oio4gZzK7I427RloWNeQ TYcS56hWcqs+TKDwfn0XRvio+a2YuMxyqkxiDs1q5cjSyVAoPTdjZ2gUUeqFTxBKKP7K 8MrA== X-Gm-Message-State: AC+VfDz0p3CftBhlSx/sYP873caKr7Pc4FfBOnCpk+7czEGqOTjOUxH2 +ibWD9rBGteF/ViVYnYFVJXw3w== X-Google-Smtp-Source: ACHHUZ60rNJlS88ekBpJsTiP/YnYc408Z0GlUIj/k7KV/RQOAUp7f7ExOF4ZyFZ2IcPQ5FADHxaxYg== X-Received: by 2002:a2e:9944:0:b0:2b4:6a20:f12b with SMTP id r4-20020a2e9944000000b002b46a20f12bmr13920987ljj.22.1687506482431; Fri, 23 Jun 2023 00:48:02 -0700 (PDT) Received: from localhost (host-213-179-129-39.customer.m-online.net. [213.179.129.39]) by smtp.gmail.com with ESMTPSA id b18-20020aa7cd12000000b0051bf49e258bsm666413edw.22.2023.06.23.00.48.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Jun 2023 00:48:01 -0700 (PDT) Date: Fri, 23 Jun 2023 09:48:00 +0200 From: Jiri Pirko To: "Kubalewski, Arkadiusz" Message-ID: References: <20230609121853.3607724-1-arkadiusz.kubalewski@intel.com> <20230609121853.3607724-5-arkadiusz.kubalewski@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20221208.gappssmtp.com; s=20221208; t=1687506482; x=1690098482; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=afzpoupdHBz4t80yeY68UW7BcSr6J0mUzcvK1xv8c1M=; b=y839S9kxd09ThLEfxmxC6oII3nMiQTOEHF9PojI9kiub9AcAU9VwNCWsdUi79zoGrL I53edaB4DcMZQQ0qflpJAUkvrrMC34ACSDUt0ujxI5pBdzcViBCk6n9FKsQqZhEr33/O VvEBWTcxrI6FtHpJuHeokazRCXKF4vksYk5o+OAae6lurukOLI6tXHVLSfb+Q+V7FEV/ sf8imt+RlLt6Lat5yCvrtngprbPt26rUBnApAtbvCEbqlIgaWoDJC9mFHQOn0JbF41dG AZbWjTZ98aLp9MgUn+gURDvYq4bO/7X5+p/tQDFnf5y1CNMOL2mMEGQ/vOQjVcpXlF7u UTbQ== X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key) header.d=resnulli-us.20221208.gappssmtp.com header.i=@resnulli-us.20221208.gappssmtp.com header.a=rsa-sha256 header.s=20221208 header.b=y839S9kx Subject: Re: [Intel-wired-lan] [RFC PATCH v8 04/10] dpll: netlink: Add DPLL framework base functions X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "geert+renesas@glider.be" , "mst@redhat.com" , "razor@blackwall.org" , "phil@nwl.cc" , "javierm@redhat.com" , "edumazet@google.com" , "benjamin.tissoires@redhat.com" , "Nguyen, Anthony L" , "netdev@vger.kernel.org" , "linux-clk@vger.kernel.org" , "lucien.xin@gmail.com" , "leon@kernel.org" , "corbet@lwn.net" , "linux-rdma@vger.kernel.org" , "masahiroy@kernel.org" , "linux-doc@vger.kernel.org" , "Brandeburg, Jesse" , "vadfed@meta.com" , "intel-wired-lan@lists.osuosl.org" , "kuba@kernel.org" , "vadfed@fb.com" , "pabeni@redhat.com" , "ricardo.canuelo@collabora.com" , "arnd@arndb.de" , "idosch@nvidia.com" , "richardcochran@gmail.com" , "claudiajkang@gmail.com" , "kuniyu@amazon.com" , "jacek.lawrynowicz@linux.intel.com" , "liuhangbin@gmail.com" , "airlied@redhat.com" , "nicolas.dichtel@6wind.com" , "linux-arm-kernel@lists.infradead.org" , "axboe@kernel.dk" , "sj@kernel.org" , "vadim.fedorenko@linux.dev" , "linux@zary.sk" , "gregkh@linuxfoundation.org" , "ogabbay@kernel.org" , "nipun.gupta@amd.com" , "linux-kernel@vger.kernel.org" , "andy.ren@getcruise.com" , "tzimmermann@suse.de" , "jonathan.lemon@gmail.com" , "M, Saeed" , "davem@davemloft.net" , "Olech, Milena" , "hkallweit1@gmail.com" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" RnJpLCBKdW4gMjMsIDIwMjMgYXQgMDI6NTY6MjRBTSBDRVNULCBhcmthZGl1c3oua3ViYWxld3Nr aUBpbnRlbC5jb20gd3JvdGU6Cj4+RnJvbTogSmlyaSBQaXJrbyA8amlyaUByZXNudWxsaS51cz4K Pj5TZW50OiBXZWRuZXNkYXksIEp1bmUgMjEsIDIwMjMgMzowOCBQTQo+Pgo+PldlZCwgSnVuIDIx LCAyMDIzIGF0IDAxOjUzOjI0UE0gQ0VTVCwgamlyaUByZXNudWxsaS51cyB3cm90ZToKPj4+V2Vk LCBKdW4gMjEsIDIwMjMgYXQgMDE6MTg6NTlQTSBDRVNULCBwb3Jvc0ByZWRoYXQuY29tIHdyb3Rl Ogo+Pj4+QXJrYWRpdXN6IEt1YmFsZXdza2kgcMOtxaFlIHYgUMOhIDA5LiAwNi4gMjAyMyB2IDE0 OjE4ICswMjAwOgo+Pj4+PiBGcm9tOiBWYWRpbSBGZWRvcmVua28gPHZhZGltLmZlZG9yZW5rb0Bs aW51eC5kZXY+Cj4+Pgo+Pj5bLi4uXQo+Pj4KPj4+Q291bGQgeW91IHBlcmhhcHMgY3V0IG91dCB0 aGUgdGV4dCB5b3UgZG9uJ3QgY29tbWVudD8gU2F2ZXMgc29tZSB0aW1lCj4+PmZpbmRpbmcgeW91 ciByZXBseS4KPj4+Cj4+Pgo+Pj4+PiArc3RhdGljIGludAo+Pj4+PiArZHBsbF9zZXRfZnJvbV9u bGF0dHIoc3RydWN0IGRwbGxfZGV2aWNlICpkcGxsLCBzdHJ1Y3QgZ2VubF9pbmZvCj4+Pj4+ICpp bmZvKQo+Pj4+PiArewo+Pj4+PiArwqDCoMKgwqDCoMKgwqBjb25zdCBzdHJ1Y3QgZHBsbF9kZXZp Y2Vfb3BzICpvcHMgPSBkcGxsX2RldmljZV9vcHMoZHBsbCk7Cj4+Pj4+ICvCoMKgwqDCoMKgwqDC oHN0cnVjdCBubGF0dHIgKnRiW0RQTExfQV9NQVggKyAxXTsKPj4+Pj4gK8KgwqDCoMKgwqDCoMKg aW50IHJldCA9IDA7Cj4+Pj4+ICsKPj4+Pj4gK8KgwqDCoMKgwqDCoMKgbmxhX3BhcnNlKHRiLCBE UExMX0FfTUFYLCBnZW5sbXNnX2RhdGEoaW5mby0+Z2VubGhkciksCj4+Pj4+ICvCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBnZW5sbXNnX2xlbihpbmZvLT5nZW5saGRyKSwgTlVMTCwg aW5mby0+ZXh0YWNrKTsKPj4+Pj4gK8KgwqDCoMKgwqDCoMKgaWYgKHRiW0RQTExfQV9NT0RFXSkg ewo+Pj4+SGksCj4+Pj4KPj4+PkhlcmUgc2hvdWxkIGJlIHNvbWV0aGluZyBsaWtlOgo+Pj4+ICAg ICAgICAgICAgICAgaWYgKCFvcHMtPm1vZGVfc2V0KQo+Pj4+ICAgICAgICAgICAgICAgICAgICAg ICByZXR1cm4gLUVPUE5PVFNVUFA7Cj4+Pgo+Pj5XaHk/IEFsbCBkcml2ZXJzIGltcGxlbWVudCB0 aGF0Lgo+Pj5JIGJlbGlldmUgdGhhdCBpdCdzIGFjdHVsbGFseSBiZXR0ZXIgdGhhdCB3YXkuIEZv ciBhIGNhbGxlZCBzZXR0aW5nIHVwCj4+PnRoZSBzYW1lIG1vZGUgaXQgaXMgdGhlIGRwbGwgaW4s IHRoZXJlIHNob3VsZCBiZSAwIHJldHVybiBieSB0aGUgZHJpdmVyLgo+Pj5Ob3RlIHRoYXQgZHJp dmVyIGhvbGRzIHRoaXMgdmFsdWUuIEknZCBsaWtlIHRvIGtlZXAgdGhpcyBjb2RlIGFzIGl0IGlz Lgo+Pgo+PkFjdHVhbGx5LCB5b3UgYXJlIGNvcnJlY3QgUGV0ciwgbXkgbWlzdGFrZS4gQWN0dWFs bHksIG5vIGRyaXZlcgo+PmltcGxlbWVudHMgdGhpcy4gQXJrYWRpdXN6LCBjb3VsZCB5b3UgcGxl YXNlIHJlbW92ZSB0aGlzIG9wIGFuZAo+PnBvc3NpYmx5IGFueSBvdGhlciB1bnVzZWQgIG9wPyBJ dCB3aWxsIGJlIGFkZGVkIHdoZW4gbmVlZGVkLgo+Pgo+PlRoYW5rcyEKPj4KPgo+U29ycnksIGRp ZG4ndCBoYXZlIHRpbWUgZm9yIHN1Y2ggY2hhbmdlLCBhZGRlZCBvbmx5IGNoZWNrIGFzIHN1Z2dl c3RlZCBieQo+UGV0ci4KPklmIHlvdSB0aGluayB0aGlzIGlzIGEgYmlnIGlzc3VlLCB3ZSBjb3Vs ZCBjaGFuZ2UgaXQgZm9yIG5leHQgdmVyc2lvbi4KCkl0J3Mgb2RkIHRvIGNhcnJ5IG9uIG9wcyB3 aGljaCBhcmUgdW51c2VkLiBJIHdvdWxkIHByZWZlciB0aGF0IHRvIGJlCnJlbW92ZWQgbm93IGFu ZCBvbmx5IGludHJvZHVjZWQgd2hlbiB0aGV5IGFyZSBhY3R1YWxseSBuZWVkZWQuCgoKPgo+VGhh bmsgeW91IQo+QXJrYWRpdXN6Cj4KPj4KPj4+Cj4+PlsuLi5dCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLXdpcmVkLWxhbiBtYWlsaW5nIGxpc3QK SW50ZWwtd2lyZWQtbGFuQG9zdW9zbC5vcmcKaHR0cHM6Ly9saXN0cy5vc3Vvc2wub3JnL21haWxt YW4vbGlzdGluZm8vaW50ZWwtd2lyZWQtbGFuCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DBDDEB64D7 for ; Fri, 23 Jun 2023 07:48:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230170AbjFWHsH (ORCPT ); Fri, 23 Jun 2023 03:48:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42514 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231383AbjFWHsG (ORCPT ); Fri, 23 Jun 2023 03:48:06 -0400 Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [IPv6:2a00:1450:4864:20::235]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C4791724 for ; Fri, 23 Jun 2023 00:48:04 -0700 (PDT) Received: by mail-lj1-x235.google.com with SMTP id 38308e7fff4ca-2b466073e19so5597661fa.1 for ; Fri, 23 Jun 2023 00:48:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20221208.gappssmtp.com; s=20221208; t=1687506482; x=1690098482; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=afzpoupdHBz4t80yeY68UW7BcSr6J0mUzcvK1xv8c1M=; b=y839S9kxd09ThLEfxmxC6oII3nMiQTOEHF9PojI9kiub9AcAU9VwNCWsdUi79zoGrL I53edaB4DcMZQQ0qflpJAUkvrrMC34ACSDUt0ujxI5pBdzcViBCk6n9FKsQqZhEr33/O VvEBWTcxrI6FtHpJuHeokazRCXKF4vksYk5o+OAae6lurukOLI6tXHVLSfb+Q+V7FEV/ sf8imt+RlLt6Lat5yCvrtngprbPt26rUBnApAtbvCEbqlIgaWoDJC9mFHQOn0JbF41dG AZbWjTZ98aLp9MgUn+gURDvYq4bO/7X5+p/tQDFnf5y1CNMOL2mMEGQ/vOQjVcpXlF7u UTbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687506482; x=1690098482; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=afzpoupdHBz4t80yeY68UW7BcSr6J0mUzcvK1xv8c1M=; b=Qh1KJffNvfrKz6lNya1CWAlCp/lDJkJ9vuykHG0TUvn7LFrogv+JYEdvcdOHs8Rb/x UrVH0WiHAbqVD6U+OnrvLV87bWnVX5pGK2lD69xQGmg0TSN5RoOeeYqqD5mvE8vJVrqD WQWiyypL4SHS9xIZXPM+gh93XXiwc2Lm4IEhLBJ4alE0u5rTaCettlpN78gyg/pM/3fn g4jN+NPo9t1xz0rzi4ZlqCtoWNVFKicvybuPAOGaFC5JS3nuusQ9P8jy6nwCEInkwq8P WMLScW4WOdjB/LxlrwVrzGBuXIh5ziJ63ayk8LiBum8M/k6f9fotiQK3rs+BsEMxlUgh XKZg== X-Gm-Message-State: AC+VfDzwHvUaZmF0LCweZfABDhCxi7Zr0YG8iRzhQUqa5exVkAbmeN9p kbewHCzPx9QDp4scJLfdZxsnwA== X-Google-Smtp-Source: ACHHUZ60rNJlS88ekBpJsTiP/YnYc408Z0GlUIj/k7KV/RQOAUp7f7ExOF4ZyFZ2IcPQ5FADHxaxYg== X-Received: by 2002:a2e:9944:0:b0:2b4:6a20:f12b with SMTP id r4-20020a2e9944000000b002b46a20f12bmr13920987ljj.22.1687506482431; Fri, 23 Jun 2023 00:48:02 -0700 (PDT) Received: from localhost (host-213-179-129-39.customer.m-online.net. [213.179.129.39]) by smtp.gmail.com with ESMTPSA id b18-20020aa7cd12000000b0051bf49e258bsm666413edw.22.2023.06.23.00.48.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Jun 2023 00:48:01 -0700 (PDT) Date: Fri, 23 Jun 2023 09:48:00 +0200 From: Jiri Pirko To: "Kubalewski, Arkadiusz" Cc: poros , "kuba@kernel.org" , "vadfed@meta.com" , "jonathan.lemon@gmail.com" , "pabeni@redhat.com" , "corbet@lwn.net" , "davem@davemloft.net" , "edumazet@google.com" , "vadfed@fb.com" , "Brandeburg, Jesse" , "Nguyen, Anthony L" , "M, Saeed" , "leon@kernel.org" , "richardcochran@gmail.com" , "sj@kernel.org" , "javierm@redhat.com" , "ricardo.canuelo@collabora.com" , "mst@redhat.com" , "tzimmermann@suse.de" , "Michalik, Michal" , "gregkh@linuxfoundation.org" , "jacek.lawrynowicz@linux.intel.com" , "airlied@redhat.com" , "ogabbay@kernel.org" , "arnd@arndb.de" , "nipun.gupta@amd.com" , "axboe@kernel.dk" , "linux@zary.sk" , "masahiroy@kernel.org" , "benjamin.tissoires@redhat.com" , "geert+renesas@glider.be" , "Olech, Milena" , "kuniyu@amazon.com" , "liuhangbin@gmail.com" , "hkallweit1@gmail.com" , "andy.ren@getcruise.com" , "razor@blackwall.org" , "idosch@nvidia.com" , "lucien.xin@gmail.com" , "nicolas.dichtel@6wind.com" , "phil@nwl.cc" , "claudiajkang@gmail.com" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" , "intel-wired-lan@lists.osuosl.org" , "linux-rdma@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , mschmidt , "linux-clk@vger.kernel.org" , "vadim.fedorenko@linux.dev" Subject: Re: [RFC PATCH v8 04/10] dpll: netlink: Add DPLL framework base functions Message-ID: References: <20230609121853.3607724-1-arkadiusz.kubalewski@intel.com> <20230609121853.3607724-5-arkadiusz.kubalewski@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Fri, Jun 23, 2023 at 02:56:24AM CEST, arkadiusz.kubalewski@intel.com wrote: >>From: Jiri Pirko >>Sent: Wednesday, June 21, 2023 3:08 PM >> >>Wed, Jun 21, 2023 at 01:53:24PM CEST, jiri@resnulli.us wrote: >>>Wed, Jun 21, 2023 at 01:18:59PM CEST, poros@redhat.com wrote: >>>>Arkadiusz Kubalewski píše v Pá 09. 06. 2023 v 14:18 +0200: >>>>> From: Vadim Fedorenko >>> >>>[...] >>> >>>Could you perhaps cut out the text you don't comment? Saves some time >>>finding your reply. >>> >>> >>>>> +static int >>>>> +dpll_set_from_nlattr(struct dpll_device *dpll, struct genl_info >>>>> *info) >>>>> +{ >>>>> +       const struct dpll_device_ops *ops = dpll_device_ops(dpll); >>>>> +       struct nlattr *tb[DPLL_A_MAX + 1]; >>>>> +       int ret = 0; >>>>> + >>>>> +       nla_parse(tb, DPLL_A_MAX, genlmsg_data(info->genlhdr), >>>>> +                 genlmsg_len(info->genlhdr), NULL, info->extack); >>>>> +       if (tb[DPLL_A_MODE]) { >>>>Hi, >>>> >>>>Here should be something like: >>>> if (!ops->mode_set) >>>> return -EOPNOTSUPP; >>> >>>Why? All drivers implement that. >>>I believe that it's actullaly better that way. For a called setting up >>>the same mode it is the dpll in, there should be 0 return by the driver. >>>Note that driver holds this value. I'd like to keep this code as it is. >> >>Actually, you are correct Petr, my mistake. Actually, no driver >>implements this. Arkadiusz, could you please remove this op and >>possibly any other unused op? It will be added when needed. >> >>Thanks! >> > >Sorry, didn't have time for such change, added only check as suggested by >Petr. >If you think this is a big issue, we could change it for next version. It's odd to carry on ops which are unused. I would prefer that to be removed now and only introduced when they are actually needed. > >Thank you! >Arkadiusz > >> >>> >>>[...]