From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3219EEB64D7 for ; Fri, 23 Jun 2023 14:11:46 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C69A2861C5; Fri, 23 Jun 2023 16:11:43 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="O7SeZZpk"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id ABC38861CA; Fri, 23 Jun 2023 16:11:41 +0200 (CEST) Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 6D10184724 for ; Fri, 23 Jun 2023 16:11:38 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=thierry.reding@gmail.com Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-3f90b8acefdso7869175e9.1 for ; Fri, 23 Jun 2023 07:11:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687529498; x=1690121498; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=W+BHaRwZh6CDt+CVPz203Hr5EfhYumR1Y10T28DD6cY=; b=O7SeZZpkNPDi9sOfFS8cAb8M5T5ldLFZRlrIQ81mvCy0ueiyQKXT599IjhfnI/Mvu7 Jdlzrh2HM1PY183SyVf19FHmve/9ae9D8nfZY5EaOCNy1SjQVJXsmVmhId8H5zg88M0Q UK0fLx5Q1K/WvQ4vrUc0C2I7usPqe/f+NQvhYm/VfSWG7BTnOsfi1mBexGow9huuZR/N +55A6kodc8A8H2g063pEVhlE3rVeeN1/+3VQ4jkrobPq/W4oNeK4npK2hhpNx/yVzo4Q NsU4niAjyDDfdtfWrbk3/1sqxIt4TBMJZjdHYAjQnWhxGwId4CJCHc1tvCROMKx/8ynE MQmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687529498; x=1690121498; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=W+BHaRwZh6CDt+CVPz203Hr5EfhYumR1Y10T28DD6cY=; b=WtX8Refw4DO5aKrxCREAO3UFIP9XVuPUVcikGG9El8Pu901tjN6YTrfFZCoYF/7nH5 sCU61HNkLYG6U43HxXbk/PoiSciO+zK4TLqFkHurb17b29gHS2UsSOhZOkN5HD3RhWC4 JOSj/P1SfHZalA0v3uyDVHiWn/SpwFfZ9/0+TnpMW5NnQYYpwRLjuHNgluMXMcvxn/OB sn0wLuaCV5ydJQnlITtUQeZhCNxDJbOg0owAgRnT+3lounJdkITIZ6HuMAOxXllaPaSb 9OkM4IjoOwYHiqpBfQilK/qTmhMeKeBkUuanbEl9zeigdDRxax893/7UEHwoPcoI1Gwt mFiQ== X-Gm-Message-State: AC+VfDx91GTUTuMdMhb1pFC0mqScwp5b73bkLz1kuh06rkMs72sj/WKu 8BchEqc+YqIpfQWbURfbwYQ= X-Google-Smtp-Source: ACHHUZ4P5pTV25VPT8pm8/13PsyPFvxJN+aEdroAFVmDl+U1kKl7BF2DITY8M4YuZtJrnp7rqwXgqg== X-Received: by 2002:a05:600c:3786:b0:3f9:c0a9:3e22 with SMTP id o6-20020a05600c378600b003f9c0a93e22mr6051175wmr.12.1687529497660; Fri, 23 Jun 2023 07:11:37 -0700 (PDT) Received: from orome (p200300e41f305300f22f74fffe1f3a53.dip0.t-ipconnect.de. [2003:e4:1f30:5300:f22f:74ff:fe1f:3a53]) by smtp.gmail.com with ESMTPSA id m24-20020a7bcb98000000b003f8f884ebe5sm2519858wmi.2.2023.06.23.07.11.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Jun 2023 07:11:37 -0700 (PDT) Date: Fri, 23 Jun 2023 16:11:35 +0200 From: Thierry Reding To: Svyatoslav Ryhel Cc: Thierry Reding , Tom Warren , Tom Rini , Simon Glass , Jonas =?utf-8?B?U2Nod8O2YmVs?= , u-boot@lists.denx.de Subject: Re: [PATCH v7 4/7] board: asus: transformer: add ASUS Transformer T30 family support Message-ID: References: <20230623055600.246416-1-clamor95@gmail.com> <20230623055600.246416-5-clamor95@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Fzg2ZUeg+Kc8ozp+" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.2.10 (2023-03-25) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean --Fzg2ZUeg+Kc8ozp+ Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jun 23, 2023 at 02:51:54PM +0300, Svyatoslav Ryhel wrote: >=20 >=20 > 23 =D1=87=D0=B5=D1=80=D0=B2=D0=BD=D1=8F 2023 =D1=80. 14:32:30 GMT+03:00, = Thierry Reding =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0= =B0=D0=B2(-=D0=BB=D0=B0): > >On Fri, Jun 23, 2023 at 08:55:57AM +0300, Svyatoslav Ryhel wrote: > >[...] > >> diff --git a/board/asus/transformer-t30/pinmux-config-transformer.h b/= board/asus/transformer-t30/pinmux-config-transformer.h > >> new file mode 100644 > >> index 0000000000..96ff45d375 > >> --- /dev/null > >> +++ b/board/asus/transformer-t30/pinmux-config-transformer.h > >> @@ -0,0 +1,365 @@ > >> +/* SPDX-License-Identifier: GPL-2.0 */ > >> +/* > >> + * Copyright (c) 2010-2013, NVIDIA CORPORATION. All rights reserved. > >> + * > >> + * Copyright (c) 2021, Svyatoslav Ryhel. > >> + */ > > > >I don't recall if we discussed this during upstreaming of the Linux > >device tree files, but shortly after the initial support for Tegra20 and > >Tegra30 was upstreamed (both in U-Boot and in Linux) we decided to move > >towards generating the pinmux configuration for the various consumers > >(i.e. U-Boot and Linux) from data tables using a set of scripts. This > >was done because we noticed that various inconsistencies kept creeping > >into the various drivers/tables. > > > >You can find the scripts for this here: > > > > https://github.com/NVIDIA/tegra-pinmux-scripts > > > >I think there'd be some benefit if these new boards were also converted > >to use these scripts. >=20 > True, but there is no driver for pinmux which can utilize device tree, in= stead u-boot relies on board header. I see the benefit of these pinmux node= s only if I can verify that they are correct and do not brake devices. Woul= d be really bad if at some point devices brake cause nodes were not tested. >=20 > Additionally, shouldn't all supported boards be converted first? The above repository contains a script that will generate the board headers for U-Boot based on a more generic definition of the pinmux configuration. Many devices already have headers that were generated =66rom those scripts, though it's mostly later boards (Tegra124 and onwards). That said, for many of these boards a spreadsheet exists that contains these settings and the tables are generated from that spreadsheet. For many of these OEM devices I suspect no such spreadsheet exists, and it doesn't necessarily make sense to transcribe this into the tables and then convert into board header & DTS snippets. It might be nice to do for consistency, but I'll leave it up to you. The repository has been in an archived state since there wasn't any activity on it for a long time and I guess we didn't expect any new boards to be added at this point. If needed we could revive this. Thierry --Fzg2ZUeg+Kc8ozp+ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmSVqBcACgkQ3SOs138+ s6HEeg/+J+i6DVvbKX/yFh+ACqMZWeyGG7qk7VgiCurPG6SGLTmtkmOiqrX8Usgc JLwklu4xkq5P7eqFRzSPSfCSpCqFWhpjEOAVZUOPVpEuOOJKGOx279v+QdflB5vz xDcBAATH5Eag+8Dz2BRGgtYijsZ8vx/Vpi9scyMa9BBwAkR/gVgEXgklMYXqZl6h tsdpGAlcss086lyqENsYvX7X0O3qzxRl/GnanXmDKFycL+bO9IJ8pohtxrFHw2YV sBaf04yaoIVBNlCcI6D5cw79BXxmWJLfyQxqAan4Qq5t2FQELSlcmPJ+/ThFf8gp LalLNB7gZW+TaWJjU4FJP0nsVnQ0Y1nOlevs6tTMBHgOTHaoOWB0KdAlqc+DzXCN BN4eJyAE14J13e1roGGlYf2ZudyFaR+MDGt+DaLclGa1wRTDvyvqU8AKed8IzMcJ AwxeKJXOHOURDRtBFHlnSHPp6HZ3rSxu8qTcRDzlWL9BJ1muKpkqEyQDNRJgOBX6 vjcrk7sPa7LGpEUnP5ekwCyL2b6bGNgN1cRmQIy/Gy4bSEaqWKBBnqSPM8ILj67U hLHwFMzsXKzmpNfBvNE70ybNKQwd4dorqNvZ+2o8z6AQWi+dtJFo32js//XNaEOb NbNfSY67CqF0J31Bi3qTHI7JAAWdUUikqkv92zFEYxALiEvKzfU= =J0S8 -----END PGP SIGNATURE----- --Fzg2ZUeg+Kc8ozp+--