From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Chao Yu <chao@kernel.org>
Cc: Chunhai Guo <guochunhai@vivo.com>,
linux-f2fs-devel@lists.sourceforge.net, frank.li@vivo.com
Subject: Re: [f2fs-dev] [PATCH v8] fsck.f2fs: Detect and fix looped node chain efficiently
Date: Fri, 23 Jun 2023 11:50:09 -0700 [thread overview]
Message-ID: <ZJXpYR7eRVf+Gfj/@google.com> (raw)
In-Reply-To: <5dade26f-9c0c-8022-ffdc-ec844ce87f32@kernel.org>
On 06/23, Chao Yu wrote:
> On 2023/5/24 10:42, Chunhai Guo wrote:
> > + if (!c.fix_on) {
> > err = -1;
> > break;
> > }
>
> One more comment.
>
> I guess we'd better skip find_fsync_inode() and continue fsck rather
> than exiting directly if c.fix_on is not set, thoughts?
Chunhai, could you please post a final version of this patch?
>
> Thanks,
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2023-06-23 18:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-24 2:42 [f2fs-dev] [PATCH v8] fsck.f2fs: Detect and fix looped node chain efficiently Chunhai Guo via Linux-f2fs-devel
2023-05-25 1:23 ` Chao Yu
2023-05-25 22:36 ` Jaegeuk Kim
2023-06-14 9:27 ` Chunhai Guo via Linux-f2fs-devel
2023-06-14 16:15 ` Jaegeuk Kim
2023-06-15 2:12 ` Chunhai Guo via Linux-f2fs-devel
2023-06-17 2:20 ` Chao Yu
2023-06-21 9:18 ` Chunhai Guo via Linux-f2fs-devel
2023-06-23 1:52 ` Chao Yu
2023-06-23 18:50 ` Jaegeuk Kim [this message]
2023-06-25 7:14 ` Chunhai Guo via Linux-f2fs-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJXpYR7eRVf+Gfj/@google.com \
--to=jaegeuk@kernel.org \
--cc=chao@kernel.org \
--cc=frank.li@vivo.com \
--cc=guochunhai@vivo.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.