From: Simon Horman <simon.horman@corigine.com>
To: Heng Qi <hengqi@linux.alibaba.com>
Cc: netdev@vger.kernel.org, bpf@vger.kernel.org,
"Michael S . Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>,
Xuan Zhuo <xuanzhuo@linux.alibaba.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Jesper Dangaard Brouer <hawk@kernel.org>,
John Fastabend <john.fastabend@gmail.com>
Subject: Re: [PATCH net-next v2 1/3] virtio-net: reprobe csum related fields for skb passed by XDP
Date: Sat, 24 Jun 2023 21:28:42 +0200 [thread overview]
Message-ID: <ZJdCW4pxTioTPKJn@corigine.com> (raw)
In-Reply-To: <20230624122604.110958-2-hengqi@linux.alibaba.com>
On Sat, Jun 24, 2023 at 08:26:02PM +0800, Heng Qi wrote:
...
> +static int virtnet_set_csum_after_xdp(struct virtnet_info *vi,
> + struct sk_buff *skb,
> + __u8 flags)
Hi Heng Qi,
Unfortunately this appears to break an x86_64 allmodconfig build
with GCC 12.3.0:
drivers/net/virtio_net.c:1671:12: error: 'virtnet_set_csum_after_xdp' defined but not used [-Werror=unused-function]
1671 | static int virtnet_set_csum_after_xdp(struct virtnet_info *vi,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
--
pw-bot: changes-requested
next prev parent reply other threads:[~2023-06-24 19:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-24 12:26 [PATCH net-next v2 0/3] virtio-net: avoid conflicts between XDP and GUEST_CSUM Heng Qi
2023-06-24 12:26 ` [PATCH net-next v2 1/3] virtio-net: reprobe csum related fields for skb passed by XDP Heng Qi
2023-06-24 19:28 ` Simon Horman [this message]
2023-06-25 2:17 ` Heng Qi
2023-06-25 21:53 ` Michael S. Tsirkin
2023-06-25 6:44 ` Jason Wang
2023-06-25 7:27 ` Heng Qi
2023-06-26 2:09 ` Jason Wang
2023-06-26 3:34 ` Heng Qi
2023-06-24 12:26 ` [PATCH net-next v2 2/3] virtio-net: support coexistence of XDP and GUEST_CSUM Heng Qi
2023-06-24 12:26 ` [PATCH net-next v2 3/3] virtio-net: remove GUEST_CSUM check for XDP Heng Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJdCW4pxTioTPKJn@corigine.com \
--to=simon.horman@corigine.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=hengqi@linux.alibaba.com \
--cc=jasowang@redhat.com \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.