Re: [PATCH 2/2] accel: Re-enable WHPX cross-build on case sensitive filesystems

["Daniel P. Berrangé" <berrange@redhat.com>]

On Sat, Jun 24, 2023 at 04:22:11PM +0200, Philippe Mathieu-Daudé wrote:
> Since MinGW commit 395dcfdea ("rename hyper-v headers and def
> files to lower case") [*], WinHvPlatform.h and WinHvEmulation.h
> got respectively renamed as winhvplatform.h / winhvemulation.h.
> 
> The mingw64-headers package included in the Fedora version we
> use for CI does include this commit; and meson fails to detect
> these present-but-renamed headers while cross-building (on
> case-sensitive filesystems).
> 
> Use the renamed header in order to detect and successfully
> cross-build with the WHPX accelerator.
> 
> Note, on Windows hosts, the libraries are still named as
> WinHvPlatform.dll and WinHvEmulation.dll, so we don't bother
> renaming the definitions used by load_whp_dispatch_fns() in
> target/i386/whpx/whpx-all.c.
> 
> [*] https://sourceforge.net/p/mingw-w64/mingw-w64/ci/395dcfdea
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>  meson.build                      | 4 ++--
>  target/i386/whpx/whpx-internal.h | 4 ++--
>  target/i386/whpx/whpx-all.c      | 4 ++--
>  3 files changed, 6 insertions(+), 6 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|