From: Jason Gunthorpe <jgg@nvidia.com>
To: Kashyap Desai <kashyap.desai@broadcom.com>
Cc: linux-rdma@vger.kernel.org, dan.carpenter@linaro.org,
Selvin Xavier <selvin.xavier@broadcom.com>
Subject: Re: [PATCH for-next 1/2] RDMA/bnxt_re: Remove incorrect return check from slow path
Date: Mon, 26 Jun 2023 10:27:58 -0300 [thread overview]
Message-ID: <ZJmSXiQyi9wbbdVP@nvidia.com> (raw)
In-Reply-To: <20230616061700.741769-1-kashyap.desai@broadcom.com>
On Fri, Jun 16, 2023 at 11:46:59AM +0530, Kashyap Desai wrote:
> The patch 691eb7c6110f: "RDMA/bnxt_re: handle command
> completions after driver detect a timedout" introduced code resulting in
> below warning issued by the smatch static checker.
>
> drivers/infiniband/hw/bnxt_re/qplib_rcfw.c:513 __bnxt_qplib_rcfw_send_message()
> warn: duplicate check 'rc' (previous on line 506)
>
> Fix the warning by removing incorrect code block.
>
> Fixes: 691eb7c6110f ("RDMA/bnxt_re: handle command completions after driver detect a timedout")
> Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> Signed-off-by: Kashyap Desai <kashyap.desai@broadcom.com>
> Signed-off-by: Selvin Xavier <selvin.xavier@broadcom.com>
> ---
> drivers/infiniband/hw/bnxt_re/qplib_rcfw.c | 6 ------
> 1 file changed, 6 deletions(-)
Both applied to for-next, thanks
Jason
prev parent reply other threads:[~2023-06-26 13:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-16 6:16 [PATCH for-next 1/2] RDMA/bnxt_re: Remove incorrect return check from slow path Kashyap Desai
2023-06-16 6:17 ` [PATCH for-next 2/2] RDMA/bnxt_re: refactor code around bnxt_qplib_map_rc Kashyap Desai
2023-06-16 7:04 ` Dan Carpenter
2023-06-26 13:27 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJmSXiQyi9wbbdVP@nvidia.com \
--to=jgg@nvidia.com \
--cc=dan.carpenter@linaro.org \
--cc=kashyap.desai@broadcom.com \
--cc=linux-rdma@vger.kernel.org \
--cc=selvin.xavier@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.