From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6109EEB64D7 for ; Mon, 26 Jun 2023 15:17:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229939AbjFZPRo (ORCPT ); Mon, 26 Jun 2023 11:17:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41794 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230199AbjFZPRn (ORCPT ); Mon, 26 Jun 2023 11:17:43 -0400 Received: from mail.netfilter.org (mail.netfilter.org [217.70.188.207]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id EC3BE191; Mon, 26 Jun 2023 08:17:42 -0700 (PDT) Date: Mon, 26 Jun 2023 17:17:40 +0200 From: Pablo Neira Ayuso To: Randy Dunlap Cc: netdev@vger.kernel.org, Florian Westphal , Jozsef Kadlecsik , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Subject: Re: [PATCH net-next] linux/netfilter.h: fix kernel-doc warnings Message-ID: References: <20230623061101.32513-1-rdunlap@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230623061101.32513-1-rdunlap@infradead.org> Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Thu, Jun 22, 2023 at 11:11:01PM -0700, Randy Dunlap wrote: > kernel-doc does not support DECLARE_PER_CPU(), so don't mark it with > kernel-doc notation. > > One comment block is not kernel-doc notation, so just use > "/*" to begin the comment. > > Quietens these warnings: > > netfilter.h:493: warning: Function parameter or member 'bool' not described in 'DECLARE_PER_CPU' > netfilter.h:493: warning: Function parameter or member 'nf_skb_duplicated' not described in 'DECLARE_PER_CPU' > netfilter.h:493: warning: expecting prototype for nf_skb_duplicated(). Prototype was for DECLARE_PER_CPU() instead > netfilter.h:496: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst > * Contains bitmask of ctnetlink event subscribers, if any. Applied to nf.git, thanks