From: Tejun Heo <tj@kernel.org>
To: Chuck Lever III <chuck.lever@oracle.com>
Cc: open list <linux-kernel@vger.kernel.org>,
Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: contention on pwq->pool->lock under heavy NFS workload
Date: Mon, 26 Jun 2023 10:21:29 -1000 [thread overview]
Message-ID: <ZJnzSSMdWhnuXYNE@slm.duckdns.org> (raw)
In-Reply-To: <24E8E2D2-F91B-47F6-91BF-02D02750054F@oracle.com>
On Sun, Jun 25, 2023 at 04:01:38PM +0000, Chuck Lever III wrote:
> Both wq_pool_mutex and copy_workqueue_attrs() are static, so having
> only apply_workqueue_attrs() is not yet enough to carry this off
> in workqueue consumers such as sunrpc.ko.
>
> It looks like padata_setup_cpumasks() for example is holding the
> CPU read lock, but it doesn't take the wq_pool_mutex.
> apply_wqattrs_prepare() has a "lockdep_assert_held(&wq_pool_mutex);" .
>
> I can wait for a v3 of this series so you can construct the public
> API the way you prefer.
Ah, indeed. That API isn't really useable right now. It's gonna be a while
before the affinity scope patches are applied. I'll fix up the apply
interface afterwards.
Thanks.
--
tejun
prev parent reply other threads:[~2023-06-26 20:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 15:26 contention on pwq->pool->lock under heavy NFS workload Chuck Lever III
2023-06-21 21:28 ` Tejun Heo
2023-06-22 14:38 ` Chuck Lever III
2023-06-22 15:45 ` Chuck Lever III
2023-06-22 19:23 ` Tejun Heo
2023-06-22 19:39 ` Chuck Lever III
2023-06-23 14:37 ` Chuck Lever III
2023-06-24 1:44 ` Tejun Heo
2023-06-25 16:01 ` Chuck Lever III
2023-06-26 20:21 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJnzSSMdWhnuXYNE@slm.duckdns.org \
--to=tj@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.