From: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
To: Moritz Fischer <moritzf@google.com>
Cc: Andrew Lunn <andrew@lunn.ch>, <netdev@vger.kernel.org>,
<pabeni@redhat.com>, <kuba@kernel.org>, <edumazet@google.com>,
<davem@davemloft.net>, <bryan.whitehead@microchip.com>,
<UNGLinuxDriver@microchip.com>, <mdf@kernel.org>,
<stable@vger.kernel.org>
Subject: Re: [PATCH net v3] net: lan743x: Don't sleep in atomic context
Date: Tue, 27 Jun 2023 16:41:37 +0200 [thread overview]
Message-ID: <ZJr1Ifp9cOlfcqbE@boxer> (raw)
In-Reply-To: <CAFyOScpRDOvVrCsrwdxFstoNf1tOEnGbPSt5XDM1PKhCDyUGaw@mail.gmail.com>
On Tue, Jun 27, 2023 at 03:40:04PM +0200, Moritz Fischer wrote:
> Hi Andrew,
>
> On Tue, Jun 27, 2023 at 3:07 PM Andrew Lunn <andrew@lunn.ch> wrote:
> >
> > > > +static int lan743x_csr_wait_for_bit_atomic(struct lan743x_adapter *adapter,
> > >
> > > adapter is not used in readx_poll_timeout_atomic() call, right?
> > > can be removed.
> >
> > I thought that when i first looked at an earlier version of this
> > patch. But LAN743X_CSR_READ_OP is not what you think :-(
>
> Yeah, it's not great / confusing. I tried to keep it the same as the
> rest of the file when fixing the bug.
Ahh bummer. Additionally from the first sight @data looked like being used
uninited, I thought I haven't got fooled here :)
Side note would be that I don't see much value in iopoll.h's macros
returning
(cond) ? 0 : -ETIMEDOUT; \
this could be just !!cond but given the count of the callsites...probably
better to leave it as is.
>
> I can see if I can clean it up across the file in a follow up.
> >
> > Andrew
>
> Do you want me to send a v4 with an updated commit message?
From my POV I don't think it's worth it...
>
> Thanks,
> Moritz
next prev parent reply other threads:[~2023-06-27 14:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-27 3:50 [PATCH net v3] net: lan743x: Don't sleep in atomic context Moritz Fischer
2023-06-27 12:58 ` Maciej Fijalkowski
2023-06-27 13:07 ` Andrew Lunn
2023-06-27 13:40 ` Moritz Fischer
2023-06-27 14:41 ` Maciej Fijalkowski [this message]
2023-06-27 14:50 ` Andrew Lunn
2023-06-28 8:12 ` Moritz Fischer
2023-06-28 14:21 ` Andrew Lunn
2023-06-29 9:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJr1Ifp9cOlfcqbE@boxer \
--to=maciej.fijalkowski@intel.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=bryan.whitehead@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=mdf@kernel.org \
--cc=moritzf@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.