From: "Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com>
To: Luca Fancellu <luca.fancellu@arm.com>
Cc: xen-devel@lists.xenproject.org, bertrand.marquis@arm.com,
wei.chen@arm.com, Wei Liu <wl@xen.org>,
Anthony PERARD <anthony.perard@citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH 2/2] tools/python: Fix memory leak on error path
Date: Tue, 27 Jun 2023 14:29:21 +0200 [thread overview]
Message-ID: <ZJrWImht4GZXvLCv@mail-itl> (raw)
In-Reply-To: <ZJnT8rdnMT5lrR0A@mail-itl>
[-- Attachment #1: Type: text/plain, Size: 945 bytes --]
On Mon, Jun 26, 2023 at 08:07:46PM +0200, Marek Marczykowski-Górecki wrote:
> On Thu, Jun 08, 2023 at 02:59:13PM +0100, Luca Fancellu wrote:
> > Commit 56a7aaa16bfe introduced a memory leak on the error path for a
> > Py_BuildValue built object that on some newly introduced error path
> > has not the correct reference count handling, fix that by decrementing
> > the refcount in these path.
> >
> > Fixes: 56a7aaa16bfe ("tools: add physinfo arch_capabilities handling for Arm")
> > Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
> > Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
>
> Acked-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
Oh, and BTW, in relation to the discussion on the summit about
committing process, the buggy version was committed without my ack,
after waiting for my review for about two weeks.
--
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-06-27 12:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-08 13:59 [PATCH 1/2] tools: Fix ifdef for aarch64 that should include also arm Luca Fancellu
2023-06-08 13:59 ` [PATCH 2/2] tools/python: Fix memory leak on error path Luca Fancellu
2023-06-22 9:17 ` Luca Fancellu
2023-06-26 18:07 ` Marek Marczykowski-Górecki
2023-06-27 12:29 ` Marek Marczykowski-Górecki [this message]
2023-06-27 17:21 ` Julien Grall
2023-06-22 9:17 ` [PATCH 1/2] tools: Fix ifdef for aarch64 that should include also arm Luca Fancellu
2023-06-26 18:52 ` Marek Marczykowski-Górecki
2023-07-04 9:42 ` Anthony PERARD
2023-07-04 19:11 ` Julien Grall
2023-07-05 6:26 ` Luca Fancellu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJrWImht4GZXvLCv@mail-itl \
--to=marmarek@invisiblethingslab.com \
--cc=andrew.cooper3@citrix.com \
--cc=anthony.perard@citrix.com \
--cc=bertrand.marquis@arm.com \
--cc=luca.fancellu@arm.com \
--cc=wei.chen@arm.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.