From: Christoph Hellwig <hch@infradead.org>
To: Lu Hongfei <luhongfei@vivo.com>
Cc: Christoph Hellwig <hch@infradead.org>,
"Darrick J. Wong" <djwong@kernel.org>,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, opensource.kernel@vivo.com
Subject: Re: [PATCH] fs: iomap: Change the type of blocksize from 'int' to 'unsigned int' in iomap_file_buffered_write_punch_delalloc
Date: Tue, 27 Jun 2023 08:52:50 -0700 [thread overview]
Message-ID: <ZJsF0gs9FlNH78rE@infradead.org> (raw)
In-Reply-To: <20230627100325.51290-1-luhongfei@vivo.com>
On Tue, Jun 27, 2023 at 06:03:25PM +0800, Lu Hongfei wrote:
> loff_t start_byte;
> loff_t end_byte;
> - int blocksize = i_blocksize(inode);
> + unsigned int blocksize = i_blocksize(inode);
Please keep the existing alignment of the variable names.
With that the patch looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2023-06-27 15:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-27 10:03 [PATCH] fs: iomap: Change the type of blocksize from 'int' to 'unsigned int' in iomap_file_buffered_write_punch_delalloc Lu Hongfei
2023-06-27 15:52 ` Christoph Hellwig [this message]
2023-06-27 22:50 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJsF0gs9FlNH78rE@infradead.org \
--to=hch@infradead.org \
--cc=djwong@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=luhongfei@vivo.com \
--cc=opensource.kernel@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.