From: Christoph Hellwig <hch@infradead.org>
To: Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: avoid duplicated chunk lookup during btrfs_map_block()
Date: Tue, 27 Jun 2023 09:03:07 -0700 [thread overview]
Message-ID: <ZJsIO81Qa8oZnJC+@infradead.org> (raw)
In-Reply-To: <c063726e0bdcf99226ba474f93b56f9fd2f939f3.1687848314.git.wqu@suse.com>
On Tue, Jun 27, 2023 at 02:45:18PM +0800, Qu Wenruo wrote:
> + num_copies = map_num_copies(map);
> +
> + if (mirror_num > num_copies) {
num_copies is only used for this single comparism, so I think we'd be
better off just dropping the variable and writing this as:
if (mirror_num > map_num_copies(map)) {
> + free_extent_map(em);
> + return -EINVAL;
And I'd probably add a free_extent_map label to the end of the
function and jump to that to avoid extra error returns.
prev parent reply other threads:[~2023-06-27 16:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-27 6:45 [PATCH] btrfs: avoid duplicated chunk lookup during btrfs_map_block() Qu Wenruo
2023-06-27 7:49 ` Johannes Thumshirn
2023-06-27 16:03 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJsIO81Qa8oZnJC+@infradead.org \
--to=hch@infradead.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.