All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leo Liang <ycliang@andestech.com>
To: Bin Meng <bmeng.cn@gmail.com>
Cc: Rick Chen <rickchen36@gmail.com>, <bmeng@tinylab.org>,
	U-Boot Mailing List <u-boot@lists.denx.de>,
	rick <rick@andestech.com>, <ycliang@andestech.com>
Subject: Re: [PATCH] riscv: Fix alignment of RELA sections in the linker scripts
Date: Wed, 28 Jun 2023 03:10:59 +0000	[thread overview]
Message-ID: <ZJukw1ECXaBWIxaa@ubuntu01> (raw)
In-Reply-To: <CAEUhbmVf-X8YN0dkPH_o9-=KiZf-Vwh5LppdgJKRF5FRhskE2Q@mail.gmail.com>

Hi Rick, Bin,
On Tue, Jun 27, 2023 at 09:12:35AM +0800, Bin Meng wrote:
> On Tue, Jun 27, 2023 at 8:50 AM Rick Chen <rickchen36@gmail.com> wrote:
> >
> > > From: Bin Meng <bmeng@tinylab.org>
> > > Sent: Wednesday, June 21, 2023 11:07 PM
> > > To: u-boot@lists.denx.de
> > > Cc: Andrew Scull <ascull@google.com>; Leo Yu-Chi Liang(梁育齊) <ycliang@andestech.com>; Rick Jian-Zhi Chen(陳建志) <rick@andestech.com>; Simon Glass <sjg@chromium.org>
> > > Subject: [PATCH] riscv: Fix alignment of RELA sections in the linker scripts
> > >
> > > In current linker script both .efi_runtime_rel and .rela.dyn sections are of RELA type whose entry size is either 12 (RV32) or 24 (RV64).
> > > These two are arranged as an continuous region on purpose so that the prelink-riscv executable can fix up the PIE addresses in one loop.
> > >
> > > However there is an 'ALIGN(8)' between these 2 sections which might cause a gap to be inserted between thesse 2 sections to satify the alignment requirement on RV32. This would break the assumption of the prelink process and generate an unbootable image.
> > >
> > > Fixes: 9a6569a043d3 ("riscv: Update alignment for some sections in linker scripts")
> > > Signed-off-by: Bin Meng <bmeng@tinylab.org>
> > >
> > > ---
> > > This fix should go into the v2023.07 release.
> > >
> > >  arch/riscv/cpu/u-boot.lds | 4 +---
> > >  1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > Reviewed-by: Rick Chen <rick@andestech.com>
> >
> > Hi Leo,
> >
> > Please help to push this patch ASAP.
> >
> 
> Thanks Rick. I will respin a v2 to fix the typos in the commit message.
> 
> Regards,
> Bin

Thanks for the catch and the reminder.
The patch has been merged.

Best regards,
Leo

      reply	other threads:[~2023-06-28  3:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-21 15:06 [PATCH] riscv: Fix alignment of RELA sections in the linker scripts Bin Meng
2023-06-26 16:31 ` Bin Meng
     [not found] ` <SEZPR03MB806409552ACE0C6AD27ADBF5C127A@SEZPR03MB8064.apcprd03.prod.outlook.com>
2023-06-27  0:50   ` Rick Chen
2023-06-27  1:12     ` Bin Meng
2023-06-28  3:10       ` Leo Liang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZJukw1ECXaBWIxaa@ubuntu01 \
    --to=ycliang@andestech.com \
    --cc=bmeng.cn@gmail.com \
    --cc=bmeng@tinylab.org \
    --cc=rick@andestech.com \
    --cc=rickchen36@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.