From: Thierry Reding <thierry.reding@gmail.com>
To: Minjie Du <duminjie@vivo.com>
Cc: Krishna Reddy <vdumpa@nvidia.com>, Joerg Roedel <joro@8bytes.org>,
Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
"open list:TEGRA IOMMU DRIVERS" <linux-tegra@vger.kernel.org>,
"open list:IOMMU SUBSYSTEM" <iommu@lists.linux.dev>,
open list <linux-kernel@vger.kernel.org>,
opensource.kernel@vivo.com
Subject: Re: [PATCH v2] iommu: remove redundant parameter check in tegra_smmu_debugfs_init()
Date: Thu, 13 Jul 2023 08:51:59 +0200 [thread overview]
Message-ID: <ZK-fD7inmxjwPyL5@orome> (raw)
In-Reply-To: <20230713025653.1540-1-duminjie@vivo.com>
[-- Attachment #1: Type: text/plain, Size: 554 bytes --]
On Thu, Jul 13, 2023 at 10:56:53AM +0800, Minjie Du wrote:
> debugfs_create_file() will simply return early if
> smmu->debugfs is an error pointer.
The formatting is a little weird here.
> Make smmu->debugfs check delete in tegra_smmu_debugfs_init().
I think something like this is better:
Delete smmu->debugfs check in ...
Or perhaps combine both sentences:
debugfs_create_file() will return early if smmu->debugfs is an error
pointer, so an extra error check is not needed.
With that fixed:
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-07-13 6:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-13 2:56 [PATCH v2] iommu: remove redundant parameter check in tegra_smmu_debugfs_init() Minjie Du
2023-07-13 6:51 ` Thierry Reding [this message]
2023-07-13 9:20 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZK-fD7inmxjwPyL5@orome \
--to=thierry.reding@gmail.com \
--cc=duminjie@vivo.com \
--cc=iommu@lists.linux.dev \
--cc=jonathanh@nvidia.com \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=opensource.kernel@vivo.com \
--cc=robin.murphy@arm.com \
--cc=vdumpa@nvidia.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.