From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1qJNPm-0003fW-3f for mharc-grub-devel@gnu.org; Tue, 11 Jul 2023 20:09:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qJNPf-0003f6-BD for grub-devel@gnu.org; Tue, 11 Jul 2023 20:09:00 -0400 Received: from mail-ed1-x530.google.com ([2a00:1450:4864:20::530]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qJNPd-0004kf-N3 for grub-devel@gnu.org; Tue, 11 Jul 2023 20:08:59 -0400 Received: by mail-ed1-x530.google.com with SMTP id 4fb4d7f45d1cf-51e619bcbf9so2182858a12.3 for ; Tue, 11 Jul 2023 17:08:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689120535; x=1691712535; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=sZlvGQ3Nh7vh6Isrshpn1TjTNH2OFqFE00weUXXD7jQ=; b=L9CcwghgSwxkKmUf0n7kSs4If0c7BGeMV50GLFu0P/fznsiAPz1/jQTB05j2lCi+Rw 9wAyFh4YfIpTdeDSnJnOLx7jI408PFXEhXCmBFH7BRuC6oJptbx8ts/dZ7Kji6tw6Atf QKrykSbJFfxdikIB+wPzTB2qmhtdkn0UI5rk9S8A+o6KF9ll2zaMqNrXsWWYbQ2RhLMh oBMKZiAvPlw1cMkcBYmJ9ThfehATv1KuVPFa8Jbd6T/v4+pkshYnU7aIT4I+v8BsGhUL zDgMp5nAILLwpY3Eui14Pm/zAm1kHk7sebOre9qwuUp9Lm4IKbDmtgPPycmpEiAh96Pw B6PA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689120535; x=1691712535; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=sZlvGQ3Nh7vh6Isrshpn1TjTNH2OFqFE00weUXXD7jQ=; b=etS0OuOMJW6Dh7VabOr4mfzRE7P2uqLV9baAaiqcaKy1FUWooTxmo6RfdFLG98krN3 UDa6BdVnTsJXquq6UuIQ43lk/tqfMJU8B66Xw+N7fBS9v05WTBLRlB1UjoRpEO9rjcpt YIVhuYqXEg/eutu6hRkIuj2LSy+nFcrXrqGJlcAA8Rr8+EifkpWggf49fbhsVGEGaHW1 LZy9njaFJ/oYxd42j4KPs4B5WFp0vj2mYXZ1OBCf7rrCNl3MGAYLV2opwVS3bU9q7Qpa bsTYcl8gcidF2U4nYBulk3X/m7+DDzpX5heHx9WQBVCrw31wvyx/iilOlkuPo6cWM6FK hbZw== X-Gm-Message-State: ABy/qLbFKhCXfVgERpTeejby6KFYDRBtZG5gGuCLuOzQYGLjb9t7cBZp hDMLD5VLr+YR+2JEFHvKAtc= X-Google-Smtp-Source: APBJJlH4tehVA3frOhBxjXeplcVx1gBpCNV5Nh2kBUYLpchGfbH9lwsD7fPtFK7CvVLLmH+PRzFzPQ== X-Received: by 2002:aa7:c75a:0:b0:51e:2921:28b with SMTP id c26-20020aa7c75a000000b0051e2921028bmr18078744eds.21.1689120535002; Tue, 11 Jul 2023 17:08:55 -0700 (PDT) Received: from dj3ntoo (140.sub-75-226-201.myvzw.com. [75.226.201.140]) by smtp.gmail.com with ESMTPSA id a21-20020aa7cf15000000b0051e281a5ecesm1890997edy.58.2023.07.11.17.08.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jul 2023 17:08:54 -0700 (PDT) Date: Tue, 11 Jul 2023 19:08:48 -0500 From: Oskari Pirhonen To: Glenn Washburn Cc: grub-devel@gnu.org, Daniel Kiper Subject: Re: [PATCH v4] docs: Add missing assumption Message-ID: Mail-Followup-To: Glenn Washburn , grub-devel@gnu.org, Daniel Kiper References: <20230711170729.1497818-1-development@efficientek.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="cduTH8T55Q7BsJb0" Content-Disposition: inline In-Reply-To: <20230711170729.1497818-1-development@efficientek.com> Received-SPF: pass client-ip=2a00:1450:4864:20::530; envelope-from=xxc3ncoredxx@gmail.com; helo=mail-ed1-x530.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Jul 2023 00:09:01 -0000 --cduTH8T55Q7BsJb0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 11, 2023 at 12:07:29 -0500, Glenn Washburn wrote: > Also reword a prior sentence to be more clear. >=20 > Fixes: 5a3d2b4742df (docs: Add debugging chapter to development documenta= tion) > Signed-off-by: Glenn Washburn LGTM, thanks. Reviewed-by: Oskari Pirhonen - Oskari > --- > Range-diff against v3: > 1: 437c408b31cb ! 1: c228e0412720 docs: Add missing assumption > @@ docs/grub-dev.texi: GDB is started from the @file{grub-core} direc= tory in the GR > -If not building GRUB, the distribution may have a package which ins= talls > +When using a pre-built GRUB, the distribution may have a package wh= ich installs > this GDB script along with debug symbol binaries, such as Debian's > --@samp{grub-pc-dbg} package. The GDB script is intended to be used > + @samp{grub-pc-dbg} package. The GDB script is intended to be used > -like so, assuming: > -+@samp{grub-pc-dbg} package. The GDB script is intended to by used > +like so, assuming that @samp{/path/to/script} is the path to the di= rectory > +containing the gdb_grub script and debug symbol files: > =20 >=20 > docs/grub-dev.texi | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) >=20 > diff --git a/docs/grub-dev.texi b/docs/grub-dev.texi > index 0834ca562ad6..a695b02f06df 100644 > --- a/docs/grub-dev.texi > +++ b/docs/grub-dev.texi > @@ -660,10 +660,11 @@ GDB is started from the @file{grub-core} directory = in the GRUB2 build > directory. GRUB2 developers have made this more simple by including a GDB > script which does much of the setup. This file is at @file{grub-core/gdb= _grub} > in the build directory and is also installed via @command{make install}. > -If not building GRUB, the distribution may have a package which installs > +When using a pre-built GRUB, the distribution may have a package which i= nstalls > this GDB script along with debug symbol binaries, such as Debian's > @samp{grub-pc-dbg} package. The GDB script is intended to be used > -like so, assuming: > +like so, assuming that @samp{/path/to/script} is the path to the directo= ry > +containing the gdb_grub script and debug symbol files: > =20 > @example > cd $(dirname /path/to/script/gdb_grub) > --=20 > 2.34.1 >=20 --cduTH8T55Q7BsJb0 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQQfOU+JeXjo4uxN6vCp8he9GGIfEQUCZK3vDAAKCRCp8he9GGIf EQS4AP48hp6fbaVXhkLFbEpYxFNDhEbnDpSW1bP8XLFiuTLD+gD8CWeak4S6Z+Rw /6KKNKA7CHrrmAuaBIWAmSSGfm+W5A4= =Ze/d -----END PGP SIGNATURE----- --cduTH8T55Q7BsJb0--