From: "Günther Noack" <gnoack@google.com>
To: "Konstantin Meskhidze (A)" <konstantin.meskhidze@huawei.com>
Cc: "Mickaël Salaün" <mic@digikod.net>,
"Günther Noack" <gnoack3000@gmail.com>,
willemdebruijn.kernel@gmail.com,
linux-security-module@vger.kernel.org, netdev@vger.kernel.org,
netfilter-devel@vger.kernel.org, yusongping@huawei.com,
artem.kuzin@huawei.com
Subject: Re: [PATCH v11 10/12] selftests/landlock: Add 11 new test suites dedicated to network
Date: Mon, 3 Jul 2023 11:36:48 +0200 [thread overview]
Message-ID: <ZKKWoS+clQGLF4O4@google.com> (raw)
In-Reply-To: <338bba9d-6afa-7c6b-2843-b116abb36859@huawei.com>
On Mon, Jul 03, 2023 at 11:37:13AM +0300, Konstantin Meskhidze (A) wrote:
> 7/2/2023 11:45 AM, Mickaël Salaün пишет:
> > Initially Konstantin wrote tests with TEST_F_FORK() but I asked him to
> > only use TEST_F() because TEST_F_FORK() is only useful when a
> > FIXTURE_TEARDOWN() needs access rights that were dropped with a
> > TEST_F(), e.g. to unmount mount points set up with a FIXTURE_SETUP()
> > while Landlock restricted a test process.
> >
> > Indeed, TEST_F() already fork() to make sure there is no side effect
> > with tests.
> >
>
> Hi, Günther
> Yep. Mickaёl asked me to replace TEST_F_FORK() with TEST_F(). Please check
> this thread
>
> https://lore.kernel.org/netdev/33c1f049-12e4-f06d-54c9-b54eec779e6f@digikod.net/
> T
Ah thanks, this makes a lot of sense!
I had not realized that TEST_F would also fork a child process,
I should have double checked the selftest implementation.
—Günther
--
Sent using Mutt 🐕 Woof Woof
next prev parent reply other threads:[~2023-07-03 9:36 UTC|newest]
Thread overview: 95+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-15 16:13 [PATCH v11 00/12] Network support for Landlock Konstantin Meskhidze
2023-05-15 16:13 ` [PATCH v11 01/12] landlock: Make ruleset's access masks more generic Konstantin Meskhidze
2023-05-15 16:13 ` [PATCH v11 02/12] landlock: Allow filesystem layout changes for domains without such rule type Konstantin Meskhidze
2023-05-15 16:13 ` [PATCH v11 03/12] landlock: Refactor landlock_find_rule/insert_rule Konstantin Meskhidze
2023-06-26 18:40 ` Mickaël Salaün
2023-07-01 14:37 ` Konstantin Meskhidze (A)
2023-06-26 18:58 ` Mickaël Salaün
2023-07-01 14:38 ` Konstantin Meskhidze (A)
2023-07-06 14:34 ` Mickaël Salaün
2023-07-10 12:30 ` Konstantin Meskhidze (A)
2023-05-15 16:13 ` [PATCH v11 04/12] landlock: Refactor merge/inherit_ruleset functions Konstantin Meskhidze
2023-06-26 18:40 ` Mickaël Salaün
2023-07-01 14:52 ` Konstantin Meskhidze (A)
2023-07-05 10:16 ` Mickaël Salaün
2023-07-05 10:36 ` Konstantin Meskhidze (A)
2023-05-15 16:13 ` [PATCH v11 05/12] landlock: Move and rename layer helpers Konstantin Meskhidze
2023-05-15 16:13 ` [PATCH v11 06/12] landlock: Refactor " Konstantin Meskhidze
2023-05-15 16:13 ` [PATCH v11 07/12] landlock: Refactor landlock_add_rule() syscall Konstantin Meskhidze
2023-05-15 16:13 ` [PATCH v11 08/12] landlock: Add network rules and TCP hooks support Konstantin Meskhidze
2023-06-26 18:41 ` Mickaël Salaün
2023-07-01 14:54 ` Konstantin Meskhidze (A)
2023-06-26 18:57 ` Mickaël Salaün
2023-07-03 10:36 ` Konstantin Meskhidze (A)
2023-07-03 17:06 ` Mickaël Salaün
2023-07-04 12:37 ` Konstantin Meskhidze (A)
2023-06-27 16:14 ` Mickaël Salaün
2023-06-29 14:04 ` Mickaël Salaün
2023-07-03 10:44 ` Konstantin Meskhidze (A)
2023-07-03 10:43 ` Konstantin Meskhidze (A)
2023-06-27 19:48 ` Günther Noack
2023-07-03 12:39 ` Konstantin Meskhidze (A)
2023-08-03 14:12 ` Mickaël Salaün
2023-08-03 14:13 ` Konstantin Meskhidze (A)
2023-05-15 16:13 ` [PATCH v11 09/12] selftests/landlock: Share enforce_ruleset() Konstantin Meskhidze
2023-05-15 16:13 ` [PATCH v11 10/12] selftests/landlock: Add 11 new test suites dedicated to network Konstantin Meskhidze
2023-07-01 19:07 ` Günther Noack
2023-07-02 8:45 ` Mickaël Salaün
2023-07-03 8:37 ` Konstantin Meskhidze (A)
2023-07-03 9:36 ` Günther Noack [this message]
2023-07-06 14:55 ` [PATCH v11.1] " Mickaël Salaün
2023-07-06 16:09 ` Mickaël Salaün
2023-07-10 12:24 ` Konstantin Meskhidze (A)
2023-07-10 16:06 ` Mickaël Salaün
2023-07-12 8:42 ` Konstantin Meskhidze (A)
2023-07-12 7:02 ` Mickaël Salaün
2023-07-12 9:57 ` Konstantin Meskhidze (A)
2023-08-12 14:37 ` Konstantin Meskhidze (A)
2023-08-17 15:08 ` Mickaël Salaün
2023-09-11 10:13 ` Konstantin Meskhidze (A)
2023-09-14 8:08 ` Mickaël Salaün
2023-09-15 8:54 ` Konstantin Meskhidze (A)
2023-09-18 6:56 ` Mickaël Salaün
2023-09-20 10:00 ` Konstantin Meskhidze (A)
2023-08-13 20:09 ` Konstantin Meskhidze (A)
2023-08-17 13:19 ` Mickaël Salaün
2023-08-17 14:04 ` Konstantin Meskhidze (A)
2023-08-17 15:34 ` Mickaël Salaün
2023-08-18 14:05 ` Konstantin Meskhidze (A)
2023-08-11 21:03 ` Konstantin Meskhidze (A)
2023-08-17 12:54 ` Mickaël Salaün
2023-08-17 13:00 ` [PATCH] landlock: Fix and test network AF inconsistencies Mickaël Salaün
2023-08-17 14:13 ` Konstantin Meskhidze (A)
2023-08-17 15:36 ` Mickaël Salaün
2023-08-18 14:05 ` Konstantin Meskhidze (A)
2023-05-15 16:13 ` [PATCH v11 11/12] samples/landlock: Add network demo Konstantin Meskhidze
2023-06-06 15:17 ` Günther Noack
2023-06-13 10:54 ` Konstantin Meskhidze (A)
2023-06-13 20:38 ` Mickaël Salaün
2023-06-19 14:24 ` Konstantin Meskhidze (A)
2023-06-19 18:19 ` Mickaël Salaün
2023-06-22 8:00 ` Konstantin Meskhidze (A)
2023-06-22 10:18 ` Mickaël Salaün
2023-07-03 12:50 ` Konstantin Meskhidze (A)
2023-07-03 17:09 ` Mickaël Salaün
2023-07-04 12:33 ` Konstantin Meskhidze (A)
2023-07-06 14:35 ` Mickaël Salaün
2023-07-10 12:26 ` Konstantin Meskhidze (A)
2023-05-15 16:13 ` [PATCH v11 12/12] landlock: Document Landlock's network support Konstantin Meskhidze
2023-06-06 14:08 ` Günther Noack
2023-06-07 5:46 ` Jeff Xu
2023-06-13 10:13 ` Konstantin Meskhidze (A)
2023-06-13 20:12 ` Mickaël Salaün
2023-06-22 16:50 ` Mickaël Salaün
2023-06-23 14:35 ` Jeff Xu
2023-07-03 9:04 ` Konstantin Meskhidze (A)
2023-07-03 17:04 ` Mickaël Salaün
2023-06-13 19:56 ` Mickaël Salaün
2023-06-19 14:25 ` Konstantin Meskhidze (A)
2023-06-26 18:59 ` Mickaël Salaün
2023-07-03 10:42 ` Konstantin Meskhidze (A)
2023-06-05 15:02 ` [PATCH v11 00/12] Network support for Landlock Mickaël Salaün
2023-06-06 9:10 ` Konstantin Meskhidze (A)
2023-06-06 9:40 ` Mickaël Salaün
2023-06-19 14:28 ` Konstantin Meskhidze (A)
2023-06-19 18:23 ` Mickaël Salaün
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZKKWoS+clQGLF4O4@google.com \
--to=gnoack@google.com \
--cc=artem.kuzin@huawei.com \
--cc=gnoack3000@gmail.com \
--cc=konstantin.meskhidze@huawei.com \
--cc=linux-security-module@vger.kernel.org \
--cc=mic@digikod.net \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=willemdebruijn.kernel@gmail.com \
--cc=yusongping@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.