From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: You Kangren <youkangren@vivo.com>
Cc: Giovanni Cabiddu <giovanni.cabiddu@intel.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
Damian Muszynski <damian.muszynski@intel.com>,
Adam Guerin <adam.guerin@intel.com>,
Tom Zanussi <tom.zanussi@linux.intel.com>,
Srinivas Kerekare <srinivas.kerekare@intel.com>,
"open list:QAT DRIVER" <qat-linux@intel.com>,
"open list:CRYPTO API" <linux-crypto@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
opensource.kernel@vivo.com, luhongfei@vivo.com
Subject: Re: [PATCH v4] crypto: qat - Replace the if statement with min()
Date: Tue, 4 Jul 2023 10:15:29 +0300 [thread overview]
Message-ID: <ZKPHEYxkBeFbIBeR@smile.fi.intel.com> (raw)
In-Reply-To: <20230704065643.32220-1-youkangren@vivo.com>
On Tue, Jul 04, 2023 at 02:56:39PM +0800, You Kangren wrote:
> mark UWORD_CPYBUF_SIZE with U suffix to make the type the same with
You need to respect English grammar and punctuation.
Here should be
Mark...
> words_num and replace the if statement with min() in
(drop trailing space)
> qat_uclo_wr_uimage_raw_page() to make code shorter
...and here the period is missing.
Also, Haven't I given my tag? Why it's not added?
> Signed-off-by: You Kangren <youkangren@vivo.com>
> ---
Where is the changelog from v3? What had been changed so far?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-07-04 7:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-04 6:56 [PATCH v4] crypto: qat - Replace the if statement with min() You Kangren
2023-07-04 7:15 ` Andy Shevchenko [this message]
[not found] <PUZPR06MB5936BE4F5D5353CF2A08A07BAA2EA@PUZPR06MB5936.apcprd06.prod.outlook.com>
2023-07-04 7:55 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZKPHEYxkBeFbIBeR@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=adam.guerin@intel.com \
--cc=damian.muszynski@intel.com \
--cc=davem@davemloft.net \
--cc=giovanni.cabiddu@intel.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luhongfei@vivo.com \
--cc=opensource.kernel@vivo.com \
--cc=qat-linux@intel.com \
--cc=srinivas.kerekare@intel.com \
--cc=tom.zanussi@linux.intel.com \
--cc=youkangren@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.