From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Daniel Scally <dan.scally@ideasonboard.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Kate Hsuan <hpa@redhat.com>, Hao Yao <hao.yao@intel.com>,
Bingbu Cao <bingbu.cao@intel.com>,
linux-media@vger.kernel.org
Subject: Re: [PATCH v2 09/15] media: ipu-bridge: Drop early setting of sensor->adev
Date: Tue, 4 Jul 2023 17:26:31 +0300 [thread overview]
Message-ID: <ZKQsF4Spx5MEtKnD@smile.fi.intel.com> (raw)
In-Reply-To: <0dc01c91-dfe0-a422-06f2-0f6ae8257a5f@redhat.com>
On Tue, Jul 04, 2023 at 01:20:33PM +0200, Hans de Goede wrote:
> On 6/30/23 16:30, Andy Shevchenko wrote:
> > On Fri, Jun 30, 2023 at 2:07 PM Hans de Goede <hdegoede@redhat.com> wrote:
> >>
> >> sensor->adev is no longer dereferenced before it is permanently set by:
> >>
> >> sensor->adev = acpi_dev_get(adev);
> >>
> >> So the early assignment with a borrowed reference can be dropped.
> >
> > Ah, now I see that that change was temporary.
>
> Ack
>
> > Can we avoid backporting
> > it please?
>
> Patch 1/15 does fix a NULL pointer deref oops, so backporting it would
> be a good thing to do IMHO.
Then better to go with ACPI handle. I don't like the rewriting same field
(even if it's the same information). It's prone to errors which might be
hard to find.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-07-04 14:26 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-30 11:06 [PATCH v2 00/15] media: ipu-bridge: Shared with atomisp, rework VCM instantiation Hans de Goede
2023-06-30 11:06 ` [PATCH v2 01/15] media: ipu-bridge: Fix null pointer deref on SSDB/PLD parsing warnings Hans de Goede
2023-06-30 14:23 ` Andy Shevchenko
2023-07-04 11:02 ` Dan Scally
2023-07-04 14:28 ` Andy Shevchenko
2023-07-04 14:50 ` Hans de Goede
2023-07-05 8:37 ` Andy Shevchenko
2023-06-30 11:06 ` [PATCH v2 02/15] media: ipu-bridge: Do not use on stack memory for software_node.name field Hans de Goede
2023-07-04 11:03 ` Dan Scally
2023-06-30 11:06 ` [PATCH v2 03/15] media: ipu-bridge: Move initialization of node_names.vcm to ipu_bridge_init_swnode_names() Hans de Goede
2023-07-04 11:08 ` Dan Scally
2023-06-30 11:06 ` [PATCH v2 04/15] media: ipu-bridge: Allow building as module Hans de Goede
2023-06-30 14:08 ` Andy Shevchenko
2023-07-04 11:19 ` Hans de Goede
2023-06-30 11:06 ` [PATCH v2 05/15] media: ipu-bridge: Make ipu_bridge_init() take a regular struct device as argument Hans de Goede
2023-07-04 11:27 ` Dan Scally
2023-06-30 11:06 ` [PATCH v2 06/15] media: ipu-bridge: Store dev pointer in struct ipu_bridge Hans de Goede
2023-06-30 11:06 ` [PATCH v2 07/15] media: ipu-bridge: Only keep PLD around while parsing Hans de Goede
2023-07-04 11:21 ` Dan Scally
2023-06-30 11:06 ` [PATCH v2 08/15] media: ipu-bridge: Add a ipu_bridge_parse_ssdb() helper function Hans de Goede
2023-07-04 11:26 ` Dan Scally
2023-06-30 11:06 ` [PATCH v2 09/15] media: ipu-bridge: Drop early setting of sensor->adev Hans de Goede
2023-06-30 14:30 ` Andy Shevchenko
2023-07-04 11:20 ` Hans de Goede
2023-07-04 14:26 ` Andy Shevchenko [this message]
2023-06-30 11:06 ` [PATCH v2 10/15] media: ipu-bridge: Add a parse_sensor_fwnode callback to ipu_bridge_init() Hans de Goede
2023-06-30 14:36 ` Andy Shevchenko
2023-06-30 11:06 ` [PATCH v2 11/15] media: ipu-bridge: Move ipu-bridge.h to include/media/ Hans de Goede
2023-06-30 14:37 ` Andy Shevchenko
2023-06-30 11:06 ` [PATCH v2 12/15] media: ipu-bridge: Add GalaxyCore GC0310 to ipu_supported_sensors[] Hans de Goede
2023-06-30 14:38 ` Andy Shevchenko
2023-07-04 10:35 ` Dan Scally
2023-07-04 10:49 ` Sakari Ailus
2023-07-04 10:59 ` Hans de Goede
2023-07-05 11:38 ` Sakari Ailus
2023-07-05 11:50 ` Hans de Goede
2023-07-05 12:10 ` Sakari Ailus
2023-07-05 12:33 ` Hans de Goede
2023-07-05 13:28 ` Sakari Ailus
2023-07-05 13:30 ` Hans de Goede
2023-07-06 9:30 ` Andy Shevchenko
2023-06-30 11:06 ` [PATCH v2 13/15] media: atomisp: csi2-bridge: Switch to new common ipu_bridge_init() Hans de Goede
2023-06-30 14:45 ` Andy Shevchenko
2023-07-04 13:55 ` Dan Scally
2023-07-04 14:32 ` Andy Shevchenko
2023-07-04 15:49 ` Hans de Goede
2023-07-04 19:21 ` Hans de Goede
2023-07-05 8:41 ` Andy Shevchenko
2023-07-05 10:38 ` Sakari Ailus
2023-07-05 10:51 ` Hans de Goede
2023-07-05 10:58 ` Sakari Ailus
2023-06-30 11:06 ` [PATCH v2 14/15] media: ipu-bridge: Add a runtime-pm device-link between VCM and sensor Hans de Goede
2023-06-30 14:47 ` Andy Shevchenko
2023-07-04 15:07 ` Dan Scally
2023-07-04 15:27 ` Andy Shevchenko
2023-07-04 15:52 ` Hans de Goede
2023-07-05 8:43 ` Andy Shevchenko
2023-06-30 11:06 ` [PATCH v2 15/15] [RFC] media: dw9719: Drop hack to enable "vsio" regulator Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZKQsF4Spx5MEtKnD@smile.fi.intel.com \
--to=andy.shevchenko@gmail.com \
--cc=bingbu.cao@intel.com \
--cc=dan.scally@ideasonboard.com \
--cc=hao.yao@intel.com \
--cc=hdegoede@redhat.com \
--cc=hpa@redhat.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.