From: Kent Gibson <warthog618@gmail.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [PATCH] gpiolib: add missing include
Date: Wed, 5 Jul 2023 18:57:51 +0800 [thread overview]
Message-ID: <ZKVMr9yrL2JavqhF@sol> (raw)
In-Reply-To: <20230705074219.8321-1-brgl@bgdev.pl>
On Wed, Jul 05, 2023 at 09:42:19AM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> gpiolib.h uses notifiers but doesn't include <linux/notifier.h>.
>
Fair enough.
Reviewed-by: Kent Gibson <warthog618@gmail.com>
Same is true for gpiolib-cdev, btw.
You want to touch that one up as well?
Cheers,
Kent.
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
> drivers/gpio/gpiolib.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpio/gpiolib.h b/drivers/gpio/gpiolib.h
> index cca81375f127..1409d52487c0 100644
> --- a/drivers/gpio/gpiolib.h
> +++ b/drivers/gpio/gpiolib.h
> @@ -14,6 +14,7 @@
> #include <linux/err.h>
> #include <linux/device.h>
> #include <linux/module.h>
> +#include <linux/notifier.h>
> #include <linux/cdev.h>
> #include <linux/rwsem.h>
>
> --
> 2.39.2
>
next prev parent reply other threads:[~2023-07-05 10:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-05 7:42 [PATCH] gpiolib: add missing include Bartosz Golaszewski
2023-07-05 10:57 ` Kent Gibson [this message]
2023-07-05 10:59 ` Bartosz Golaszewski
2023-07-05 11:05 ` Kent Gibson
2023-07-05 11:58 ` Bartosz Golaszewski
2023-07-06 9:34 ` Andy Shevchenko
-- strict thread matches above, loose matches on Subject: below --
2025-02-07 8:30 Bartosz Golaszewski
2025-02-07 20:33 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZKVMr9yrL2JavqhF@sol \
--to=warthog618@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.