From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B5F7D528 for ; Wed, 5 Jul 2023 15:56:07 +0000 (UTC) Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-3fbd200d354so338485e9.1 for ; Wed, 05 Jul 2023 08:56:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1688572565; x=1691164565; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=GYl9dDlLv7juVUuGio24znjAwTBLGpzEvhC+B5zwLUw=; b=JKQXMmHvZOw1WOVF/7ACDlYLRRIjGqWpOS8WydbH1aNger9bnzy7JomD6D7hO8MUK/ SdQlPYP4GYuNlYjat/HP4J4GEhji40KWNHw2JJQFxH9pCSk+yW7HErHoJlWFyKRA3+xC P0gy2T2rKM+iGb4zRQkcB1m+S4SN/B+oNxiJfyjEkYbostmx2qGg62bnIXeP+SkqnyMu fsyIAZDCGeVoRUOjobx682Qv9jGzPfc22MtiqJIN5XbPkeqdv4RABZKcH5zKM9PxPHeh coDOamaraX1Y/A7Pwb2ejHhPBi2i5kttWf3s6BFeY88qBisSzpRJUzD6oZDvfkCqqttP 5Qqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688572565; x=1691164565; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GYl9dDlLv7juVUuGio24znjAwTBLGpzEvhC+B5zwLUw=; b=JFO+rAPSRncsl5irocIie2UYm3tOhN5oHZ9UJMWn4cC69tRXqW87Tw6mcZOg0osAmN 5cgUqRME25E/kEPm6+N987x9r0MbV6qQ/3yY+gECwRzm9T/TkQ/mN2zQ9cFiJU3d50Vx 1rtWYxw5RT8L65ZI5HHa9hMkg3tnXmL71ybza+iDo720YeupKppqhZq6xijXWfY45Nl9 2N5jzGrhIrcLdmx0F6475IrVhiAG6L9GG8VYFLCyW491yKhUgRXpryrkikV9mswIoUMM 2/3+eB2fqATDMFWdhYK2SpiBOu4ln0WjCwG7O+aJj50p2MTxbpv0RE0x7CVnWyfiiNO0 Jk4A== X-Gm-Message-State: ABy/qLZypq/2ZDCLYpGAgf5CU1htBH9HfHD3z7OA6gFifYuwO0OSKVuT doneNu0Ijpiz1q0pgGlxqurE7Q== X-Google-Smtp-Source: APBJJlFKYqCuwEaSLWe4XCyFgTO192avgIhB8a/G7nm8UzEuNR931RRYa9jZq3N7YbmBhw60TpGBCA== X-Received: by 2002:a05:600c:5119:b0:3f4:2736:b5eb with SMTP id o25-20020a05600c511900b003f42736b5ebmr90778wms.1.1688572565343; Wed, 05 Jul 2023 08:56:05 -0700 (PDT) Received: from google.com (44.232.78.34.bc.googleusercontent.com. [34.78.232.44]) by smtp.gmail.com with ESMTPSA id o10-20020a1c750a000000b003fbc2c0addbsm2476633wmc.42.2023.07.05.08.56.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jul 2023 08:56:04 -0700 (PDT) Date: Wed, 5 Jul 2023 15:56:00 +0000 From: Mostafa Saleh To: Sudeep Holla Cc: maz@kernel.org, oliver.upton@linux.dev, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, tabba@google.com, qperret@google.com, will@kernel.org, catalin.marinas@arm.com, yuzenghui@huawei.com, suzuki.poulose@arm.com, james.morse@arm.com, bgardon@google.com, gshan@redhat.com Subject: Re: [PATCH v3] KVM: arm64: Use BTI for nvhe Message-ID: References: <20230530150845.2856828-1-smostafa@google.com> <20230704134136.a5znw4jupt5yp5kg@bogus> <20230704143339.cqrvntq7rmmb2on3@bogus> <20230704192529.d4x2p7ndz2dc4q52@bogus> Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230704192529.d4x2p7ndz2dc4q52@bogus> Hi Sudeep, On Tue, Jul 04, 2023 at 08:25:29PM +0100, Sudeep Holla wrote: > On Tue, Jul 04, 2023 at 04:27:04PM +0000, Mostafa Saleh wrote: > > Hi Sudeep, > > > > On Tue, Jul 04, 2023 at 03:33:39PM +0100, Sudeep Holla wrote: > > > Hi Mostafa, > > > > > > On Tue, Jul 04, 2023 at 02:18:09PM +0000, Mostafa Saleh wrote: > > > > Hi Sudeep, > > > > > > > > On Tue, Jul 04, 2023 at 02:41:36PM +0100, Sudeep Holla wrote: > > > > > On Tue, May 30, 2023 at 03:08:45PM +0000, Mostafa Saleh wrote: > > > > > > CONFIG_ARM64_BTI_KERNEL compiles the kernel to support ARMv8.5-BTI. > > > > > > However, the nvhe code doesn't make use of it as it doesn't map any > > > > > > pages with Guarded Page(GP) bit. > > > > > > > > > > > > kvm pgtable code is modified to map executable pages with GP bit > > > > > > if BTI is enabled for the kernel. > > > > > > > > > > > > At hyp init, SCTLR_EL2.BT is set to 1 to match EL1 configuration > > > > > > (SCTLR_EL1.BT1) set in bti_enable(). > > > > > > > > > > > > One difference between kernel and nvhe code, is that the kernel maps > > > > > > .text with GP while nvhe maps all the executable pages, this makes > > > > > > nvhe code need to deal with special initialization code coming from > > > > > > other executable sections (.idmap.text). > > > > > > For this we need to add bti instruction at the beginning of > > > > > > __kvm_handle_stub_hvc as it can be called by __host_hvc through > > > > > > branch instruction(br) and unlike SYM_FUNC_START, SYM_CODE_START > > > > > > doesn’t add bti instruction at the beginning, and it can’t be modified > > > > > > to add it as it is used with vector tables. > > > > > > Another solution which is more intrusive is to convert > > > > > > __kvm_handle_stub_hvc to a function and inject “bti jc” instead of > > > > > > “bti c” in SYM_FUNC_START > > > > > > > > > > > > > > > > I was chasing a bug in linux-next yesterday with protected nVHE(pKVM) and > > > > > cpuidle enabled. The system fails to boot. I just bisected the issue to this > > > > > patch and also saw this patch landed in the linus tree yesterday/today. > > > > > > > > One of the challenges of BTI is that we need to add explicit BTI instructions > > > > for assembly code. I checked the code to make sure that nothing was missing, > > > > but maybe this is not the case. > > > > Can you please share more about the issue (is ESR a Branch Target Exception, > > > > call stack...) if possible. > > > > > > I haven't debugged it any further, just reported it as soon as I bisected it. > > > Reverting this get back the booting system. I am not sure if anything is going > > > wrong when the CPU is entering suspend(highly unlikely in normal scenario but > > > I am not so sure with pKVM trapping these PSCI calls now) or when it is woken > > > up and resuming back. IIUC this now will happen via kvm_hyp_cpu_resume-> > > > __kvm_hyp_init_cpu->___kvm_hyp_init. > > > > Thanks a lot for the information. > > > > I checked this now, and I believe I found an issue. I see that __kvm_hyp_init_cpu > > calls kvm_host_psci_cpu_entry indirectly and there is no BTI there. > > I think this is the only C function that needs special handling. > > > > So it is in the wake up path. Thanks for the description, now I understand > the issue and fix better. > > > Can you please check if this solves the issue? > > > > Yes, the below patch fixed the issue. Feel free to add when you post the > formal patch. > > Reported-and-Tested-by: Sudeep Holla Thanks for testing the patch, I will post it on the list. > > diff --git a/arch/arm64/kvm/hyp/nvhe/host.S b/arch/arm64/kvm/hyp/nvhe/host.S > > index c87c63133e10..7df63f364c3c 100644 > > --- a/arch/arm64/kvm/hyp/nvhe/host.S > > +++ b/arch/arm64/kvm/hyp/nvhe/host.S > > @@ -297,3 +297,8 @@ SYM_CODE_START(__kvm_hyp_host_forward_smc) > > > > ret > > SYM_CODE_END(__kvm_hyp_host_forward_smc) > > + > > +SYM_CODE_START(kvm_host_psci_cpu_entry) > > + bti j > > + b __kvm_host_psci_cpu_entry > > +SYM_CODE_END(kvm_host_psci_cpu_entry) > > diff --git a/arch/arm64/kvm/hyp/nvhe/psci-relay.c b/arch/arm64/kvm/hyp/nvhe/psci-relay.c > > index 08508783ec3d..24543d2a3490 100644 > > --- a/arch/arm64/kvm/hyp/nvhe/psci-relay.c > > +++ b/arch/arm64/kvm/hyp/nvhe/psci-relay.c > > @@ -200,7 +200,7 @@ static int psci_system_suspend(u64 func_id, struct kvm_cpu_context *host_ctxt) > > __hyp_pa(init_params), 0); > > } > > > > -asmlinkage void __noreturn kvm_host_psci_cpu_entry(bool is_cpu_on) > > +asmlinkage void __noreturn __kvm_host_psci_cpu_entry(bool is_cpu_on) > > { > > struct psci_boot_args *boot_args; > > struct kvm_cpu_context *host_ctxt; > > > > > > > > Also, is this with CONFIG_ARM_PSCI_CPUIDLE? > > > > > > Yes, basically the cpus can enter cpu_suspend which IIUC pKVM traps and > > > handle for the host. > > > > My current setup has no CONFIG_ARM_PSCI_CPUIDLE?, I will try to find > > something I can test with. > > > > No worries, I can help until you find one. > > > > > > > > > > > Not sure if this is something to do with the fact that pKVM skips to > > > > > __kvm_handle_stub_hvc in __host_hvc. > > > > > > Sorry, my bad. I meant pKVM skips calling __kvm_handle_stub_hvc in __host_hvc > > > and jumps to __host_exit directly. Sorry for that, one wrong "to" changed the > > > whole meaning. > > > > I don't see an issue in this, as this path has no indirect branches. > > > > Understood. Thanks, Mostafa From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EEBE4EB64DA for ; Wed, 5 Jul 2023 15:56:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pQ24GA8Y87pC2w2FY6xtkKPEBHznM4vRKBirHYpEID0=; b=ZHpqXLcCYvtMpG FUcIB6qgla0AxxZwon+YxTl9KWLVIbQJOG7McoqQlnlXtJip97eRclI43AKsjjs1/UtV0cB4D5T5q YBrmCULly7V0f5goMAigq5ov0bA+BuQLkQEKV9Zfhv2ngACm8mkkUDw5KJ3zpRj+Nj1HkSmKf8ibh sNBxtEzMVqTg9gBTLLdWKeZf9cQx6S3NR984QV4jJSjasN5u8yF26/Cdv2xXRlyRz5QuOgBI3BB2x 6WRel91Un+rJUuAmhG5Uelt/IcTnkbjtB9duFuP6theafdaxxwtViyEXYOIumIMowc0BhaBDHzZom ET/c3dbMGY7WI93vZPkw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qH4rT-00GPYn-11; Wed, 05 Jul 2023 15:56:11 +0000 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qH4rP-00GPXy-20 for linux-arm-kernel@lists.infradead.org; Wed, 05 Jul 2023 15:56:09 +0000 Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-3fbca6a9ae4so392215e9.0 for ; Wed, 05 Jul 2023 08:56:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1688572565; x=1691164565; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=GYl9dDlLv7juVUuGio24znjAwTBLGpzEvhC+B5zwLUw=; b=JKQXMmHvZOw1WOVF/7ACDlYLRRIjGqWpOS8WydbH1aNger9bnzy7JomD6D7hO8MUK/ SdQlPYP4GYuNlYjat/HP4J4GEhji40KWNHw2JJQFxH9pCSk+yW7HErHoJlWFyKRA3+xC P0gy2T2rKM+iGb4zRQkcB1m+S4SN/B+oNxiJfyjEkYbostmx2qGg62bnIXeP+SkqnyMu fsyIAZDCGeVoRUOjobx682Qv9jGzPfc22MtiqJIN5XbPkeqdv4RABZKcH5zKM9PxPHeh coDOamaraX1Y/A7Pwb2ejHhPBi2i5kttWf3s6BFeY88qBisSzpRJUzD6oZDvfkCqqttP 5Qqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688572565; x=1691164565; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GYl9dDlLv7juVUuGio24znjAwTBLGpzEvhC+B5zwLUw=; b=OqdpHCNEMSsZg3Kt2iBvVCY11kPF201aXsuqAbpuAN3T6fhAu86fFjGaHjKW5zIWuc E4BAmdF7ApnNBlxqeTKk2uNU7V+Kq4X2RrWVGhj7j4ehrR8XFjliJArtks8EqmaVkepa 8AseVXXEN4nYt2b4EgAJwkaq6EHeTIO+pbgK3syvHq9yR2Kwer3YCB+Iiq7l3asjMtHy tuDg6YniSivF3LvBUgng2BsLPcNIvXKWDPdQlWSkceD0ViunrKCYgfh2sPzIWXj9kqOu FJidXFiV/osNo6LULrPOtdPdA8CEe5HFAqsL6bQgNK9XLB7Dk8PGrHYRbWEyYemeUPEc rpJA== X-Gm-Message-State: ABy/qLY08KItzSVufUU4gjDzC39sTCfzV0jOGEyEUXVkhMDizeeoFKCY uTGKvyXPUh4pg3gzIXWPc+Hz124o+q54f3C4rHiHzQ== X-Google-Smtp-Source: APBJJlFKYqCuwEaSLWe4XCyFgTO192avgIhB8a/G7nm8UzEuNR931RRYa9jZq3N7YbmBhw60TpGBCA== X-Received: by 2002:a05:600c:5119:b0:3f4:2736:b5eb with SMTP id o25-20020a05600c511900b003f42736b5ebmr90778wms.1.1688572565343; Wed, 05 Jul 2023 08:56:05 -0700 (PDT) Received: from google.com (44.232.78.34.bc.googleusercontent.com. [34.78.232.44]) by smtp.gmail.com with ESMTPSA id o10-20020a1c750a000000b003fbc2c0addbsm2476633wmc.42.2023.07.05.08.56.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jul 2023 08:56:04 -0700 (PDT) Date: Wed, 5 Jul 2023 15:56:00 +0000 From: Mostafa Saleh To: Sudeep Holla Cc: maz@kernel.org, oliver.upton@linux.dev, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, tabba@google.com, qperret@google.com, will@kernel.org, catalin.marinas@arm.com, yuzenghui@huawei.com, suzuki.poulose@arm.com, james.morse@arm.com, bgardon@google.com, gshan@redhat.com Subject: Re: [PATCH v3] KVM: arm64: Use BTI for nvhe Message-ID: References: <20230530150845.2856828-1-smostafa@google.com> <20230704134136.a5znw4jupt5yp5kg@bogus> <20230704143339.cqrvntq7rmmb2on3@bogus> <20230704192529.d4x2p7ndz2dc4q52@bogus> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230704192529.d4x2p7ndz2dc4q52@bogus> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230705_085607_659261_CCD33DD5 X-CRM114-Status: GOOD ( 52.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgU3VkZWVwLAoKT24gVHVlLCBKdWwgMDQsIDIwMjMgYXQgMDg6MjU6MjlQTSArMDEwMCwgU3Vk ZWVwIEhvbGxhIHdyb3RlOgo+IE9uIFR1ZSwgSnVsIDA0LCAyMDIzIGF0IDA0OjI3OjA0UE0gKzAw MDAsIE1vc3RhZmEgU2FsZWggd3JvdGU6Cj4gPiBIaSBTdWRlZXAsCj4gPiAKPiA+IE9uIFR1ZSwg SnVsIDA0LCAyMDIzIGF0IDAzOjMzOjM5UE0gKzAxMDAsIFN1ZGVlcCBIb2xsYSB3cm90ZToKPiA+ ID4gSGkgTW9zdGFmYSwKPiA+ID4gCj4gPiA+IE9uIFR1ZSwgSnVsIDA0LCAyMDIzIGF0IDAyOjE4 OjA5UE0gKzAwMDAsIE1vc3RhZmEgU2FsZWggd3JvdGU6Cj4gPiA+ID4gSGkgU3VkZWVwLAo+ID4g PiA+IAo+ID4gPiA+IE9uIFR1ZSwgSnVsIDA0LCAyMDIzIGF0IDAyOjQxOjM2UE0gKzAxMDAsIFN1 ZGVlcCBIb2xsYSB3cm90ZToKPiA+ID4gPiA+IE9uIFR1ZSwgTWF5IDMwLCAyMDIzIGF0IDAzOjA4 OjQ1UE0gKzAwMDAsIE1vc3RhZmEgU2FsZWggd3JvdGU6Cj4gPiA+ID4gPiA+IENPTkZJR19BUk02 NF9CVElfS0VSTkVMIGNvbXBpbGVzIHRoZSBrZXJuZWwgdG8gc3VwcG9ydCBBUk12OC41LUJUSS4K PiA+ID4gPiA+ID4gSG93ZXZlciwgdGhlIG52aGUgY29kZSBkb2Vzbid0IG1ha2UgdXNlIG9mIGl0 IGFzIGl0IGRvZXNuJ3QgbWFwIGFueQo+ID4gPiA+ID4gPiBwYWdlcyB3aXRoIEd1YXJkZWQgUGFn ZShHUCkgYml0Lgo+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4ga3ZtIHBndGFibGUgY29kZSBpcyBt b2RpZmllZCB0byBtYXAgZXhlY3V0YWJsZSBwYWdlcyB3aXRoIEdQIGJpdAo+ID4gPiA+ID4gPiBp ZiBCVEkgaXMgZW5hYmxlZCBmb3IgdGhlIGtlcm5lbC4KPiA+ID4gPiA+ID4gCj4gPiA+ID4gPiA+ IEF0IGh5cCBpbml0LCBTQ1RMUl9FTDIuQlQgaXMgc2V0IHRvIDEgdG8gbWF0Y2ggRUwxIGNvbmZp Z3VyYXRpb24KPiA+ID4gPiA+ID4gKFNDVExSX0VMMS5CVDEpIHNldCBpbiBidGlfZW5hYmxlKCku Cj4gPiA+ID4gPiA+IAo+ID4gPiA+ID4gPiBPbmUgZGlmZmVyZW5jZSBiZXR3ZWVuIGtlcm5lbCBh bmQgbnZoZSBjb2RlLCBpcyB0aGF0IHRoZSBrZXJuZWwgbWFwcwo+ID4gPiA+ID4gPiAudGV4dCB3 aXRoIEdQIHdoaWxlIG52aGUgbWFwcyBhbGwgdGhlIGV4ZWN1dGFibGUgcGFnZXMsIHRoaXMgbWFr ZXMKPiA+ID4gPiA+ID4gbnZoZSBjb2RlIG5lZWQgdG8gZGVhbCB3aXRoIHNwZWNpYWwgaW5pdGlh bGl6YXRpb24gY29kZSBjb21pbmcgZnJvbQo+ID4gPiA+ID4gPiBvdGhlciBleGVjdXRhYmxlIHNl Y3Rpb25zICguaWRtYXAudGV4dCkuCj4gPiA+ID4gPiA+IEZvciB0aGlzIHdlIG5lZWQgdG8gYWRk IGJ0aSBpbnN0cnVjdGlvbiBhdCB0aGUgYmVnaW5uaW5nIG9mCj4gPiA+ID4gPiA+IF9fa3ZtX2hh bmRsZV9zdHViX2h2YyBhcyBpdCBjYW4gYmUgY2FsbGVkIGJ5ICBfX2hvc3RfaHZjIHRocm91Z2gK PiA+ID4gPiA+ID4gYnJhbmNoIGluc3RydWN0aW9uKGJyKSBhbmQgdW5saWtlIFNZTV9GVU5DX1NU QVJULCBTWU1fQ09ERV9TVEFSVAo+ID4gPiA+ID4gPiBkb2VzbuKAmXQgYWRkIGJ0aSBpbnN0cnVj dGlvbiBhdCB0aGUgYmVnaW5uaW5nLCBhbmQgaXQgY2Fu4oCZdCBiZSBtb2RpZmllZAo+ID4gPiA+ ID4gPiB0byBhZGQgaXQgYXMgaXQgaXMgdXNlZCB3aXRoIHZlY3RvciB0YWJsZXMuCj4gPiA+ID4g PiA+IEFub3RoZXIgc29sdXRpb24gd2hpY2ggaXMgbW9yZSBpbnRydXNpdmUgaXMgdG8gY29udmVy dAo+ID4gPiA+ID4gPiBfX2t2bV9oYW5kbGVfc3R1Yl9odmMgdG8gYSBmdW5jdGlvbiBhbmQgaW5q ZWN0IOKAnGJ0aSBqY+KAnSBpbnN0ZWFkIG9mCj4gPiA+ID4gPiA+IOKAnGJ0aSBj4oCdIGluIFNZ TV9GVU5DX1NUQVJUCj4gPiA+ID4gPiA+Cj4gPiA+ID4gPiAKPiA+ID4gPiA+IEkgd2FzIGNoYXNp bmcgYSBidWcgaW4gbGludXgtbmV4dCB5ZXN0ZXJkYXkgd2l0aCBwcm90ZWN0ZWQgblZIRShwS1ZN KSBhbmQKPiA+ID4gPiA+IGNwdWlkbGUgZW5hYmxlZC4gVGhlIHN5c3RlbSBmYWlscyB0byBib290 LiBJIGp1c3QgYmlzZWN0ZWQgdGhlIGlzc3VlIHRvIHRoaXMKPiA+ID4gPiA+IHBhdGNoIGFuZCBh bHNvIHNhdyB0aGlzIHBhdGNoIGxhbmRlZCBpbiB0aGUgbGludXMgdHJlZSB5ZXN0ZXJkYXkvdG9k YXkuCj4gPiA+ID4gCj4gPiA+ID4gT25lIG9mIHRoZSBjaGFsbGVuZ2VzIG9mIEJUSSBpcyB0aGF0 IHdlIG5lZWQgdG8gYWRkIGV4cGxpY2l0IEJUSSBpbnN0cnVjdGlvbnMKPiA+ID4gPiBmb3IgYXNz ZW1ibHkgY29kZS4gSSBjaGVja2VkIHRoZSBjb2RlIHRvIG1ha2Ugc3VyZSB0aGF0IG5vdGhpbmcg d2FzIG1pc3NpbmcsCj4gPiA+ID4gYnV0IG1heWJlIHRoaXMgaXMgbm90IHRoZSBjYXNlLgo+ID4g PiA+IENhbiB5b3UgcGxlYXNlIHNoYXJlIG1vcmUgYWJvdXQgdGhlIGlzc3VlIChpcyBFU1IgYSBC cmFuY2ggVGFyZ2V0IEV4Y2VwdGlvbiwKPiA+ID4gPiBjYWxsIHN0YWNrLi4uKSBpZiBwb3NzaWJs ZS4KPiA+ID4gCj4gPiA+IEkgaGF2ZW4ndCBkZWJ1Z2dlZCBpdCBhbnkgZnVydGhlciwganVzdCBy ZXBvcnRlZCBpdCBhcyBzb29uIGFzIEkgYmlzZWN0ZWQgaXQuCj4gPiA+IFJldmVydGluZyB0aGlz IGdldCBiYWNrIHRoZSBib290aW5nIHN5c3RlbS4gSSBhbSBub3Qgc3VyZSBpZiBhbnl0aGluZyBp cyBnb2luZwo+ID4gPiB3cm9uZyB3aGVuIHRoZSBDUFUgaXMgZW50ZXJpbmcgc3VzcGVuZChoaWdo bHkgdW5saWtlbHkgaW4gbm9ybWFsIHNjZW5hcmlvIGJ1dAo+ID4gPiBJIGFtIG5vdCBzbyBzdXJl IHdpdGggcEtWTSB0cmFwcGluZyB0aGVzZSBQU0NJIGNhbGxzIG5vdykgb3Igd2hlbiBpdCBpcyB3 b2tlbgo+ID4gPiB1cCBhbmQgcmVzdW1pbmcgYmFjay4gSUlVQyB0aGlzIG5vdyB3aWxsIGhhcHBl biB2aWEga3ZtX2h5cF9jcHVfcmVzdW1lLT4KPiA+ID4gX19rdm1faHlwX2luaXRfY3B1LT5fX19r dm1faHlwX2luaXQuIAo+ID4gCj4gPiBUaGFua3MgYSBsb3QgZm9yIHRoZSBpbmZvcm1hdGlvbi4K PiA+IAo+ID4gSSBjaGVja2VkIHRoaXMgbm93LCBhbmQgSSBiZWxpZXZlIEkgZm91bmQgYW4gaXNz dWUuIEkgc2VlIHRoYXQgX19rdm1faHlwX2luaXRfY3B1Cj4gPiBjYWxscyBrdm1faG9zdF9wc2Np X2NwdV9lbnRyeSBpbmRpcmVjdGx5IGFuZCB0aGVyZSBpcyBubyBCVEkgdGhlcmUuCj4gPiBJIHRo aW5rIHRoaXMgaXMgdGhlIG9ubHkgQyBmdW5jdGlvbiB0aGF0IG5lZWRzIHNwZWNpYWwgaGFuZGxp bmcuCj4gPgo+IAo+IFNvIGl0IGlzIGluIHRoZSB3YWtlIHVwIHBhdGguIFRoYW5rcyBmb3IgdGhl IGRlc2NyaXB0aW9uLCBub3cgSSB1bmRlcnN0YW5kCj4gdGhlIGlzc3VlIGFuZCBmaXggYmV0dGVy Lgo+IAo+ID4gQ2FuIHlvdSBwbGVhc2UgY2hlY2sgaWYgdGhpcyBzb2x2ZXMgdGhlIGlzc3VlPwo+ ID4KPiAKPiBZZXMsIHRoZSBiZWxvdyBwYXRjaCBmaXhlZCB0aGUgaXNzdWUuIEZlZWwgZnJlZSB0 byBhZGQgd2hlbiB5b3UgcG9zdCB0aGUKPiBmb3JtYWwgcGF0Y2guCj4gCj4gUmVwb3J0ZWQtYW5k LVRlc3RlZC1ieTogU3VkZWVwIEhvbGxhIDxzdWRlZXAuaG9sbGFAYXJtLmNvbT4KClRoYW5rcyBm b3IgdGVzdGluZyB0aGUgcGF0Y2gsIEkgd2lsbCBwb3N0IGl0IG9uIHRoZSBsaXN0LgoKPiA+IGRp ZmYgLS1naXQgYS9hcmNoL2FybTY0L2t2bS9oeXAvbnZoZS9ob3N0LlMgYi9hcmNoL2FybTY0L2t2 bS9oeXAvbnZoZS9ob3N0LlMKPiA+IGluZGV4IGM4N2M2MzEzM2UxMC4uN2RmNjNmMzY0YzNjIDEw MDY0NAo+ID4gLS0tIGEvYXJjaC9hcm02NC9rdm0vaHlwL252aGUvaG9zdC5TCj4gPiArKysgYi9h cmNoL2FybTY0L2t2bS9oeXAvbnZoZS9ob3N0LlMKPiA+IEBAIC0yOTcsMyArMjk3LDggQEAgU1lN X0NPREVfU1RBUlQoX19rdm1faHlwX2hvc3RfZm9yd2FyZF9zbWMpCj4gPiAgCj4gPiAgICAgICAg IHJldAo+ID4gIFNZTV9DT0RFX0VORChfX2t2bV9oeXBfaG9zdF9mb3J3YXJkX3NtYykKPiA+ICsK PiA+ICtTWU1fQ09ERV9TVEFSVChrdm1faG9zdF9wc2NpX2NwdV9lbnRyeSkKPiA+ICsgICAgICAg YnRpIGoKPiA+ICsgICAgICAgYiBfX2t2bV9ob3N0X3BzY2lfY3B1X2VudHJ5Cj4gPiArU1lNX0NP REVfRU5EKGt2bV9ob3N0X3BzY2lfY3B1X2VudHJ5KQo+ID4gZGlmZiAtLWdpdCBhL2FyY2gvYXJt NjQva3ZtL2h5cC9udmhlL3BzY2ktcmVsYXkuYyBiL2FyY2gvYXJtNjQva3ZtL2h5cC9udmhlL3Bz Y2ktcmVsYXkuYwo+ID4gaW5kZXggMDg1MDg3ODNlYzNkLi4yNDU0M2QyYTM0OTAgMTAwNjQ0Cj4g PiAtLS0gYS9hcmNoL2FybTY0L2t2bS9oeXAvbnZoZS9wc2NpLXJlbGF5LmMKPiA+ICsrKyBiL2Fy Y2gvYXJtNjQva3ZtL2h5cC9udmhlL3BzY2ktcmVsYXkuYwo+ID4gQEAgLTIwMCw3ICsyMDAsNyBA QCBzdGF0aWMgaW50IHBzY2lfc3lzdGVtX3N1c3BlbmQodTY0IGZ1bmNfaWQsIHN0cnVjdCBrdm1f Y3B1X2NvbnRleHQgKmhvc3RfY3R4dCkKPiA+ICAgICAgICAgICAgICAgICAgICAgICAgICBfX2h5 cF9wYShpbml0X3BhcmFtcyksIDApOwo+ID4gIH0KPiA+ICAKPiA+IC1hc21saW5rYWdlIHZvaWQg X19ub3JldHVybiBrdm1faG9zdF9wc2NpX2NwdV9lbnRyeShib29sIGlzX2NwdV9vbikKPiA+ICth c21saW5rYWdlIHZvaWQgX19ub3JldHVybiBfX2t2bV9ob3N0X3BzY2lfY3B1X2VudHJ5KGJvb2wg aXNfY3B1X29uKQo+ID4gIHsKPiA+ICAgICAgICAgc3RydWN0IHBzY2lfYm9vdF9hcmdzICpib290 X2FyZ3M7Cj4gPiAgICAgICAgIHN0cnVjdCBrdm1fY3B1X2NvbnRleHQgKmhvc3RfY3R4dDsKPiA+ IAo+ID4gCj4gPiA+ID4gQWxzbywgaXMgdGhpcyB3aXRoIENPTkZJR19BUk1fUFNDSV9DUFVJRExF Pwo+ID4gPiAKPiA+ID4gWWVzLCBiYXNpY2FsbHkgdGhlIGNwdXMgY2FuIGVudGVyIGNwdV9zdXNw ZW5kIHdoaWNoIElJVUMgcEtWTSB0cmFwcyBhbmQKPiA+ID4gaGFuZGxlIGZvciB0aGUgaG9zdC4K PiA+IAo+ID4gTXkgY3VycmVudCBzZXR1cCBoYXMgbm8gQ09ORklHX0FSTV9QU0NJX0NQVUlETEU/ LCBJIHdpbGwgdHJ5IHRvIGZpbmQKPiA+IHNvbWV0aGluZyBJIGNhbiB0ZXN0IHdpdGguCj4gPgo+ IAo+IE5vIHdvcnJpZXMsIEkgY2FuIGhlbHAgdW50aWwgeW91IGZpbmQgb25lLgo+IAo+IAo+ID4g PiA+IAo+ID4gPiA+ID4gTm90IHN1cmUgaWYgdGhpcyBpcyBzb21ldGhpbmcgdG8gZG8gd2l0aCB0 aGUgZmFjdCB0aGF0IHBLVk0gc2tpcHMgdG8KPiA+ID4gPiA+IF9fa3ZtX2hhbmRsZV9zdHViX2h2 YyBpbiBfX2hvc3RfaHZjLgo+ID4gPiAKPiA+ID4gU29ycnksIG15IGJhZC4gSSBtZWFudCBwS1ZN IHNraXBzIGNhbGxpbmcgX19rdm1faGFuZGxlX3N0dWJfaHZjIGluIF9faG9zdF9odmMKPiA+ID4g YW5kIGp1bXBzIHRvIF9faG9zdF9leGl0IGRpcmVjdGx5LiBTb3JyeSBmb3IgdGhhdCwgb25lIHdy b25nICJ0byIgY2hhbmdlZCB0aGUKPiA+ID4gd2hvbGUgbWVhbmluZy4KPiA+IAo+ID4gSSBkb24n dCBzZWUgYW4gaXNzdWUgaW4gdGhpcywgYXMgdGhpcyBwYXRoIGhhcyBubyBpbmRpcmVjdCBicmFu Y2hlcy4KPiA+Cj4gCj4gVW5kZXJzdG9vZC4KClRoYW5rcywKTW9zdGFmYQoKCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFp bGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlz dHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK