From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6CB9EB64DA for ; Wed, 5 Jul 2023 22:56:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231833AbjGEW4y (ORCPT ); Wed, 5 Jul 2023 18:56:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60828 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229772AbjGEW4y (ORCPT ); Wed, 5 Jul 2023 18:56:54 -0400 Received: from mail.netfilter.org (mail.netfilter.org [217.70.188.207]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id D220CF7; Wed, 5 Jul 2023 15:56:53 -0700 (PDT) Date: Thu, 6 Jul 2023 00:56:50 +0200 From: Pablo Neira Ayuso To: Thadeu Lima de Souza Cascardo Cc: netfilter-devel@vger.kernel.org, netdev@vger.kernel.org, Florian Westphal Subject: Re: [PATCH v2] netfilter: nf_tables: prevent OOB access in nft_byteorder_eval Message-ID: References: <20230705201232.GG3751@breakpoint.cc> <20230705210535.943194-1-cascardo@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230705210535.943194-1-cascardo@canonical.com> Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Wed, Jul 05, 2023 at 06:05:35PM -0300, Thadeu Lima de Souza Cascardo wrote: > When evaluating byteorder expressions with size 2, a union with 32-bit and > 16-bit members is used. Since the 16-bit members are aligned to 32-bit, > the array accesses will be out-of-bounds. Applied to nf, thanks