From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: Randy Dunlap <rdunlap@infradead.org>,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH RESEND] input: cpcap-pwrbutton: remove initial kernel-doc notation
Date: Wed, 5 Jul 2023 14:51:50 -0700 [thread overview]
Message-ID: <ZKXl9up6n255YOFW@google.com> (raw)
In-Reply-To: <20230705212845.w2yhqb75fqx6psim@mercury.elektranox.org>
On Wed, Jul 05, 2023 at 11:28:45PM +0200, Sebastian Reichel wrote:
> Hi,
>
> On Wed, Jul 05, 2023 at 12:28:50PM -0700, Dmitry Torokhov wrote:
> > On Tue, Jul 04, 2023 at 02:08:21AM +0200, Sebastian Reichel wrote:
> > > Hi,
> > >
> > > On Mon, Jul 03, 2023 at 04:00:05PM -0700, Randy Dunlap wrote:
> > > > Change the beginning "/**" in the file to "/*" since it is not a
> > > > kernel-doc comment. This prevents a kernel-doc warning:
> > > >
> > > > drivers/input/misc/cpcap-pwrbutton.c:2: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
> > > > * CPCAP Power Button Input Driver
> > > >
> > > > Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> > > > Cc: Sebastian Reichel <sre@kernel.org>
> > > > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > > > Cc: linux-input@vger.kernel.org
> > > > ---
> > >
> > > Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> >
> > Applied, thank you.
> >
> > BTW, the driver is missing SPDX annotation, Sebastian I wonder if you
> > could send a patch addressing this (given you are the author it is
> > better coming from you).
>
> DONE: https://lore.kernel.org/all/20230705212231.631525-1-sre@kernel.org/
Thank you, much appreciated.
--
Dmitry
prev parent reply other threads:[~2023-07-05 21:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-03 23:00 [PATCH RESEND] input: cpcap-pwrbutton: remove initial kernel-doc notation Randy Dunlap
2023-07-04 0:08 ` Sebastian Reichel
2023-07-05 19:28 ` Dmitry Torokhov
2023-07-05 21:28 ` Sebastian Reichel
2023-07-05 21:51 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZKXl9up6n255YOFW@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=sebastian.reichel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.