From: Peter Xu <peterx@redhat.com>
To: Avihai Horon <avihaih@nvidia.com>
Cc: qemu-devel@nongnu.org, "Eric Blake" <eblake@redhat.com>,
"Laszlo Ersek" <lersek@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"Daniel P . Berrangé" <berrange@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Juan Quintela" <quintela@redhat.com>,
"Leonardo Bras Soares Passos" <lsoaresp@redhat.com>,
"Laurent Vivier" <lvivier@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [PATCH v4 1/2] migration: switchover-hold parameter
Date: Thu, 6 Jul 2023 08:27:28 -0400 [thread overview]
Message-ID: <ZKazMNVa7nnwjneB@x1n> (raw)
In-Reply-To: <0ed812a4-3fb9-3bb6-6153-c1a1fc6e72d4@nvidia.com>
On Thu, Jul 06, 2023 at 11:40:04AM +0300, Avihai Horon wrote:
> This only handles the QMP case, but we forgot to handle the HMP case.
> I was testing it and got the following assert:
>
> (qemu) migrate_set_parameter switchover-hold on
> qemu-system-x86_64: ../migration/migration-hmp-cmds.c:627:
> hmp_migrate_set_parameter: Assertion `0' failed.
> Aborted (core dumped)
Ouch.. I'll fix it, thanks.
--
Peter Xu
next prev parent reply other threads:[~2023-07-06 12:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-05 16:31 [PATCH v4 0/2] migration: switchover-hold flag Peter Xu
2023-07-05 16:31 ` [PATCH v4 1/2] migration: switchover-hold parameter Peter Xu
2023-07-06 8:40 ` Avihai Horon
2023-07-06 12:27 ` Peter Xu [this message]
2023-07-05 16:31 ` [PATCH v4 2/2] qtest/migration: Use switchover-hold to speedup Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZKazMNVa7nnwjneB@x1n \
--to=peterx@redhat.com \
--cc=armbru@redhat.com \
--cc=avihaih@nvidia.com \
--cc=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=lersek@redhat.com \
--cc=lsoaresp@redhat.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.