From: Christoph Hellwig <hch@infradead.org>
To: Josef Bacik <josef@toxicpanda.com>
Cc: linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH 2/2] btrfs-progs: set the proper minimum size for a zoned file system
Date: Thu, 6 Jul 2023 07:31:41 -0700 [thread overview]
Message-ID: <ZKbQTd+EJf6wS6Sn@infradead.org> (raw)
In-Reply-To: <5e89618345f65a3aa4f89c4b7894d28767ea8c42.1688648758.git.josef@toxicpanda.com>
On Thu, Jul 06, 2023 at 09:06:57AM -0400, Josef Bacik wrote:
> + if (opt_zoned && block_count && block_count < 7 * zone_size(file)) {
> error("size %llu is too small to make a usable filesystem",
> block_count);
> error("minimum size for a zoned btrfs filesystem is %llu",
> - 5 * zone_size(file));
> + 7 * zone_size(file));
Wouldn't it be useful to have a helper for this? Yes, open coding it
only twice and right next to each other is probably ok, but I fear
we'll grow more uses. And a helper is a really nice way to document
the details anyway.
prev parent reply other threads:[~2023-07-06 14:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-06 13:06 [PATCH 0/2] btrfs-progs: some zoned mkfs fixups Josef Bacik
2023-07-06 13:06 ` [PATCH 1/2] btrfs-progs: print out the correct minimum size for zoned file systems Josef Bacik
2023-07-06 14:30 ` Christoph Hellwig
2023-07-06 13:06 ` [PATCH 2/2] btrfs-progs: set the proper minimum size for a zoned file system Josef Bacik
2023-07-06 14:31 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZKbQTd+EJf6wS6Sn@infradead.org \
--to=hch@infradead.org \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.