From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Yangtao Li <frank.li@vivo.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 08/10] Input: nomadik-ske-keypad - Convert to use devm_* api
Date: Mon, 10 Jul 2023 17:42:49 -0700 [thread overview]
Message-ID: <ZKyliRefKiualqO1@google.com> (raw)
In-Reply-To: <20230705052346.39337-8-frank.li@vivo.com>
Hi,
On Wed, Jul 05, 2023 at 01:23:44PM +0800, Yangtao Li wrote:
> @@ -305,7 +288,7 @@ static int __init ske_keypad_probe(struct platform_device *pdev)
> error = clk_prepare_enable(keypad->pclk);
> if (error) {
> dev_err(&pdev->dev, "Failed to prepare/enable pclk\n");
> - goto err_clk;
> + return error;
> }
>
> error = clk_prepare_enable(keypad->clk);
We should not mix managed (devm) and normal resources, because doing so
wrecks the order of resource unwinding. Lucklily we have
devm_clk_get_enabled() now, so I switched the driver to use it and
applied the patch.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2023-07-11 0:42 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-05 5:23 [PATCH 01/10] Input: bcm-keypad - Convert to devm_platform_ioremap_resource() Yangtao Li
2023-07-05 5:23 ` [PATCH 02/10] Input: lpc32xx-keys " Yangtao Li
2023-07-05 5:23 ` Yangtao Li
2023-07-05 5:23 ` [PATCH 03/10] Input: nspire-keypad - Use devm_platform_get_and_ioremap_resource() Yangtao Li
2023-07-05 5:23 ` [PATCH 04/10] Input: omap4-keyad - Convert to devm_platform_ioremap_resource() Yangtao Li
2023-07-05 5:23 ` [PATCH 05/10] Input: opencores-kbd " Yangtao Li
2023-07-05 5:23 ` [PATCH 06/10] Input: pxa27x_keypad " Yangtao Li
2023-07-05 5:23 ` [PATCH 07/10] Input: sun4i-lradc-keys " Yangtao Li
2023-07-05 5:23 ` Yangtao Li
2023-07-11 18:27 ` Jernej Škrabec
2023-07-11 18:27 ` Jernej Škrabec
2023-07-05 5:23 ` [PATCH 08/10] Input: nomadik-ske-keypad - Convert to use devm_* api Yangtao Li
2023-07-11 0:42 ` Dmitry Torokhov [this message]
2023-07-05 5:23 ` [PATCH 09/10] Input: lpc32xx_ts - stop_tsc when driver remove Yangtao Li
2023-07-05 5:23 ` Yangtao Li
2023-07-11 0:40 ` Dmitry Torokhov
2023-07-11 0:40 ` Dmitry Torokhov
2023-07-05 5:23 ` [PATCH 10/10] Input: lpc32xx_ts - Convert to use devm_* api Yangtao Li
2023-07-05 5:23 ` Yangtao Li
2023-07-11 0:43 ` [PATCH 01/10] Input: bcm-keypad - Convert to devm_platform_ioremap_resource() Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZKyliRefKiualqO1@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=frank.li@vivo.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.