From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1qJ49p-0000kr-Sb for mharc-grub-devel@gnu.org; Mon, 10 Jul 2023 23:35:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qJ49g-0000hc-Cd for grub-devel@gnu.org; Mon, 10 Jul 2023 23:35:13 -0400 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qJ49c-0006k4-Sb for grub-devel@gnu.org; Mon, 10 Jul 2023 23:35:12 -0400 Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-31441bc0092so5131759f8f.1 for ; Mon, 10 Jul 2023 20:35:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689046505; x=1691638505; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=r8lypEc5PpW7eTBMF/dd3nwqMgherEk/nAapZNdwCGM=; b=qjxCRdEVWo8GnIGGXNGmVMxWHLJ9OlxpZMElZZk3yYiBBkU9cnCI7cNfn5FMMQg5XJ YLbLfh1c/Spl/N4EkipW/4lTmRO0GlpZoXCHBbsZlZ4ZWQz7K0nECqfQifxvWZyurAy8 GJ0xrSBb5J6r7wygLL+YsD+hbxrSaX5ihlWeYOMzLz6HRpL02KKp8c27JgWS/oj4Vsbw H4RKimEH5ogeH9iFq7eBTPeXBalhryJDYGnm5nGG2hT/Ym+M3oop9Gz4EFb7MgmiWk2r kMrfiiJkwEIoXWzmo3IhnSjkNQL6aR0qNFEokHbIiOXTVEwmsRx0InJ2+oJNcvAn+dCo nYFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689046505; x=1691638505; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=r8lypEc5PpW7eTBMF/dd3nwqMgherEk/nAapZNdwCGM=; b=DbTNv/CRptkEMG58p1213GqoPYcHnCEz6stqtN+8x6r8KmUs3X8NHk+RB62xwLssiw YZ/vY5TJG2StPzxolYyw8DIeUwnqJYQ3FS9sLdQknFp1PQI3Ewjj/oY9EOjbBoNQwgrD 8ySpoksZjkjDvcJFbhD7fl7Bjh9los39h8KMemhVOchzQsBycyxwRmdRk+X7oOFhQSiI rtpEEPYmw1HuQOWNyX8HVMCHupBPc3AWsRs01aJl28hGvsPvxhlJ9FlSTRX5/QhTrVRy FxvsAMn23apyEqw4prihKvjNRRdDoc+AiOuH6NAYyT+Z0z8sJqRU7xi+FcC1ZrlUv9u0 3P8Q== X-Gm-Message-State: ABy/qLZOJuKFNyaajgy/ZRIjC6lWzEt25GorVsPtRyXCzsInR4VA670V cgIwnIySOT7xHSzb01Dpg+kaSy1Cvls= X-Google-Smtp-Source: APBJJlHSl3EzSHwTee4SICXSGaz5+vI/rve1+lL0uZsvMcfgweXAm7XMrk7MWlEBhNe06AFH04S59g== X-Received: by 2002:adf:d08a:0:b0:314:f18:bc66 with SMTP id y10-20020adfd08a000000b003140f18bc66mr12235348wrh.68.1689046504491; Mon, 10 Jul 2023 20:35:04 -0700 (PDT) Received: from dj3ntoo (140.sub-75-226-201.myvzw.com. [75.226.201.140]) by smtp.gmail.com with ESMTPSA id t16-20020a5d49d0000000b003143bb5ecd5sm985355wrs.69.2023.07.10.20.35.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Jul 2023 20:35:03 -0700 (PDT) Date: Mon, 10 Jul 2023 22:34:58 -0500 From: Oskari Pirhonen To: Glenn Washburn Cc: grub-devel@gnu.org, Daniel Kiper Subject: Re: [PATCH v3] docs: Add missing assumption Message-ID: Mail-Followup-To: Glenn Washburn , grub-devel@gnu.org, Daniel Kiper References: <20230710171448.1450168-1-development@efficientek.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="90RYy2tk49XjcdF0" Content-Disposition: inline In-Reply-To: <20230710171448.1450168-1-development@efficientek.com> Received-SPF: pass client-ip=2a00:1450:4864:20::42a; envelope-from=xxc3ncoredxx@gmail.com; helo=mail-wr1-x42a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Jul 2023 03:35:14 -0000 --90RYy2tk49XjcdF0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jul 10, 2023 at 12:14:48 -0500, Glenn Washburn wrote: > Also reword a prior sentence to be more clear. >=20 > Fixes: 5a3d2b4742df (docs: Add debugging chapter to development documenta= tion) > Signed-off-by: Glenn Washburn > --- > v3: Fix rebase merge error (scripts -> script) > v2: rebase > --- > docs/grub-dev.texi | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) >=20 > diff --git a/docs/grub-dev.texi b/docs/grub-dev.texi > index 0834ca562ad6..f7c944dc9e20 100644 > --- a/docs/grub-dev.texi > +++ b/docs/grub-dev.texi > @@ -660,10 +660,11 @@ GDB is started from the @file{grub-core} directory = in the GRUB2 build > directory. GRUB2 developers have made this more simple by including a GDB > script which does much of the setup. This file is at @file{grub-core/gdb= _grub} > in the build directory and is also installed via @command{make install}. > -If not building GRUB, the distribution may have a package which installs > +When using a pre-built GRUB, the distribution may have a package which i= nstalls > this GDB script along with debug symbol binaries, such as Debian's > -@samp{grub-pc-dbg} package. The GDB script is intended to be used > -like so, assuming: > +@samp{grub-pc-dbg} package. The GDB script is intended to by used Aw man, it seems to have picked up the original "by" which was changed to "be". Looking back at v2 it was there as well, but I only commented on the "script/scripts" portion. My bad on that. Thanks for putting up with all these tiny changes. I've made sure to read over it multiple times. The next one should be the final one. - Oskari > +like so, assuming that @samp{/path/to/script} is the path to the directo= ry > +containing the gdb_grub script and debug symbol files: > =20 > @example > cd $(dirname /path/to/script/gdb_grub) > --=20 > 2.34.1 >=20 --90RYy2tk49XjcdF0 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQQfOU+JeXjo4uxN6vCp8he9GGIfEQUCZKzN3QAKCRCp8he9GGIf Ef+dAPwPBW9Tg0kxXw1dUE3ZRVtLIp98uJaF7b+OhrUEjPkTBwEAz3wmcjVHBvRZ 0IZxhza8yZI5wysmVdCEnd5IBbG85Ag= =3sRj -----END PGP SIGNATURE----- --90RYy2tk49XjcdF0--