From: Sean Christopherson <seanjc@google.com>
To: Yi Wang <up2wing@gmail.com>
Cc: pbonzini@redhat.com, tglx@linutronix.de, mingo@redhat.com,
bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
wanpengli@tencent.com, Yi Wang <foxywang@tencent.com>
Subject: Re: [PATCH] kvm: vmx: fix a trivial comment in vmx_vcpu_after_set_cpuid()
Date: Tue, 25 Jul 2023 07:52:06 -0700 [thread overview]
Message-ID: <ZL/hlrWFzrtcdcmH@google.com> (raw)
In-Reply-To: <20230725100844.3416164-1-foxywang@tencent.com>
On Tue, Jul 25, 2023, Yi Wang wrote:
> The commit b6247686b7571 ("KVM: VMX: Drop caching of KVM's desired
> sec exec controls for vmcs01") renamed vmx_compute_secondary_exec_control()
> to vmx_secondary_exec_control(), but forgot to modify the comment.
>
> Signed-off-by: Yi Wang <foxywang@tencent.com>
> ---
> arch/x86/kvm/vmx/vmx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c
> index 0ecf4be2c6af..26d62990fea7 100644
> --- a/arch/x86/kvm/vmx/vmx.c
> +++ b/arch/x86/kvm/vmx/vmx.c
> @@ -7722,7 +7722,7 @@ static void vmx_vcpu_after_set_cpuid(struct kvm_vcpu *vcpu)
> {
> struct vcpu_vmx *vmx = to_vmx(vcpu);
>
> - /* xsaves_enabled is recomputed in vmx_compute_secondary_exec_control(). */
> + /* xsaves_enabled is recomputed in vmx_secondary_exec_control(). */
> vcpu->arch.xsaves_enabled = false;
I have an in-progress patch[*] that reworks this code and wipes out the stale
comment as a side effect. Thank you though!
[*] https://lore.kernel.org/all/20230217231022.816138-4-seanjc@google.com
prev parent reply other threads:[~2023-07-25 14:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-25 10:08 [PATCH] kvm: vmx: fix a trivial comment in vmx_vcpu_after_set_cpuid() Yi Wang
2023-07-25 14:52 ` Sean Christopherson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZL/hlrWFzrtcdcmH@google.com \
--to=seanjc@google.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=foxywang@tencent.com \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=tglx@linutronix.de \
--cc=up2wing@gmail.com \
--cc=wanpengli@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.