From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Tony Lindgren <tony@atomide.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Dhruva Gole" <d-gole@ti.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"John Ogness" <john.ogness@linutronix.de>,
"Johan Hovold" <johan@kernel.org>,
"Sebastian Andrzej Siewior" <bigeasy@linutronix.de>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH v4 3/3] serial: core: Fix serial core controller port name to show controller id
Date: Mon, 24 Jul 2023 11:55:53 +0300 [thread overview]
Message-ID: <ZL48mdJbBXPdcf25@smile.fi.intel.com> (raw)
In-Reply-To: <20230724050709.17544-4-tony@atomide.com>
On Mon, Jul 24, 2023 at 08:07:05AM +0300, Tony Lindgren wrote:
> We are missing the serial core controller id for the serial core port
> name. Let's fix the issue for sane /sys/bus/serial-core/devices, and to
> avoid issues addressing serial ports later on.
...
> - return dev_set_name(dev, "%s.%s.%d", type->name, dev_name(port->dev), id);
> -}
> + if (type == &serial_ctrl_type)
...
> +}
While at it, have you tried to use --patience when forming patches? Does it
make any (better) difference?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-07-24 8:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-24 5:07 [PATCH v4 0/3] Serial core controller port device name fixes Tony Lindgren
2023-07-24 5:07 ` [PATCH v4 1/3] serial: core: Controller id cannot be negative Tony Lindgren
2023-07-24 8:52 ` Andy Shevchenko
2023-07-24 8:53 ` Andy Shevchenko
2023-07-24 5:07 ` [PATCH v4 2/3] serial: core: Fix serial core port id to not use port->line Tony Lindgren
2023-07-24 5:07 ` [PATCH v4 3/3] serial: core: Fix serial core controller port name to show controller id Tony Lindgren
2023-07-24 8:55 ` Andy Shevchenko [this message]
2023-07-24 9:06 ` Jiri Slaby
2023-07-24 9:08 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZL48mdJbBXPdcf25@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bigeasy@linutronix.de \
--cc=d-gole@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=johan@kernel.org \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=tony@atomide.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.