From: Simon Horman <simon.horman@corigine.com>
To: Vignesh Viswanathan <quic_viswanat@quicinc.com>
Cc: mani@kernel.org, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com,
linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, quic_srichara@quicinc.com,
quic_clew@quicinc.com
Subject: Re: [PATCH net-next 2/3] net: qrtr: ns: Change nodes radix tree to xarray
Date: Thu, 13 Jul 2023 15:55:14 +0100 [thread overview]
Message-ID: <ZLAQUhAw4yqEW6Y6@corigine.com> (raw)
In-Reply-To: <20230712112631.3461793-3-quic_viswanat@quicinc.com>
On Wed, Jul 12, 2023 at 04:56:30PM +0530, Vignesh Viswanathan wrote:
> There is a use after free scenario while iterating through the nodes
> radix tree despite the ns being a single threaded process. This can
> happen when the radix tree APIs are not synchronized with the
> rcu_read_lock() APIs.
>
> Convert the radix tree for nodes to xarray to take advantage of the
> built in rcu lock usage provided by xarray.
>
> Signed-off-by: Chris Lew <quic_clew@quicinc.com>
> Signed-off-by: Vignesh Viswanathan <quic_viswanat@quicinc.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
next prev parent reply other threads:[~2023-07-13 14:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-12 11:26 [PATCH net-next 0/3] net: qrtr: Few fixes in QRTR Vignesh Viswanathan
2023-07-12 11:26 ` [PATCH net-next 1/3] net: qrtr: ns: Change servers radix tree to xarray Vignesh Viswanathan
2023-07-13 14:54 ` Simon Horman
2023-07-14 5:48 ` Vignesh Viswanathan
2023-07-12 11:26 ` [PATCH net-next 2/3] net: qrtr: ns: Change nodes " Vignesh Viswanathan
2023-07-13 14:55 ` Simon Horman [this message]
2023-07-12 11:26 ` [PATCH net-next 3/3] net: qrtr: Handle IPCR control port format of older targets Vignesh Viswanathan
2023-07-13 14:56 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZLAQUhAw4yqEW6Y6@corigine.com \
--to=simon.horman@corigine.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mani@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=quic_clew@quicinc.com \
--cc=quic_srichara@quicinc.com \
--cc=quic_viswanat@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.