From: Thierry Reding <thierry.reding@gmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Sameer Pujar <spujar@nvidia.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Jonathan Hunter <jonathanh@nvidia.com>,
devicetree@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFT PATCH 1/2] arm64: tegra: correct audio-codec interrupt flag in P2972-0000
Date: Thu, 13 Jul 2023 17:23:16 +0200 [thread overview]
Message-ID: <ZLAW5MbvvNDI5xVG@orome> (raw)
In-Reply-To: <20230705064903.12690-1-krzysztof.kozlowski@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 1441 bytes --]
On Wed, Jul 05, 2023 at 08:49:02AM +0200, Krzysztof Kozlowski wrote:
> GPIO_ACTIVE_x flags are not correct in the context of interrupt flags.
> These are simple defines so they could be used in DTS but they will not
> have the same meaning: GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE.
>
> Correct the interrupt flags to a value used also in Tegra30 Beaver board
> with this device.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> arch/arm64/boot/dts/nvidia/tegra194-p2972-0000.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Sameer,
I can help test this if you're busy, but I don't know how to test
whether this work correctly. Can you share how we can validate this?
Thierry
>
> diff --git a/arch/arm64/boot/dts/nvidia/tegra194-p2972-0000.dts b/arch/arm64/boot/dts/nvidia/tegra194-p2972-0000.dts
> index 64a3398fe7a6..7c400e024332 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra194-p2972-0000.dts
> +++ b/arch/arm64/boot/dts/nvidia/tegra194-p2972-0000.dts
> @@ -2115,7 +2115,7 @@ rt5658: audio-codec@1a {
> compatible = "realtek,rt5658";
> reg = <0x1a>;
> interrupt-parent = <&gpio>;
> - interrupts = <TEGRA194_MAIN_GPIO(S, 5) GPIO_ACTIVE_HIGH>;
> + interrupts = <TEGRA194_MAIN_GPIO(S, 5) IRQ_TYPE_EDGE_FALLING>;
> clocks = <&bpmp TEGRA194_CLK_AUD_MCLK>;
> clock-names = "mclk";
> realtek,jd-src = <2>;
> --
> 2.34.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2023-07-13 15:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-05 6:49 [RFT PATCH 1/2] arm64: tegra: correct audio-codec interrupt flag in P2972-0000 Krzysztof Kozlowski
2023-07-05 6:49 ` [RFT PATCH 2/2] arm64: tegra: correct audio-codec interrupt flag in P3737-0000 Krzysztof Kozlowski
2023-07-13 15:23 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZLAW5MbvvNDI5xVG@orome \
--to=thierry.reding@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=spujar@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.