From: Jeff LaBundy <jeff@labundy.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org
Subject: Re: [PATCH] Input: iqs7211 - point to match data directly
Date: Thu, 13 Jul 2023 12:13:58 -0500 [thread overview]
Message-ID: <ZLAw1i0LzaEFf3DN@nixie71> (raw)
In-Reply-To: <ZLAtlfhUMXKRzdoE@google.com>
Hi Dmitry,
On Thu, Jul 13, 2023 at 10:00:05AM -0700, Dmitry Torokhov wrote:
> Hi Jeff,
>
> On Thu, Jul 13, 2023 at 11:06:46AM -0500, Jeff LaBundy wrote:
> > @@ -2460,13 +2451,11 @@ static int iqs7211_probe(struct i2c_client *client)
> >
> > INIT_LIST_HEAD(&iqs7211->reg_field_head);
> >
> > - if (client->dev.of_node)
> > - dev_id = (enum iqs7211_dev_id)of_device_get_match_data(&client->dev);
> > - else
> > - dev_id = i2c_match_id(iqs7211_id, client)->driver_data;
> > + iqs7211->dev_desc = of_device_get_match_data(&client->dev);
>
> Can we make it device_get_match_data() instead of using OF-specific
> variant?
Ah yes, good catch; I'll fix that.
>
> Thanks.
>
> --
> Dmitry
Kind regards,
Jeff LaBundy
prev parent reply other threads:[~2023-07-13 17:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-13 16:06 [PATCH] Input: iqs7211 - point to match data directly Jeff LaBundy
2023-07-13 17:00 ` Dmitry Torokhov
2023-07-13 17:13 ` Jeff LaBundy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZLAw1i0LzaEFf3DN@nixie71 \
--to=jeff@labundy.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.