From: Nam Cao <namcaov@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org,
syzbot+cf71097ffb6755df8251@syzkaller.appspotmail.com,
stable@vger.kernel.org
Subject: Re: [PATCH] staging: 7811: Fix memory leak in _r8712_init_xmit_priv
Date: Thu, 13 Jul 2023 22:10:35 +0200 [thread overview]
Message-ID: <ZLBaO2/p32h0enDT@nam-dell> (raw)
In-Reply-To: <b684a76e-7d22-fece-5358-f459e4a979ff@lwfinger.net>
On Thu, Jul 13, 2023 at 01:51:00PM -0500, Larry Finger wrote:
> On 7/13/23 12:35, Your Name wrote:
> > The allocation was done in a loop. Shouldn't memory from previous loop iterations
> > also be freed? And allocation by r8712_xmit_resource_alloc() should be freed too.
>
> Nam,
>
> You are right on both counts. I will prepare version 2.
>
> Larry
Perhaps you can make use of my WIP that I didn't have time to finish:
https://github.com/covanam/linux/commit/ee8a0719ec8535f932b30aa67325fc21ba998c50
(Untested and the label names are kind of dumb)
Best regards,
Nam
prev parent reply other threads:[~2023-07-13 20:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-12 20:57 [PATCH] staging: 7811: Fix memory leak in _r8712_init_xmit_priv Larry Finger
2023-07-13 17:35 ` Your Name
2023-07-13 18:51 ` Larry Finger
2023-07-13 20:10 ` Nam Cao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZLBaO2/p32h0enDT@nam-dell \
--to=namcaov@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linux-wireless@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=syzbot+cf71097ffb6755df8251@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.