All of lore.kernel.org
 help / color / mirror / Atom feed
From: AKASHI Takahiro <takahiro.akashi@linaro.org>
To: trini@konsulko.com
Cc: etienne.carriere@linaro.org, u-boot@lists.denx.de
Subject: Re: [PATCH] firmware: scmi: return a right errno for SCMI status code
Date: Fri, 14 Jul 2023 09:55:03 +0900	[thread overview]
Message-ID: <ZLCc59W4_ytVZYeB@laputa> (raw)
In-Reply-To: <20230613013045.36684-1-takahiro.akashi@linaro.org>

Hi Tom,

Can you pick up this patch, please?
It's an easy bugfix.

-Takahiro Akashi

On Tue, Jun 13, 2023 at 10:30:45AM +0900, AKASHI Takahiro wrote:
> scmi_to_linux_errno() is set to return an appropriate errno
> which corresponds to a given SCMI status code.
> But the current implementation always returns the same value.
> 
> Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
> ---
>  drivers/firmware/scmi/scmi_agent-uclass.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/firmware/scmi/scmi_agent-uclass.c b/drivers/firmware/scmi/scmi_agent-uclass.c
> index 54d563d929b8..02de692d66f3 100644
> --- a/drivers/firmware/scmi/scmi_agent-uclass.c
> +++ b/drivers/firmware/scmi/scmi_agent-uclass.c
> @@ -46,7 +46,7 @@ int scmi_to_linux_errno(s32 scmi_code)
>  
>  	for (n = 0; n < ARRAY_SIZE(scmi_linux_errmap); n++)
>  		if (scmi_code == scmi_linux_errmap[n].scmi)
> -			return scmi_linux_errmap[1].errno;
> +			return scmi_linux_errmap[n].errno;
>  
>  	return -EPROTO;
>  }
> -- 
> 2.41.0
> 

  reply	other threads:[~2023-07-14  0:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-13  1:30 [PATCH] firmware: scmi: return a right errno for SCMI status code AKASHI Takahiro
2023-07-14  0:55 ` AKASHI Takahiro [this message]
2023-07-15 15:03 ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZLCc59W4_ytVZYeB@laputa \
    --to=takahiro.akashi@linaro.org \
    --cc=etienne.carriere@linaro.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.