From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E8122EB64DA for ; Fri, 14 Jul 2023 12:31:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lSf3FxU2UEErO6v7fOHFKVE0UgElK4rE66/Sotj0lwc=; b=srEOtJxV/P/6om Yq0KA6LHzT30Mr7E4wJVZCjD5iSLzihFbjDkwSMGWfH6PSNNakuULTB2apHS7bFYGQESIfVhRxiYL yWzBHgDOwe894/fnmNmepAVRfpoUFosChCrKQlCa7vYxmmZXb2HeqOhzn+DESpxHBGiIRHYPTGmaT D3LyOdYMaxkkLFkZMWrfcoGtFdJRiipY5m5320X0sxPBadoN6D3pO4IV8en3eURedYtwv3vDIMmKE 2xd3Foy9lVeQfJtL+pfqRFJM2i9p2rovkRmz9YZWKh5idIglwyKyGoMYb4YfKtYgwHWX9U0KeI5Ru moEoclwEyrw1j34o90lg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qKHwl-006CUG-1X; Fri, 14 Jul 2023 12:30:55 +0000 Received: from mga07.intel.com ([134.134.136.100]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qKHwh-006CTd-30 for linux-arm-kernel@lists.infradead.org; Fri, 14 Jul 2023 12:30:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1689337851; x=1720873851; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=JdFpBHyC/qLU5qvdOKxXfGdeJI86rvSkdXEkIR/E2gc=; b=BosqOs38xbpS1FcI3M60XkeRDN9ChAa5Mt3KlMUvkIrvd9zUIDeChUo9 6/DcrKOwQ15NEG9FDpl4dRM0XiBQEN0lWW04jNysCWljmf0yEq6XHzylt d1789LO/aNobQm+kjPE6Xv7qNqQtM37KbXlZeYMKdQVlV3sjn47SNQD+W O4WObar03R9M3MApMVXzY/CXr9qY689TRaGFugs4qLe/WzYFgjx7npS+p IXkVJJUmQTSoXrSImIu5TR/J0OfYRkN6efju0rW0KkrGF2EnXNcTyCxb7 IBkyMN+YVA3JL7BSOdAqHpYsEEYkqjCW79637Mn+4Cms9QvtT93gC0ngB Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10770"; a="431634505" X-IronPort-AV: E=Sophos;i="6.01,205,1684825200"; d="scan'208";a="431634505" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jul 2023 05:30:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10770"; a="716323813" X-IronPort-AV: E=Sophos;i="6.01,205,1684825200"; d="scan'208";a="716323813" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga007.jf.intel.com with ESMTP; 14 Jul 2023 05:30:28 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qKHwI-002eu6-1E; Fri, 14 Jul 2023 15:30:26 +0300 Date: Fri, 14 Jul 2023 15:30:26 +0300 From: Andy Shevchenko To: Alexander Potapenko Cc: William Breathitt Gray , catalin.marinas@arm.com, will@kernel.org, pcc@google.com, andreyknvl@gmail.com, linux@rasmusvillemoes.dk, yury.norov@gmail.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, eugenis@google.com Subject: Re: [v2 1/5] lib/bitmap: add bitmap_{set,get}_value_unaligned() Message-ID: References: <20230713125706.2884502-1-glider@google.com> <20230713125706.2884502-2-glider@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230714_053052_013856_32BC02EB X-CRM114-Status: GOOD ( 24.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCBKdWwgMTQsIDIwMjMgYXQgMDI6MDc6NDVQTSArMDIwMCwgQWxleGFuZGVyIFBvdGFw ZW5rbyB3cm90ZToKPiBPbiBGcmksIEp1bCAxNCwgMjAyMyBhdCAxOjI44oCvUE0gQW5keSBTaGV2 Y2hlbmtvCj4gPGFuZHJpeS5zaGV2Y2hlbmtvQGxpbnV4LmludGVsLmNvbT4gd3JvdGU6Cj4gPiBP biBGcmksIEp1bCAxNCwgMjAyMyBhdCAwNzoxOToxNUFNIC0wNDAwLCBXaWxsaWFtIEJyZWF0aGl0 dCBHcmF5IHdyb3RlOgo+ID4gPiBPbiBGcmksIEp1bCAxNCwgMjAyMyBhdCAxMTowNDoxNkFNICsw MzAwLCBBbmR5IFNoZXZjaGVua28gd3JvdGU6Cj4gPiA+ID4gT24gVGh1LCBKdWwgMTMsIDIwMjMg YXQgMDg6MDU6MzRQTSArMDIwMCwgQWxleGFuZGVyIFBvdGFwZW5rbyB3cm90ZToKCi4uLgoKPiA+ ID4gPiBXaWxsaWFtLCB3aGF0IGRvIHlvdSB0aGluayBvbiB0aGlzPwo+ID4gPiA+Cj4gPiA+ID4g SSdtIHBlcnNvbmFsbHkgcHJlZmVyIFdpbGxpYW0ncyB2ZXJzaW9uIGFzIG5vdCBvbmx5IGl0IHdh cyBwdWJsaXNoZWQgZmlyc3QKPiA+ID4gPiBpdCB3YXMgY2FyZWZ1bGx5IGRlc2lnbmVkIGFuZCBn b3QgYSBsb3Qgb2YgcmV2aWV3IGFscmVhZHkuIFdlIGp1c3QgaGFkbid0IGhhZAo+ID4gPiA+IHRo ZSB1c2VyIGZvciBpdCB0aGF0IHRpbWUuCj4gPiA+Cj4gPiA+IFllcywgdGhhdCB2ZXJzaW9uIHdl bnQgdGhyb3VnaCBzZXZlcmFsIHJldmlzaW9ucyBzbyBpdCdzIGJlZW4gd2VsbAo+ID4gPiB0ZXN0 ZWQgYW5kIGtub3duIHRvIHdvcmsgLS0gYXMgeW91IHBvaW50ZWQgb3V0IGl0IGp1c3QgbGFja2Vk IHRoZSB1c2Vycwo+ID4gPiB0byB3YXJyYW50IG1lcmdpbmcgaXQgaW50byB0aGUgdHJlZS4gSWYg aXQgc3RhdGlzZmllcyB0aGUgdXNlLWNhc2UKPiA+ID4gcmVxdWlyZWQgaGVyZSBub3csIHRoZW4g SSB0aGluayB3ZSBzaG91bGQgaXQgcGljayBpdCB1cCByYXRoZXIgdGhhbgo+ID4gPiByZWludmVu dCB0aGUgc29sdXRpb24gYWdhaW4uCj4gPiA+Cj4gPiA+IEFsc28sIHdlIHByb2JhYmx5IGRvbid0 IG5lZWQgdGhlICJjbHVtcCIgY29kZSBpbiB0aGVyZSwgc28gcGVyaGFwcwo+ID4gPiBzcGxpdHRp bmcgaXQgb3V0IHRvIGp1c3QgdGhlIGJpdG1hcF97c2V0LGdldH1fdmFsdWUgcmVsZXZhbnQgY29k ZSBpcwo+ID4gPiBmaW5lLgo+ID4KPiA+IEFncmVlLCB0aGFuayB5b3UgZm9yIHlvdXIgY29tbWVu dHMhCgo+IFNvIHdvdWxkIGl0IGJlIGZpbmUgaWYgSSBzcGxpdCBvZmYgYml0bWFwX3NldF92YWx1 ZSgpIGFuZAo+IGJpdG1hcF9nZXRfdmFsdWUoKSBmcm9tIHRoYXQgc2VyaWVzIGFuZCBzZW5kIGl0 ICh3aXRoIHRoZSBhcHByb3ByaWF0ZQo+IGF0dHJpYnV0aW9uKSBpbnN0ZWFkIG9mIG15IHBhdGNo IDEvNT8KPiBXZSdsbCBwcm9iYWJseSBzdGlsbCBuZWVkIHRvIHJldGFpbiBwYXRjaCAyLzUgKHdp dGggdGhlIGZ1bmN0aW9uIG5hbWVzCj4gY2hhbmdlZCkuCgpTb3VuZHMgZ29vZCB0byBtZS4KCi0t IApXaXRoIEJlc3QgUmVnYXJkcywKQW5keSBTaGV2Y2hlbmtvCgoKCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBs aXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5m cmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80822EB64DA for ; Fri, 14 Jul 2023 12:32:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235746AbjGNMcn (ORCPT ); Fri, 14 Jul 2023 08:32:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44806 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235016AbjGNMcj (ORCPT ); Fri, 14 Jul 2023 08:32:39 -0400 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D4A013AAD for ; Fri, 14 Jul 2023 05:32:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1689337933; x=1720873933; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=JdFpBHyC/qLU5qvdOKxXfGdeJI86rvSkdXEkIR/E2gc=; b=ZAIJAAvVaEZfBvYmFYUp4E7egCIX26yj0VLCGLcW8q+VM12JpTce6e+x J65JZDhkLYmtt7QV4UdqJwHcAYOJJU6nIs9olN6F/dKK/KgJh8zFZMxZN BBS5WhMM9ZwsGMa/DkaF7KRvna9uDXGOatEuub7xw6+7Ah+Uc+uSupRjW KgWNapVSjblI+6heXKCRNxXAuySL7ZgL8uQ3O4IF09Tj+Um9w7AJrmO6f mWWm7ucMzPBdXrVjEVRAJizsHIGhsHuVtLbmnPH4mVgUbLL9FALK4BMyo vTv+coRUWNVdk6Ldf+6emrTFYhrGC9tgRejJl5HggVWroba1/w9BerfJD Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10770"; a="431634503" X-IronPort-AV: E=Sophos;i="6.01,205,1684825200"; d="scan'208";a="431634503" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jul 2023 05:30:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10770"; a="716323813" X-IronPort-AV: E=Sophos;i="6.01,205,1684825200"; d="scan'208";a="716323813" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga007.jf.intel.com with ESMTP; 14 Jul 2023 05:30:28 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qKHwI-002eu6-1E; Fri, 14 Jul 2023 15:30:26 +0300 Date: Fri, 14 Jul 2023 15:30:26 +0300 From: Andy Shevchenko To: Alexander Potapenko Cc: William Breathitt Gray , catalin.marinas@arm.com, will@kernel.org, pcc@google.com, andreyknvl@gmail.com, linux@rasmusvillemoes.dk, yury.norov@gmail.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, eugenis@google.com Subject: Re: [v2 1/5] lib/bitmap: add bitmap_{set,get}_value_unaligned() Message-ID: References: <20230713125706.2884502-1-glider@google.com> <20230713125706.2884502-2-glider@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 14, 2023 at 02:07:45PM +0200, Alexander Potapenko wrote: > On Fri, Jul 14, 2023 at 1:28 PM Andy Shevchenko > wrote: > > On Fri, Jul 14, 2023 at 07:19:15AM -0400, William Breathitt Gray wrote: > > > On Fri, Jul 14, 2023 at 11:04:16AM +0300, Andy Shevchenko wrote: > > > > On Thu, Jul 13, 2023 at 08:05:34PM +0200, Alexander Potapenko wrote: ... > > > > William, what do you think on this? > > > > > > > > I'm personally prefer William's version as not only it was published first > > > > it was carefully designed and got a lot of review already. We just hadn't had > > > > the user for it that time. > > > > > > Yes, that version went through several revisions so it's been well > > > tested and known to work -- as you pointed out it just lacked the users > > > to warrant merging it into the tree. If it statisfies the use-case > > > required here now, then I think we should it pick it up rather than > > > reinvent the solution again. > > > > > > Also, we probably don't need the "clump" code in there, so perhaps > > > splitting it out to just the bitmap_{set,get}_value relevant code is > > > fine. > > > > Agree, thank you for your comments! > So would it be fine if I split off bitmap_set_value() and > bitmap_get_value() from that series and send it (with the appropriate > attribution) instead of my patch 1/5? > We'll probably still need to retain patch 2/5 (with the function names > changed). Sounds good to me. -- With Best Regards, Andy Shevchenko