From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Luo Jie <quic_luoj@quicinc.com>
Cc: andrew@lunn.ch, hkallweit1@gmail.com, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/6] net: phy: at803x: remove qca8081 1G fast retrain and slave seed config
Date: Fri, 14 Jul 2023 12:41:02 +0100 [thread overview]
Message-ID: <ZLE0Tr4Tn+C0fI+V@shell.armlinux.org.uk> (raw)
In-Reply-To: <20230714063136.21368-6-quic_luoj@quicinc.com>
On Fri, Jul 14, 2023 at 02:31:35PM +0800, Luo Jie wrote:
> The fast retrain and master slave seed configs are only applicable when
> the 2.5G capability is supported.
Probably worth a comment - or a helper function.
E.g.
static bool qca808x_has_fast_retrain(struct phy_device *phydev)
{
return linkmode_test_bit(ETHTOOL_LINK_MODE_2500baseT_Full_BIT,
phydev->supported);
}
Which then makes the code more self-documenting.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2023-07-14 11:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-14 6:31 [PATCH v2 0/6] net: phy: at803x: support qca8081 1G version chip Luo Jie
2023-07-14 6:31 ` [PATCH v2 1/6] net: phy: at803x: support qca8081 genphy_c45_pma_read_abilities Luo Jie
2023-07-14 10:44 ` Russell King (Oracle)
2023-07-15 14:49 ` Jie Luo
2023-07-14 6:31 ` [PATCH v2 2/6] net: phy: at803x: merge qca8081 salve seed function Luo Jie
2023-07-14 10:48 ` Russell King (Oracle)
2023-07-15 14:51 ` Jie Luo
2023-07-14 6:31 ` [PATCH v2 3/6] net: phy: at803x: enable qca8081 slave seed conditionally Luo Jie
2023-07-14 13:16 ` Andrew Lunn
2023-07-14 6:31 ` [PATCH v2 4/6] net: phy: at803x: support qca8081 1G chip type Luo Jie
2023-07-14 11:38 ` Russell King (Oracle)
2023-07-14 6:31 ` [PATCH v2 5/6] net: phy: at803x: remove qca8081 1G fast retrain and slave seed config Luo Jie
2023-07-14 11:41 ` Russell King (Oracle) [this message]
2023-07-15 14:54 ` Jie Luo
2023-07-14 6:31 ` [PATCH v2 6/6] net: phy: at803x: add qca8081 fifo reset on the link changed Luo Jie
2023-07-14 11:41 ` Russell King (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZLE0Tr4Tn+C0fI+V@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=quic_luoj@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.