From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F625EB64DA for ; Fri, 14 Jul 2023 08:58:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235713AbjGNI6W (ORCPT ); Fri, 14 Jul 2023 04:58:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33652 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235717AbjGNI6V (ORCPT ); Fri, 14 Jul 2023 04:58:21 -0400 Received: from 167-179-156-38.a7b39c.syd.nbn.aussiebb.net (167-179-156-38.a7b39c.syd.nbn.aussiebb.net [167.179.156.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 98AF02713; Fri, 14 Jul 2023 01:58:20 -0700 (PDT) Received: from gwarestrin.arnor.me.apana.org.au ([192.168.103.7]) by fornost.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1qKEcw-001RhJ-1C; Fri, 14 Jul 2023 18:58:15 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Fri, 14 Jul 2023 18:58:07 +1000 Date: Fri, 14 Jul 2023 18:58:07 +1000 From: Herbert Xu To: Martin Kaiser Cc: linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] hwrng: imx-rngc - use dev_err_probe Message-ID: References: <20230704170644.69669-1-martin@kaiser.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230704170644.69669-1-martin@kaiser.cx> Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Tue, Jul 04, 2023 at 07:06:44PM +0200, Martin Kaiser wrote: > Simplify the code by calling dev_err_probe instead of dev_err and return. > > While at it, use the same device for all error messages. > > Signed-off-by: Martin Kaiser > --- > drivers/char/hw_random/imx-rngc.c | 24 ++++++++---------------- > 1 file changed, 8 insertions(+), 16 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F10DFEB64DA for ; Fri, 14 Jul 2023 08:58:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NOJ+bUaYW1Q3/Sw01vyqrv5aCmFn2DawXTseHfKHA1w=; b=DEM7OtvHuW94Ci B4rD8hvI/pPzS37TdxH2X26kZxJNB1xdQUxffDM4WJHaPHZbX43AwzTdv8YPvaX94kNH+/xYLKUJ4 BWsk0cY/AlYw7RypbxEiJtV5h9CZv+nxkD/WvyGTlnosUQf3gGHkOR8HGdqdb6HBaTFRqfUBwYpvb wMlF+r4EQtYQm3UKaBTUrA0PDnBNqQlAWHF/B3iPUr7YycBVZfv1qLBXmSHyExqUStMtXnxV1xOAZ KFogBrY1uJt4URFvaWq/vGrL9v6d2QVTqfT3OAckhFUFT0TSS3QxKKHwItkYjweWCewd7WuKT5axf FrxuLOegvMlCTagyE+Fw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qKEd1-005bgK-1i; Fri, 14 Jul 2023 08:58:19 +0000 Received: from 167-179-156-38.a7b39c.syd.nbn.aussiebb.net ([167.179.156.38]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qKEcz-005bfJ-09 for linux-arm-kernel@lists.infradead.org; Fri, 14 Jul 2023 08:58:18 +0000 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.103.7]) by fornost.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1qKEcw-001RhJ-1C; Fri, 14 Jul 2023 18:58:15 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Fri, 14 Jul 2023 18:58:07 +1000 Date: Fri, 14 Jul 2023 18:58:07 +1000 From: Herbert Xu To: Martin Kaiser Cc: linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] hwrng: imx-rngc - use dev_err_probe Message-ID: References: <20230704170644.69669-1-martin@kaiser.cx> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230704170644.69669-1-martin@kaiser.cx> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230714_015817_083486_F9017A64 X-CRM114-Status: GOOD ( 11.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jul 04, 2023 at 07:06:44PM +0200, Martin Kaiser wrote: > Simplify the code by calling dev_err_probe instead of dev_err and return. > > While at it, use the same device for all error messages. > > Signed-off-by: Martin Kaiser > --- > drivers/char/hw_random/imx-rngc.c | 24 ++++++++---------------- > 1 file changed, 8 insertions(+), 16 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel